From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 794DE197A90; Fri, 14 Jun 2024 12:34:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718368449; cv=none; b=atS+0H7xlX8+6Cirzpl3DPn5E8FE1boS/ye/CxIYf18rW4vpi/8Q3ba+3jme7atjDo+d5I7cg1XtMNjHnSyk9GCZKKxZGPXjHPZdOxrp2IJgTfw8UNDo+hzrHafNP5iOc6RDs8JO8JjbmTbdv2krNKIJmwPVSR2905mjNJQLzCE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718368449; c=relaxed/simple; bh=B2nOjYL3lFg4bp1IsZgH4scpFXv01qJzfqLMfIueunY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K7XyJcVCFKJIkqeHNfW7qZFRDrK1mqKGWGYzhbs9Lq/odAO3gANTH1MZ4C/z9F1Rg1XsjPHRIiNGxMJrJr3FMKuwOJjkNYy7ksjov/P+DLn1kCziXYvAhPWW9V4ml0eP4PdWli+8JoV34Po7GNJpt6mV68uwmigAvw6e3xL9T4s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=wfalRvyS; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="wfalRvyS" Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A86A17047; Fri, 14 Jun 2024 14:33:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1718368430; bh=B2nOjYL3lFg4bp1IsZgH4scpFXv01qJzfqLMfIueunY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wfalRvyS2jqZaU2aTE1qzDFVqvw+JjmEL4BWenYU2ak8p855BAIf301hhF72gYjeD tmBqjnpSmcZ8VcP/ZNyfhERe6jDNPMfhKlUhOE+iITaPA0/rbKnaffGNDt66mg4wAc ctes+j4do1WRWp4aECKVv0LRmTGKC62ESHXis1GA= Date: Fri, 14 Jun 2024 15:33:45 +0300 From: Laurent Pinchart To: Julien Stephan Cc: AngeloGioacchino Del Regno , Louis Kuo , Phi-bang Nguyen , Florian Sylvestre , Andy Hsieh , Conor Dooley , devicetree@vger.kernel.org, Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org, Matthias Brugger , Mauro Carvalho Chehab , Paul Elder , Rob Herring Subject: Re: [PATCH v4 3/5] media: platform: mediatek: isp_30: add mediatek ISP3.0 sensor interface Message-ID: <20240614123345.GN6019@pendragon.ideasonboard.com> References: <20240110141443.364655-1-jstephan@baylibre.com> <20240110141443.364655-4-jstephan@baylibre.com> <3c2bee40-3792-409c-b42f-f8b013ff641c@collabora.com> <53838e76-bfa4-41f5-a015-a37472e98991@collabora.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Jun 14, 2024 at 12:38:15PM +0200, Julien Stephan wrote: > Le mer. 12 juin 2024 à 10:06, AngeloGioacchino Del Regno a écrit : > > > > Il 10/06/24 16:39, Julien Stephan ha scritto: > [...] > > >> > > >>> + writel(0x10001, input->base + SENINF_TG1_SEN_CK); > > >> > > >> Unroll this one... this is the TG1 sensor clock divider. > > >> > > >> CLKFL GENMASK(5, 0) > > >> CLKRS GENMASK(13, 8) > > >> CLKCNT GENMASK(21,16) > > >> > > >> Like this, I don't get what you're trying to set, because you're using a fixed > > >> sensor clock rate, meaning that only a handful of camera sensors will be usable. > > >> > > >> Is this 8Mhz? 16? 24? what? :-) > > >> > > >> Two hints: > > >> - sensor_clk = clk_get_rate(isp_clk) / (tg1_sen_ck_clkcnt + 1); > > >> - int mtk_seninf_set_sensor_clk(u8 rate_mhz); > > >> > > >> Please :-) > > > > > > Hi Angelo, > > > > > > I think I get your point about not hardcoding the sensor rate, but I > > > am not sure how to use > > > a mtk_seninf_set_sensor_clk(u8 rate_mhz); function. > > > > > > Where would it be called? How is it exposed to the user? > > > > > > > As for where: setup, streaming start, resolution change (which may be covered > > by streaming start anyway, as a change should be calling stop->start anyway). > > > > And for the how is it exposed to the user - well, depends what you mean for user, > > but it's all standard V4L2 API :-) > > > > Last but not least, I can give you another hint.... > > > > struct media_entity *entity = (something_here); > > struct media_pad *mpad; > > struct v4l2_subdev *cam_subdev; > > struct v4l2_ctrl *ctl; > > s64 link_frequency, pixel_clock; > > > > if (entity->pads[0].flags & MEDIA_PAD_FL_SINK) > > return -E_NOT_A_CAMERA_SENSOR_WE_IGNORE_THIS_ONE; > > > > pad = media_pad_remote_pad_first(&entity->pads[0]); > > if (!pad) > > return -ENOENT; > > > > if (!is_media_entity_v4l2_subdev(pad->entity)) > > return -ENOENT; > > > > if (pad->entity->function != MEDIA_ENT_F_CAM_SENSOR) > > return -ENOENT; > > > > Hi Angelo, > > Thank you for the detailed explanation :) > However, I can't make it work because in my case, seninf is connected > to an external ISP > so pad->entity->function == MEDIA_ENT_F_PROC_VIDEO_ISP. > > How can I get the pad corresponding to the sensor? You don't have to. You can drop that check, and get the link frequency of the source subdev with v4l2_get_link_freq(), whatever it is. > > cam_subdev = media_entity_to_v4l2_subdev(pad->entity); > > ctl = v4l2_ctrl_find(subdev->ctrl_handler, V4L2_CID_PIXEL_RATE); > > Is this mandatory to implement V4L2_CID_PIXEL_RATE ? > Should I return an error if not found? Does SENINF need to know both the pixel rate and link frequency ? V4L2_CID_PIXEL_RATE is very ill-defined, at the moment it only makes sense as a value relative to the sensor pixel array, and doesn't really apply further down in the pipeline. What information do you need to program the SENINF ? > > /* multiplier is usually bits per pixel, divider is usually num of lanes */ > > link_frequency = v4l2_get_link_freq(cam_subdev->ctrl_handler, multiplier, divider); > > pixel_clock = v4l2_ctrl_g_ctrl_int64(ctl); > > How to know the sensor clock given link_frequency and pixel_clock? > Can you point me to drivers doing something similar? > > > > > ....now you know what the sensor wants, set the seninf sensor clock accordingly. > > > > Cheers > > Angelo > > > [...] -- Regards, Laurent Pinchart