Re: [PATCH 04/12] clk: renesas: clk-vbattb: Add VBATTB clock driver

kernel test robot
2024-06-16T00:20:08Z

Hi Claudiu,

kernel test robot noticed the following build warnings:

[auto build test WARNING on geert-renesas-drivers/renesas-clk]
[also build test WARNING on geert-renesas-devel/next linus/master v6.10-rc3 next-20240613]
[cannot apply to abelloni/rtc-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Claudiu/clk-renesas-r9a08g045-Add-clock-reset-and-power-domain-support-for-the-VBATTB-IP/20240614-152418
base: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git renesas-clk
patch link: https://lore.kernel.org/r/20240614071932.1014067-5-claudiu.beznea.uj%40bp.renesas.com
patch subject: [PATCH 04/12] clk: renesas: clk-vbattb: Add VBATTB clock driver
config: mips-randconfig-r122-20240616 (https://download.01.org/0day-ci/archive/20240616/202406160847.Ns62KOVc-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20240616/202406160847.Ns62KOVc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406160847.Ns62KOVc-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/clk/renesas/clk-vbattb.c:132:35: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned int [usertype] size @@ got restricted gfp_t @@
drivers/clk/renesas/clk-vbattb.c:132:35: sparse: expected unsigned int [usertype] size
drivers/clk/renesas/clk-vbattb.c:132:35: sparse: got restricted gfp_t
>> drivers/clk/renesas/clk-vbattb.c:132:47: sparse: sparse: incorrect type in argument 3 (different base types) @@ expected restricted gfp_t [usertype] gfp @@ got unsigned int @@
drivers/clk/renesas/clk-vbattb.c:132:47: sparse: expected restricted gfp_t [usertype] gfp
drivers/clk/renesas/clk-vbattb.c:132:47: sparse: got unsigned int
drivers/clk/renesas/clk-vbattb.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/xarray.h, ...):
include/linux/page-flags.h:240:46: sparse: sparse: self-comparison always evaluates to false
include/linux/page-flags.h:240:46: sparse: sparse: self-comparison always evaluates to false

vim +132 drivers/clk/renesas/clk-vbattb.c

119
120 static int vbattb_clk_probe(struct platform_device *pdev)
121 {
122 struct clk_parent_data parent_data = { .fw_name = "vbattb_xtal" };
123 struct device_node *np = pdev->dev.of_node;
124 struct device *dev = &pdev->dev;
125 struct clk_init_data init = {};
126 struct vbattb_clk *vbclk;
127 u32 load_capacitance;
128 struct clk_hw *hw;
129 bool bypass;
130 int ret;
131
> 132 vbclk = devm_kzalloc(dev, GFP_KERNEL, sizeof(*vbclk));
133 if (!vbclk)
134 return -ENOMEM;
135
136 vbclk->regmap = syscon_node_to_regmap(np->parent);
137 if (IS_ERR(vbclk->regmap))
138 return PTR_ERR(vbclk->regmap);
139
140 bypass = of_property_read_bool(np, "renesas,vbattb-osc-bypass");
141 ret = of_property_read_u32(np, "renesas,vbattb-load-nanofarads", &load_capacitance);
142 if (ret)
143 return ret;
144
145 ret = vbattb_clk_validate_load_capacitance(vbclk, load_capacitance);
146 if (ret)
147 return ret;
148
149 ret = devm_pm_runtime_enable(dev);
150 if (ret)
151 return ret;
152
153 ret = pm_runtime_resume_and_get(dev);
154 if (ret)
155 return ret;
156
157 regmap_update_bits(vbclk->regmap, VBATTB_BKSCCR, VBATTB_BKSCCR_SOSEL,
158 bypass ? VBATTB_BKSCCR_SOSEL : 0);
159
160 init.name = "vbattclk";
161 init.ops = &vbattb_clk_ops;
162 init.parent_data = &parent_data;
163 init.num_parents = 1;
164 init.flags = 0;
165
166 vbclk->hw.init = &init;
167 hw = &vbclk->hw;
168
169 spin_lock_init(&vbclk->lock);
170
171 ret = devm_clk_hw_register(dev, hw);
172 if (ret)
173 goto rpm_put;
174
175 ret = of_clk_add_hw_provider(np, of_clk_hw_simple_get, hw);
176 if (ret)
177 goto rpm_put;
178
179 return 0;
180
181 rpm_put:
182 pm_runtime_put(dev);
183 return ret;
184 }
185

--
0-DAY CI Kernel Test Service