From: Conor Dooley <conor@kernel.org>
To: Kaustabh Chakraborty <kauschluss@disroot.org>
Cc: linux-iio@vger.kernel.org, jic23@kernel.org, denis.ciocca@st.com,
devicetree@vger.kernel.org, linus.walleij@linaro.org,
robh+dt@kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: iio: st-sensors: add LIS2DS12 accelerometer
Date: Sat, 15 Jun 2024 13:11:04 +0100 [thread overview]
Message-ID: <20240615-urgent-mammogram-3eb5ca127239@spud> (raw)
In-Reply-To: <56ab50d7c542356b7e377023b84a6018@disroot.org>
[-- Attachment #1: Type: text/plain, Size: 639 bytes --]
On Sat, Jun 15, 2024 at 09:46:59AM +0000, Kaustabh Chakraborty wrote:
> On 2024-06-11 18:17, Conor Dooley wrote:
> > On Tue, Jun 11, 2024 at 09:35:53PM +0530, Kaustabh Chakraborty wrote:
> >> Add compatible for LIS2DS12 accelerometer by STMicroelectronics.
> >
> > I can see that! Your commit message should mention why this device
> > is not compatible with existing variants.
>
> Sure, is adding the WhoAmI value enough? Or do I also have to
> explain the different registers and sensor settings.
The whoami isn't sufficient, but if there's registers that behave
differently etc, please mention those.
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-06-15 12:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 16:05 [PATCH v4 1/2] iio: accel: st_accel: add support for LIS2DS12 Kaustabh Chakraborty
2024-06-11 16:05 ` [PATCH v4 2/2] dt-bindings: iio: st-sensors: add LIS2DS12 accelerometer Kaustabh Chakraborty
2024-06-11 18:17 ` Conor Dooley
2024-06-15 9:46 ` Kaustabh Chakraborty
2024-06-15 12:11 ` Conor Dooley [this message]
2024-06-15 17:56 ` Jonathan Cameron
2024-06-15 13:49 ` Jonathan Cameron
2024-06-18 12:21 ` Kaustabh Chakraborty
2024-06-18 17:38 ` Conor Dooley
2024-06-20 16:42 ` Kaustabh Chakraborty
2024-06-21 14:21 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240615-urgent-mammogram-3eb5ca127239@spud \
--to=conor@kernel.org \
--cc=denis.ciocca@st.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kauschluss@disroot.org \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox