From: Conor Dooley <conor@kernel.org>
To: Drew Fustini <dfustini@tenstorrent.com>
Cc: Jisheng Zhang <jszhang@kernel.org>, Guo Ren <guoren@kernel.org>,
Fu Wei <wefu@redhat.com>, Yangtao Li <frank.li@vivo.com>,
Thomas Bonnefille <thomas.bonnefille@bootlin.com>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: clock: Document T-Head TH1520 AP_SUBSYS controller
Date: Sun, 16 Jun 2024 19:38:21 +0100 [thread overview]
Message-ID: <20240616-reaffirm-thud-e3fb4de33d7f@spud> (raw)
In-Reply-To: <20240615-th1520-clk-v1-1-3ba4978c4d6b@tenstorrent.com>
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
On Sat, Jun 15, 2024 at 06:54:30PM -0700, Drew Fustini wrote:
> +examples:
> + - |
> + #include <dt-bindings/clock/thead,th1520-clk-ap.h>
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + clock-controller@ffef010000 {
> + compatible = "thead,th1520-clk-ap";
> + reg = <0xff 0xef010000 0x0 0x1000>;
Drop the 2 cell stuff here, it's not needed in the example.
Otherwise, looks okay to me.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> + clocks = <&osc>;
> + #clock-cells = <1>;
> + };
> + };
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-06-16 18:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-16 1:54 [PATCH 0/6] clk: thead: Add support for TH1520 AP_SUBSYS clock controller Drew Fustini
2024-06-16 1:54 ` [PATCH 1/6] dt-bindings: clock: Document T-Head TH1520 AP_SUBSYS controller Drew Fustini
2024-06-16 18:38 ` Conor Dooley [this message]
2024-06-16 1:54 ` [PATCH 2/6] clk: thead: Add support for T-Head TH1520 AP_SUBSYS clocks Drew Fustini
2024-06-16 1:54 ` [PATCH 3/6] riscv: dts: thead: Add TH1520 AP_SUBSYS clock controller Drew Fustini
2024-06-16 1:54 ` [PATCH 4/6] riscv: dts: thead: change TH1520 uart nodes to use " Drew Fustini
2024-06-16 1:54 ` [PATCH 5/6] riscv: dts: thead: change TH1520 mmc " Drew Fustini
2024-06-16 1:54 ` [PATCH 6/6] riscv: dts: thead: update TH1520 dma and timer " Drew Fustini
2024-06-19 11:12 ` [PATCH 0/6] clk: thead: Add support for TH1520 AP_SUBSYS " Conor Dooley
2024-06-19 18:15 ` Drew Fustini
2024-06-20 16:30 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240616-reaffirm-thud-e3fb4de33d7f@spud \
--to=conor@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dfustini@tenstorrent.com \
--cc=emil.renner.berthing@canonical.com \
--cc=frank.li@vivo.com \
--cc=guoren@kernel.org \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=thomas.bonnefille@bootlin.com \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).