From: Michael Walle <mwalle@kernel.org>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Li Yang <leoyang.li@nxp.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Priit Laes <plaes@plaes.org>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Marco Felsch <m.felsch@pengutronix.de>,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Michael Walle <mwalle@kernel.org>
Subject: [PATCH v3 05/13] ARM: dts: imx6qdl-kontron-samx6i: fix SPI0 chip selects
Date: Mon, 17 Jun 2024 11:13:33 +0200 [thread overview]
Message-ID: <20240617091341.2375325-6-mwalle@kernel.org> (raw)
In-Reply-To: <20240617091341.2375325-1-mwalle@kernel.org>
There is a comment in the imx6q variant dtsi claiming that these
modules will have one more chip select than the imx6dl variant.
This is wrong. Ordinary GPIOs are used for chip selects and both
variants of the module share the very same PCB and both have this
GPIO routed to the SPI0_CS1# pin of the SMARC connector.
Fix it by moving the third chip select description to the common dtsi.
Fixes: 2125212785c9 ("ARM: dts: imx6qdl-kontron-samx6i: add Kontron SMARC SoM Support")
Signed-off-by: Michael Walle <mwalle@kernel.org>
---
.../dts/nxp/imx/imx6q-kontron-samx6i.dtsi | 23 -------------------
.../dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi | 5 +++-
2 files changed, 4 insertions(+), 24 deletions(-)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi
index 4d6a0c3e8455..ff062f4fd726 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi
@@ -5,31 +5,8 @@
#include "imx6q.dtsi"
#include "imx6qdl-kontron-samx6i.dtsi"
-#include <dt-bindings/gpio/gpio.h>
/ {
model = "Kontron SMARC sAMX6i Quad/Dual";
compatible = "kontron,imx6q-samx6i", "fsl,imx6q";
};
-
-/* Quad/Dual SoMs have 3 chip-select signals */
-&ecspi4 {
- cs-gpios = <&gpio3 24 GPIO_ACTIVE_LOW>,
- <&gpio3 29 GPIO_ACTIVE_LOW>,
- <&gpio3 25 GPIO_ACTIVE_LOW>;
-};
-
-&pinctrl_ecspi4 {
- fsl,pins = <
- MX6QDL_PAD_EIM_D21__ECSPI4_SCLK 0x100b1
- MX6QDL_PAD_EIM_D28__ECSPI4_MOSI 0x100b1
- MX6QDL_PAD_EIM_D22__ECSPI4_MISO 0x100b1
-
- /* SPI4_IMX_CS2# - connected to internal flash */
- MX6QDL_PAD_EIM_D24__GPIO3_IO24 0x1b0b0
- /* SPI4_IMX_CS0# - connected to SMARC SPI0_CS0# */
- MX6QDL_PAD_EIM_D29__GPIO3_IO29 0x1b0b0
- /* SPI4_CS3# - connected to SMARC SPI0_CS1# */
- MX6QDL_PAD_EIM_D25__GPIO3_IO25 0x1b0b0
- >;
-};
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi
index 8c7f21f986e1..4a6ab7e7908a 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi
@@ -244,7 +244,8 @@ &ecspi4 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_ecspi4>;
cs-gpios = <&gpio3 24 GPIO_ACTIVE_LOW>,
- <&gpio3 29 GPIO_ACTIVE_LOW>;
+ <&gpio3 29 GPIO_ACTIVE_LOW>,
+ <&gpio3 25 GPIO_ACTIVE_LOW>;
status = "okay";
/* default boot source: workaround #1 for errata ERR006282 */
@@ -459,6 +460,8 @@ MX6QDL_PAD_EIM_D22__ECSPI4_MISO 0x100b1
MX6QDL_PAD_EIM_D24__GPIO3_IO24 0x1b0b0
/* SPI_IMX_CS0# - connected to SMARC SPI0_CS0# */
MX6QDL_PAD_EIM_D29__GPIO3_IO29 0x1b0b0
+ /* SPI4_CS3# - connected to SMARC SPI0_CS1# */
+ MX6QDL_PAD_EIM_D25__GPIO3_IO25 0x1b0b0
>;
};
--
2.39.2
next prev parent reply other threads:[~2024-06-17 9:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 9:13 [PATCH v3 00/13] ARM: dts: kontron-samx6i: various fixes Michael Walle
2024-06-17 9:13 ` [PATCH v3 01/13] ARM: dts: imx6qdl-kontron-samx6i: fix phy-mode Michael Walle
2024-06-17 9:13 ` [PATCH v3 02/13] ARM: dts: imx6qdl-kontron-samx6i: fix PHY reset Michael Walle
2024-06-17 9:13 ` [PATCH v3 03/13] ARM: dts: imx6qdl-kontron-samx6i: fix board reset Michael Walle
2024-06-17 9:13 ` [PATCH v3 04/13] ARM: dts: imx6qdl-kontron-samx6i: cleanup the PMIC node Michael Walle
2024-06-17 9:13 ` Michael Walle [this message]
2024-06-17 9:13 ` [PATCH v3 06/13] ARM: dts: imx6qdl-kontron-samx6i: fix product name Michael Walle
2024-06-17 9:13 ` [PATCH v3 07/13] ARM: dts: imx6qdl-kontron-samx6i: always enable eMMC Michael Walle
2024-06-17 9:13 ` [PATCH v3 08/13] ARM: dts: imx6qdl-kontron-samx6i: add SDIO_PWR_EN support Michael Walle
2024-06-17 9:13 ` [PATCH v3 09/13] ARM: dts: imx6qdl-kontron-samx6i: fix node names Michael Walle
2024-06-17 9:13 ` [PATCH v3 10/13] ARM: dts: imx6qdl-kontron-samx6i: fix PCIe reset polarity Michael Walle
2024-06-17 9:13 ` [PATCH v3 11/13] ARM: dts: imx6qdl-kontron-samx6i: remove wake-up-gpio property Michael Walle
2024-06-17 9:13 ` [PATCH v3 12/13] dt-bindings: arm: fsl: document Kontron SMARC-sAMX6i boards Michael Walle
2024-06-17 9:13 ` [PATCH v3 13/13] ARM: dts: imx6qdl-kontron-samx6i: add actual device trees Michael Walle
2024-06-27 7:25 ` [PATCH v3 00/13] ARM: dts: kontron-samx6i: various fixes Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617091341.2375325-6-mwalle@kernel.org \
--to=mwalle@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=m.grzeschik@pengutronix.de \
--cc=plaes@plaes.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).