From: Conor Dooley <conor@kernel.org>
To: Yangyu Chen <cyy@cyyself.name>
Cc: linux-riscv@lists.infradead.org,
Conor Dooley <conor+dt@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Samuel Holland <samuel.holland@sifive.com>,
Anup Patel <anup.patel@wdc.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 4/9] dt-bindings: timer: Add SpacemiT K1 CLINT
Date: Tue, 18 Jun 2024 18:05:19 +0100 [thread overview]
Message-ID: <20240618-retriever-outlying-e7209ff51ad3@spud> (raw)
In-Reply-To: <tencent_895CC418D210ECC617BE44C17EED3BC72E07@qq.com>
[-- Attachment #1: Type: text/plain, Size: 895 bytes --]
On Tue, Jun 18, 2024 at 11:48:26PM +0800, Yangyu Chen wrote:
>
> > On Jun 18, 2024, at 23:40, Conor Dooley <conor@kernel.org> wrote:
> >
> > On Mon, Jun 17, 2024 at 01:20:49AM +0800, Yangyu Chen wrote:
> >> Add compatible string for SpacemiT K1 CLINT.
> >>
> >> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
> >
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> Actually, I'm not confident about this after carefully reviewing
> the file. The "riscv,clint0" is marked deprecated, and the description
> is For the QEMU virtual machine only.
Right, I forgot about that portion of it. Probably, if this is sifive
plic compatible, then fall back to the sifive clint. Same, I suppose,
goes for the plic etc. The alternative is not have a fallback, modify
the driver, and future spacemit things will fall back to the k1's
compatible. I don't mind which you go for.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-06-18 17:05 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-16 17:18 [PATCH v1 0/9] riscv: add initial support for SpacemiT K1 Yangyu Chen
2024-06-16 17:20 ` [PATCH v1 1/9] dt-bindings: vendor-prefixes: add spacemit Yangyu Chen
2024-06-18 15:46 ` Conor Dooley
2024-06-16 17:20 ` [PATCH v1 2/9] dt-bindings: riscv: Add SpacemiT X60 compatibles Yangyu Chen
2024-06-18 15:45 ` Conor Dooley
2024-06-16 17:20 ` [PATCH v1 3/9] dt-bindings: riscv: add SpacemiT K1 bindings Yangyu Chen
2024-06-16 18:42 ` Rob Herring (Arm)
2024-06-18 15:45 ` Conor Dooley
2024-06-16 17:20 ` [PATCH v1 4/9] dt-bindings: timer: Add SpacemiT K1 CLINT Yangyu Chen
2024-06-18 15:40 ` Conor Dooley
2024-06-18 15:48 ` Yangyu Chen
2024-06-18 17:05 ` Conor Dooley [this message]
2024-06-16 17:20 ` [PATCH v1 5/9] dt-bindings: interrupt-controller: Add SpacemiT K1 PLIC Yangyu Chen
2024-06-18 15:44 ` Conor Dooley
2024-06-16 17:20 ` [PATCH v1 6/9] riscv: add SpacemiT SOC family Kconfig support Yangyu Chen
2024-06-16 22:26 ` Yixun Lan
2024-06-17 2:12 ` Yangyu Chen
2024-06-16 23:06 ` Yixun Lan
2024-06-17 2:12 ` Yangyu Chen
2024-06-16 17:20 ` [PATCH v1 7/9] riscv: dts: add initial SpacemiT K1 SoC device tree Yangyu Chen
2024-06-16 22:53 ` Yixun Lan
2024-06-17 2:10 ` Yangyu Chen
2024-06-17 6:02 ` Yixun Lan
2024-06-17 7:31 ` Conor Dooley
2024-06-17 12:49 ` Jisheng Zhang
2024-06-17 13:29 ` Conor Dooley
2024-06-17 13:31 ` Jisheng Zhang
2024-06-17 17:01 ` Yangyu Chen
2024-06-16 17:20 ` [PATCH v1 8/9] riscv: dts: spacemit: add Banana Pi BPI-F3 board " Yangyu Chen
2024-06-16 22:31 ` Yixun Lan
2024-06-17 2:16 ` Yangyu Chen
2024-06-16 17:20 ` [PATCH v1 9/9] riscv: defconfig: enable SpacemiT SoC Yangyu Chen
2024-06-16 18:35 ` [PATCH v1 0/9] riscv: add initial support for SpacemiT K1 Conor Dooley
2024-06-16 22:48 ` Yixun Lan
2024-06-17 2:00 ` Yangyu Chen
2024-06-17 7:28 ` Conor Dooley
2024-06-17 8:15 ` Icenowy Zheng
2024-06-17 14:11 ` Jisheng Zhang
2024-06-17 15:32 ` Conor Dooley
2024-06-17 16:39 ` Yangyu Chen
2024-06-17 17:14 ` Conor Dooley
2024-06-17 17:42 ` Yangyu Chen
2024-06-18 6:58 ` Conor Dooley
2024-06-18 4:39 ` Jisheng Zhang
2024-06-18 4:34 ` Jisheng Zhang
2024-06-18 10:16 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618-retriever-outlying-e7209ff51ad3@spud \
--to=conor@kernel.org \
--cc=anup.patel@wdc.com \
--cc=conor+dt@kernel.org \
--cc=cyy@cyyself.name \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=samuel.holland@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).