public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Guillaume Stols <gstols@baylibre.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Beniamin Bia <beniamin.bia@analog.com>,
	Stefan Popa <stefan.popa@analog.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	jstephan@baylibre.com, dlechner@baylibre.com
Subject: Re: [PATCH 4/9] dt-bindings: iio: adc: adi,ad7606: add supply properties
Date: Tue, 18 Jun 2024 18:32:20 +0100	[thread overview]
Message-ID: <20240618-spearfish-swear-213166c7224f@spud> (raw)
In-Reply-To: <12e5c4b4-e51d-4e69-8c63-3f6aefb574d9@baylibre.com>

[-- Attachment #1: Type: text/plain, Size: 1817 bytes --]

On Tue, Jun 18, 2024 at 05:33:16PM +0200, Guillaume Stols wrote:
> 
> On 6/18/24 17:12, Conor Dooley wrote:
> > On Tue, Jun 18, 2024 at 02:02:36PM +0000, Guillaume Stols wrote:
> > > Add voltage supplies
> > Are these available on all devices?
> 
> Yes all chips from  AD7606 series (including AD7606B, AD7606C(-16,-18),
> AD7605-4, AD7606 (-4,-8,-6), AD7607, AD7608, AD7609), as well as AD7616
> have a VDrive pin, as well as a RefSelect + RefIn/RefOut pin that takes
> an input voltage in case RefSelect is high, or outputs the internal
> reference voltage if RefSelect is low.

Okay,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
provided that...

> 
> > 
> > > Signed-off-by: Guillaume Stols <gstols@baylibre.com>
> > > ---
> > >   Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 9 +++++++++
> > >   1 file changed, 9 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> > > index 80866940123c..e480c9a7c7ca 100644
> > > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> > > @@ -35,6 +35,15 @@ properties:
> > >     avcc-supply: true
> > > +  vdrive-supply:

The lack of a blank line here is an artifact of the reply

> > > +    description:
> > > +      Determines the voltage level at which the interface logic pins will
> > > +      operate.
> > > +
> > > +  refin-supply:
> > > +    description:
> > > +      The voltage supply for optional external reference voltage.
> > > +
> > >     interrupts:
> > >       description:
> > >         The BUSY pin falling edge indicates that the conversion is over, and thus
> > > 
> > > -- 
> > > 2.34.1
> > > 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2024-06-18 17:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18 14:02 [PATCH 0/9] iio: adc: ad7606: Improvements Guillaume Stols
2024-06-18 14:02 ` [PATCH 1/9] dt-bindings: iio: adc: adi,ad7606: add missing datasheet link Guillaume Stols
2024-06-27 20:30   ` Rob Herring (Arm)
2024-06-18 14:02 ` [PATCH 2/9] dt-bindings: iio: adc: adi,ad7606: comment and sort the compatible names Guillaume Stols
2024-06-27 20:32   ` Rob Herring (Arm)
2024-06-18 14:02 ` [PATCH 3/9] dt-bindings: iio: adc: adi,ad7606: improve descriptions Guillaume Stols
2024-06-23 15:28   ` Jonathan Cameron
2024-06-18 14:02 ` [PATCH 4/9] dt-bindings: iio: adc: adi,ad7606: add supply properties Guillaume Stols
2024-06-18 15:12   ` Conor Dooley
2024-06-18 15:33     ` Guillaume Stols
2024-06-18 17:32       ` Conor Dooley [this message]
2024-06-23 15:31         ` Jonathan Cameron
2024-06-18 14:02 ` [PATCH 5/9] dt-bindings: iio: adc: adi,ad7606: add conditions Guillaume Stols
2024-06-18 15:13   ` Conor Dooley
2024-06-18 15:53   ` Rob Herring (Arm)
2024-06-23 15:33   ` Jonathan Cameron
2024-06-18 14:02 ` [PATCH 6/9] dt-bindings: iio: adc: adi,ad7606: fix example Guillaume Stols
2024-06-18 15:10   ` Conor Dooley
2024-06-23 15:35     ` Jonathan Cameron
2024-06-18 14:02 ` [PATCH 7/9] iio: adc: ad7606: switch mutexes to scoped_guard Guillaume Stols
2024-06-19  3:15   ` kernel test robot
2024-06-23 15:41   ` Jonathan Cameron
2024-06-18 14:02 ` [PATCH 8/9] iio: adc: ad7606: fix oversampling gpio array Guillaume Stols
2024-06-23 15:45   ` Jonathan Cameron
2024-06-24 15:08     ` Guillaume Stols
2024-06-18 14:02 ` [PATCH 9/9] iio: adc: ad7606: fix standby gpio state to match the documentation Guillaume Stols
2024-06-23 15:49   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240618-spearfish-swear-213166c7224f@spud \
    --to=conor@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=beniamin.bia@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gstols@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=jstephan@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=stefan.popa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox