[PATCH v2 0/8] MIPS: Boston: Fix syscon devicetree binding and node

[PATCH v2 0/8] MIPS: Boston: Fix syscon devicetree binding and node

[Jiaxun Yang]

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
Changes in v2:
- Write a new binding for this device (Krzysztof)
- Sweep other warnings
- Link to v1: https://lore.kernel.org/r/20240513-boston-syscon-v1-0-93ff557d3548@flygoat.com

---
Jiaxun Yang (8):
      MIPS: dts: Boston: Add simple-mfd compatible for syscon
      MIPS: dts: Boston: Move syscon-reboot node under syscon
      MIPS: dts: Boston: Remove unused #interrupt-cells
      MIPS: dts: Boston: Add model property
      MIPS: dts: Boston: Rename uart node
      dt-bindings: mfd: Add img,boston-platform-regs
      du-bindings: mips: cpu: Add img,mips compatible
      dt-bindings: mips: img: Add devices binding

 .../devicetree/bindings/clock/img,boston-clock.txt | 31 ---------
 .../bindings/mfd/img,boston-platform-regs.yaml     | 74 ++++++++++++++++++++++
 Documentation/devicetree/bindings/mips/cpus.yaml   |  1 +
 .../devicetree/bindings/mips/img/devices.yaml      | 33 ++++++++++
 arch/mips/boot/dts/img/boston.dts                  | 23 ++++---
 5 files changed, 119 insertions(+), 43 deletions(-)
---
base-commit: 6ba6c795dc73c22ce2c86006f17c4aa802db2a60
change-id: 20240513-boston-syscon-8e315e94a894

Best regards,
-- 
Jiaxun Yang <jiaxun.yang@flygoat.com>

[PATCH v2 1/8] MIPS: dts: Boston: Add simple-mfd compatible for syscon

[Jiaxun Yang]

We certainly want subnodes of system-controller node to
be populated, add simple-mfd compatible to make that happen.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 arch/mips/boot/dts/img/boston.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/boot/dts/img/boston.dts b/arch/mips/boot/dts/img/boston.dts
index 72f7605d2e31..f7a2c46f1eb8 100644
--- a/arch/mips/boot/dts/img/boston.dts
+++ b/arch/mips/boot/dts/img/boston.dts
@@ -203,7 +203,7 @@ cpc@16200000 {
 	};
 
 	plat_regs: system-controller@17ffd000 {
-		compatible = "img,boston-platform-regs", "syscon";
+		compatible = "img,boston-platform-regs", "syscon", "simple-mfd";
 		reg = <0x17ffd000 0x1000>;
 
 		clk_boston: clock {

-- 
2.43.0

[PATCH v2 2/8] MIPS: dts: Boston: Move syscon-reboot node under syscon

[Jiaxun Yang]

To match actual hardware topology.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 arch/mips/boot/dts/img/boston.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/mips/boot/dts/img/boston.dts b/arch/mips/boot/dts/img/boston.dts
index f7a2c46f1eb8..7379be7d46e1 100644
--- a/arch/mips/boot/dts/img/boston.dts
+++ b/arch/mips/boot/dts/img/boston.dts
@@ -210,13 +210,13 @@ clk_boston: clock {
 			compatible = "img,boston-clock";
 			#clock-cells = <1>;
 		};
-	};
 
-	reboot: syscon-reboot {
-		compatible = "syscon-reboot";
-		regmap = <&plat_regs>;
-		offset = <0x10>;
-		mask = <0x10>;
+		reboot: syscon-reboot {
+			compatible = "syscon-reboot";
+			regmap = <&plat_regs>;
+			offset = <0x10>;
+			mask = <0x10>;
+		};
 	};
 
 	uart0: uart@17ffe000 {

-- 
2.43.0

[PATCH v2 3/8] MIPS: dts: Boston: Remove unused #interrupt-cells

[Jiaxun Yang]

There is no reason to have #interrupt-cells node for a
pci device.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 arch/mips/boot/dts/img/boston.dts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/mips/boot/dts/img/boston.dts b/arch/mips/boot/dts/img/boston.dts
index 7379be7d46e1..bee5bd0655cd 100644
--- a/arch/mips/boot/dts/img/boston.dts
+++ b/arch/mips/boot/dts/img/boston.dts
@@ -131,7 +131,6 @@ pci2_root@0,0 {
 
 			#address-cells = <3>;
 			#size-cells = <2>;
-			#interrupt-cells = <1>;
 
 			eg20t_bridge@1,0,0 {
 				compatible = "pci8086,8800";
@@ -139,7 +138,6 @@ eg20t_bridge@1,0,0 {
 
 				#address-cells = <3>;
 				#size-cells = <2>;
-				#interrupt-cells = <1>;
 
 				eg20t_phub@2,0,0 {
 					compatible = "pci8086,8801";

-- 
2.43.0

[PATCH v2 4/8] MIPS: dts: Boston: Add model property

[Jiaxun Yang]

Using string "IMG Boston" from bootrom.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 arch/mips/boot/dts/img/boston.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/boot/dts/img/boston.dts b/arch/mips/boot/dts/img/boston.dts
index bee5bd0655cd..85d4255cfbb5 100644
--- a/arch/mips/boot/dts/img/boston.dts
+++ b/arch/mips/boot/dts/img/boston.dts
@@ -10,6 +10,7 @@ / {
 	#address-cells = <1>;
 	#size-cells = <1>;
 	compatible = "img,boston";
+	model = "IMG Boston";
 
 	chosen {
 		stdout-path = "uart0:115200";

-- 
2.43.0

[PATCH v2 5/8] MIPS: dts: Boston: Rename uart node

[Jiaxun Yang]

Remove it as serial node.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 arch/mips/boot/dts/img/boston.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/mips/boot/dts/img/boston.dts b/arch/mips/boot/dts/img/boston.dts
index 85d4255cfbb5..f1a026fc20e1 100644
--- a/arch/mips/boot/dts/img/boston.dts
+++ b/arch/mips/boot/dts/img/boston.dts
@@ -13,11 +13,11 @@ / {
 	model = "IMG Boston";
 
 	chosen {
-		stdout-path = "uart0:115200";
+		stdout-path = "serial0:115200";
 	};
 
 	aliases {
-		uart0 = &uart0;
+		serial0 = &uart0;
 	};
 
 	cpus {
@@ -218,7 +218,7 @@ reboot: syscon-reboot {
 		};
 	};
 
-	uart0: uart@17ffe000 {
+	uart0: serial@17ffe000 {
 		compatible = "ns16550a";
 		reg = <0x17ffe000 0x1000>;
 		reg-shift = <2>;

-- 
2.43.0

[PATCH v2 6/8] dt-bindings: mfd: Add img,boston-platform-regs

[Jiaxun Yang]

This compatible has been used in arch/mips/boot/dts/img/boston.dts
for a while but never documented properly.

Write a new binding for this device.
This also covers old img,boston-clock binding so remove that binding.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 .../devicetree/bindings/clock/img,boston-clock.txt | 31 ---------
 .../bindings/mfd/img,boston-platform-regs.yaml     | 74 ++++++++++++++++++++++
 2 files changed, 74 insertions(+), 31 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/img,boston-clock.txt b/Documentation/devicetree/bindings/clock/img,boston-clock.txt
deleted file mode 100644
index 7bc5e9ffb624..000000000000
--- a/Documentation/devicetree/bindings/clock/img,boston-clock.txt
+++ /dev/null
@@ -1,31 +0,0 @@
-Binding for Imagination Technologies MIPS Boston clock sources.
-
-This binding uses the common clock binding[1].
-
-[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
-
-The device node must be a child node of the syscon node corresponding to the
-Boston system's platform registers.
-
-Required properties:
-- compatible : Should be "img,boston-clock".
-- #clock-cells : Should be set to 1.
-  Values available for clock consumers can be found in the header file:
-    <dt-bindings/clock/boston-clock.h>
-
-Example:
-
-	system-controller@17ffd000 {
-		compatible = "img,boston-platform-regs", "syscon";
-		reg = <0x17ffd000 0x1000>;
-
-		clk_boston: clock {
-			compatible = "img,boston-clock";
-			#clock-cells = <1>;
-		};
-	};
-
-	uart0: uart@17ffe000 {
-		/* ... */
-		clocks = <&clk_boston BOSTON_CLK_SYS>;
-	};
diff --git a/Documentation/devicetree/bindings/mfd/img,boston-platform-regs.yaml b/Documentation/devicetree/bindings/mfd/img,boston-platform-regs.yaml
new file mode 100644
index 000000000000..bf94de38a89f
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/img,boston-platform-regs.yaml
@@ -0,0 +1,74 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/img,boston-platform-regs.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Imagination Technologies Boston Platform Registers
+
+maintainers:
+  - Jiaxun Yang <jiaxun.yang@flygoat.com>
+
+properties:
+  compatible:
+    items:
+      - const: img,boston-platform-regs
+      - const: syscon
+      - const: simple-mfd
+
+  reg:
+    maxItems: 1
+
+  clock:
+    type: object
+
+    description: Boston Clock Controller Device Node
+      The clock consumer should specify the desired clock by having the clock
+      ID in its "clocks" phandle cell.
+      See include/dt-bindings/clock/boston-clock.h for the full list of boston
+      clock IDs.
+
+    properties:
+      "#clock-cells":
+        const: 1
+
+      compatible:
+        const: img,boston-clock
+
+    required:
+      - "#clock-cells"
+      - compatible
+
+    additionalProperties: false
+
+  syscon-reboot:
+    $ref: /schemas/power/reset/syscon-reboot.yaml#
+
+required:
+  - compatible
+  - reg
+  - clock
+  - syscon-reboot
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/boston-clock.h>
+
+    plat_regs: system-controller@17ffd000 {
+      compatible = "img,boston-platform-regs", "syscon", "simple-mfd";
+      reg = <0x17ffd000 0x1000>;
+
+      clk_boston: clock {
+        compatible = "img,boston-clock";
+        #clock-cells = <1>;
+      };
+
+      reboot: syscon-reboot {
+        compatible = "syscon-reboot";
+        regmap = <&plat_regs>;
+        offset = <0x10>;
+        mask = <0x10>;
+      };
+    };

-- 
2.43.0

Re: [PATCH v2 6/8] dt-bindings: mfd: Add img,boston-platform-regs

[Rob Herring]

On Wed, Jun 12, 2024 at 12:56:25PM +0100, Jiaxun Yang wrote:
> This compatible has been used in arch/mips/boot/dts/img/boston.dts
> for a while but never documented properly.
> 
> Write a new binding for this device.
> This also covers old img,boston-clock binding so remove that binding.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>  .../devicetree/bindings/clock/img,boston-clock.txt | 31 ---------
>  .../bindings/mfd/img,boston-platform-regs.yaml     | 74 ++++++++++++++++++++++
>  2 files changed, 74 insertions(+), 31 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/img,boston-clock.txt b/Documentation/devicetree/bindings/clock/img,boston-clock.txt
> deleted file mode 100644
> index 7bc5e9ffb624..000000000000
> --- a/Documentation/devicetree/bindings/clock/img,boston-clock.txt
> +++ /dev/null
> @@ -1,31 +0,0 @@
> -Binding for Imagination Technologies MIPS Boston clock sources.
> -
> -This binding uses the common clock binding[1].
> -
> -[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
> -
> -The device node must be a child node of the syscon node corresponding to the
> -Boston system's platform registers.
> -
> -Required properties:
> -- compatible : Should be "img,boston-clock".
> -- #clock-cells : Should be set to 1.
> -  Values available for clock consumers can be found in the header file:
> -    <dt-bindings/clock/boston-clock.h>
> -
> -Example:
> -
> -	system-controller@17ffd000 {
> -		compatible = "img,boston-platform-regs", "syscon";
> -		reg = <0x17ffd000 0x1000>;
> -
> -		clk_boston: clock {
> -			compatible = "img,boston-clock";
> -			#clock-cells = <1>;
> -		};
> -	};
> -
> -	uart0: uart@17ffe000 {
> -		/* ... */
> -		clocks = <&clk_boston BOSTON_CLK_SYS>;
> -	};
> diff --git a/Documentation/devicetree/bindings/mfd/img,boston-platform-regs.yaml b/Documentation/devicetree/bindings/mfd/img,boston-platform-regs.yaml
> new file mode 100644
> index 000000000000..bf94de38a89f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/img,boston-platform-regs.yaml
> @@ -0,0 +1,74 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/img,boston-platform-regs.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Imagination Technologies Boston Platform Registers
> +
> +maintainers:
> +  - Jiaxun Yang <jiaxun.yang@flygoat.com>
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: img,boston-platform-regs
> +      - const: syscon
> +      - const: simple-mfd

Why did you add 'simple-mfd'? That's not what is in use.

> +
> +  reg:
> +    maxItems: 1
> +
> +  clock:

Really should be 'clock-controller', but if you don't plan to update the 
DTS, then it is fine as-is.

> +    type: object
> +
> +    description: Boston Clock Controller Device Node
> +      The clock consumer should specify the desired clock by having the clock
> +      ID in its "clocks" phandle cell.
> +      See include/dt-bindings/clock/boston-clock.h for the full list of boston
> +      clock IDs.
> +
> +    properties:
> +      "#clock-cells":
> +        const: 1
> +
> +      compatible:
> +        const: img,boston-clock
> +
> +    required:
> +      - "#clock-cells"
> +      - compatible
> +
> +    additionalProperties: false
> +
> +  syscon-reboot:

Just 'reboot'

> +    $ref: /schemas/power/reset/syscon-reboot.yaml#
> +
> +required:
> +  - compatible
> +  - reg
> +  - clock
> +  - syscon-reboot
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/boston-clock.h>
> +
> +    plat_regs: system-controller@17ffd000 {
> +      compatible = "img,boston-platform-regs", "syscon", "simple-mfd";
> +      reg = <0x17ffd000 0x1000>;
> +
> +      clk_boston: clock {
> +        compatible = "img,boston-clock";
> +        #clock-cells = <1>;
> +      };
> +
> +      reboot: syscon-reboot {
> +        compatible = "syscon-reboot";
> +        regmap = <&plat_regs>;
> +        offset = <0x10>;
> +        mask = <0x10>;
> +      };
> +    };
> 
> -- 
> 2.43.0
> 

Re: [PATCH v2 6/8] dt-bindings: mfd: Add img,boston-platform-regs

[Jiaxun Yang]

在2024年6月13日六月 下午8:04，Rob Herring写道：
> On Wed, Jun 12, 2024 at 12:56:25PM +0100, Jiaxun Yang wrote:
>> This compatible has been used in arch/mips/boot/dts/img/boston.dts
>> for a while but never documented properly.
>> 
>> Write a new binding for this device.
>> This also covers old img,boston-clock binding so remove that binding.
>> 
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> ---
>>  .../devicetree/bindings/clock/img,boston-clock.txt | 31 ---------
>>  .../bindings/mfd/img,boston-platform-regs.yaml     | 74 ++++++++++++++++++++++
>>  2 files changed, 74 insertions(+), 31 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/clock/img,boston-clock.txt b/Documentation/devicetree/bindings/clock/img,boston-clock.txt
>> deleted file mode 100644
>> index 7bc5e9ffb624..000000000000
>> --- a/Documentation/devicetree/bindings/clock/img,boston-clock.txt
>> +++ /dev/null
>> @@ -1,31 +0,0 @@
>> -Binding for Imagination Technologies MIPS Boston clock sources.
>> -
>> -This binding uses the common clock binding[1].
>> -
>> -[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
>> -
>> -The device node must be a child node of the syscon node corresponding to the
>> -Boston system's platform registers.
>> -
>> -Required properties:
>> -- compatible : Should be "img,boston-clock".
>> -- #clock-cells : Should be set to 1.
>> -  Values available for clock consumers can be found in the header file:
>> -    <dt-bindings/clock/boston-clock.h>
>> -
>> -Example:
>> -
>> -	system-controller@17ffd000 {
>> -		compatible = "img,boston-platform-regs", "syscon";
>> -		reg = <0x17ffd000 0x1000>;
>> -
>> -		clk_boston: clock {
>> -			compatible = "img,boston-clock";
>> -			#clock-cells = <1>;
>> -		};
>> -	};
>> -
>> -	uart0: uart@17ffe000 {
>> -		/* ... */
>> -		clocks = <&clk_boston BOSTON_CLK_SYS>;
>> -	};
>> diff --git a/Documentation/devicetree/bindings/mfd/img,boston-platform-regs.yaml b/Documentation/devicetree/bindings/mfd/img,boston-platform-regs.yaml
>> new file mode 100644
>> index 000000000000..bf94de38a89f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/img,boston-platform-regs.yaml
>> @@ -0,0 +1,74 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mfd/img,boston-platform-regs.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Imagination Technologies Boston Platform Registers
>> +
>> +maintainers:
>> +  - Jiaxun Yang <jiaxun.yang@flygoat.com>
>> +
>> +properties:
>> +  compatible:
>> +    items:
>> +      - const: img,boston-platform-regs
>> +      - const: syscon
>> +      - const: simple-mfd
>
> Why did you add 'simple-mfd'? That's not what is in use.
>

U-Boot needs this to probe sub-nodes such as reboot and clock :-(

I had updated dts in an earlier patch of this series.

Thanks
>>

-- 
- Jiaxun

[PATCH v2 7/8] du-bindings: mips: cpu: Add img,mips compatible

[Jiaxun Yang]

This compatible is used by boston.dts.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
note: This is a wildcard compatible for all MIPS CPUs,
      I think we should use something like "riscv" for riscv.
      Should I add something like "mips" or "mips,cpu"?
---
 Documentation/devicetree/bindings/mips/cpus.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mips/cpus.yaml b/Documentation/devicetree/bindings/mips/cpus.yaml
index a85137add668..7f9513f2a540 100644
--- a/Documentation/devicetree/bindings/mips/cpus.yaml
+++ b/Documentation/devicetree/bindings/mips/cpus.yaml
@@ -24,6 +24,7 @@ properties:
       - brcm,bmips5000
       - brcm,bmips5200
       - img,i6500
+      - img,mips
       - ingenic,xburst-fpu1.0-mxu1.1
       - ingenic,xburst-fpu2.0-mxu2.0
       - ingenic,xburst-mxu1.0

-- 
2.43.0

Re: [PATCH v2 7/8] du-bindings: mips: cpu: Add img,mips compatible

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]

On Wed, Jun 12, 2024 at 12:56:26PM +0100, Jiaxun Yang wrote:
> This compatible is used by boston.dts.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> note: This is a wildcard compatible for all MIPS CPUs,
>       I think we should use something like "riscv" for riscv.

riscv systems, other than simulators etc are not meant to use the
"riscv" compatible. All of the real CPUs use "vendor,cpu", "riscv".
I'd suggest you add specific compatibles for your CPUs.

Thanks
Conor.

>       Should I add something like "mips" or "mips,cpu"?
> ---
>  Documentation/devicetree/bindings/mips/cpus.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mips/cpus.yaml b/Documentation/devicetree/bindings/mips/cpus.yaml
> index a85137add668..7f9513f2a540 100644
> --- a/Documentation/devicetree/bindings/mips/cpus.yaml
> +++ b/Documentation/devicetree/bindings/mips/cpus.yaml
> @@ -24,6 +24,7 @@ properties:
>        - brcm,bmips5000
>        - brcm,bmips5200
>        - img,i6500
> +      - img,mips
>        - ingenic,xburst-fpu1.0-mxu1.1
>        - ingenic,xburst-fpu2.0-mxu2.0
>        - ingenic,xburst-mxu1.0
> 
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 7/8] du-bindings: mips: cpu: Add img,mips compatible

[Jiaxun Yang]

在2024年6月12日六月 下午5:39，Conor Dooley写道：
> On Wed, Jun 12, 2024 at 12:56:26PM +0100, Jiaxun Yang wrote:
>> This compatible is used by boston.dts.
>> 
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> ---
>> note: This is a wildcard compatible for all MIPS CPUs,
>>       I think we should use something like "riscv" for riscv.
>
> riscv systems, other than simulators etc are not meant to use the
> "riscv" compatible. All of the real CPUs use "vendor,cpu", "riscv".
> I'd suggest you add specific compatibles for your CPUs.

Boston can be combined with many different CPUs, thus we need to have
such compatibles.

Thanks
>
> Thanks
> Conor.
>
[...]

-- 
- Jiaxun

Re: [PATCH v2 7/8] du-bindings: mips: cpu: Add img,mips compatible

[Rob Herring]

On Wed, Jun 12, 2024 at 05:59:24PM +0100, Jiaxun Yang wrote:
> 
> 
> 在2024年6月12日六月 下午5:39，Conor Dooley写道：
> > On Wed, Jun 12, 2024 at 12:56:26PM +0100, Jiaxun Yang wrote:
> >> This compatible is used by boston.dts.
> >> 
> >> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> >> ---
> >> note: This is a wildcard compatible for all MIPS CPUs,
> >>       I think we should use something like "riscv" for riscv.
> >
> > riscv systems, other than simulators etc are not meant to use the
> > "riscv" compatible. All of the real CPUs use "vendor,cpu", "riscv".
> > I'd suggest you add specific compatibles for your CPUs.
> 
> Boston can be combined with many different CPUs, thus we need to have
> such compatibles.

Then you'll need different DTs. Different h/w, different DT.

No way we're taking a generic compatible like this.

Rob

Re: [PATCH v2 7/8] du-bindings: mips: cpu: Add img,mips compatible

[Jiaxun Yang]

在2024年6月13日六月 下午7:59，Rob Herring写道：
> On Wed, Jun 12, 2024 at 05:59:24PM +0100, Jiaxun Yang wrote:
>> 
>> 
>> 在2024年6月12日六月 下午5:39，Conor Dooley写道：
>> > On Wed, Jun 12, 2024 at 12:56:26PM +0100, Jiaxun Yang wrote:
>> >> This compatible is used by boston.dts.
>> >> 
>> >> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> >> ---
>> >> note: This is a wildcard compatible for all MIPS CPUs,
>> >>       I think we should use something like "riscv" for riscv.
>> >
>> > riscv systems, other than simulators etc are not meant to use the
>> > "riscv" compatible. All of the real CPUs use "vendor,cpu", "riscv".
>> > I'd suggest you add specific compatibles for your CPUs.
>> 
>> Boston can be combined with many different CPUs, thus we need to have
>> such compatibles.
>
> Then you'll need different DTs. Different h/w, different DT.

The board have 9 CPU types in total, with hundreds of different possible
CPU topologies. Maintaining separate DT for them seems impossible in kernel.

We can potentially patch this in bootloader, but for existing firmware it's
being doing like this for years. I can see for RISC-V QEMU generated DTB is
using a single "riscv" compatible and I do think it's a similar problem.

I think it's better to document it and warn people only to use it in limited
circumstances, instead of keeping such usage in grey area.

Thanks

>
> No way we're taking a generic compatible like this.
>
> Rob

-- 
- Jiaxun

Re: [PATCH v2 7/8] du-bindings: mips: cpu: Add img,mips compatible

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2062 bytes --]

On Thu, Jun 13, 2024 at 08:40:18PM +0100, Jiaxun Yang wrote:
> 
> 
> 在2024年6月13日六月 下午7:59，Rob Herring写道：
> > On Wed, Jun 12, 2024 at 05:59:24PM +0100, Jiaxun Yang wrote:
> >> 
> >> 
> >> 在2024年6月12日六月 下午5:39，Conor Dooley写道：
> >> > On Wed, Jun 12, 2024 at 12:56:26PM +0100, Jiaxun Yang wrote:
> >> >> This compatible is used by boston.dts.
> >> >> 
> >> >> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> >> >> ---
> >> >> note: This is a wildcard compatible for all MIPS CPUs,
> >> >>       I think we should use something like "riscv" for riscv.
> >> >
> >> > riscv systems, other than simulators etc are not meant to use the
> >> > "riscv" compatible. All of the real CPUs use "vendor,cpu", "riscv".
> >> > I'd suggest you add specific compatibles for your CPUs.
> >> 
> >> Boston can be combined with many different CPUs, thus we need to have
> >> such compatibles.
> >
> > Then you'll need different DTs. Different h/w, different DT.
> 
> The board have 9 CPU types in total, with hundreds of different possible
> CPU topologies. Maintaining separate DT for them seems impossible in kernel.

But you could definitely add 9 different compatibles for each of these
different CPUs.

> We can potentially patch this in bootloader, but for existing firmware it's
> being doing like this for years. I can see for RISC-V QEMU generated DTB is
> using a single "riscv" compatible and I do think it's a similar problem.

That "riscv" compatible is only supposed to be used for
simulators/software models. Real CPUs are not meant to use it. AFAICT,
your boston is a real platform, even if the CPUs are implemented on an
FPGA they should still have one. If you take the OpenC906 RISC-V CPU and
put it on an FPGA, you're still meant to put "thead,c906" in your DT.

> I think it's better to document it and warn people only to use it in limited
> circumstances, instead of keeping such usage in grey area.
> 
> >
> > No way we're taking a generic compatible like this.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 7/8] du-bindings: mips: cpu: Add img,mips compatible

[Jiaxun Yang]

在2024年6月15日六月 下午1:28，Conor Dooley写道：
> On Thu, Jun 13, 2024 at 08:40:18PM +0100, Jiaxun Yang wrote:
>> 
>> 
>> 在2024年6月13日六月 下午7:59，Rob Herring写道：
>> > On Wed, Jun 12, 2024 at 05:59:24PM +0100, Jiaxun Yang wrote:
>> >> 
>> >> 
>> >> 在2024年6月12日六月 下午5:39，Conor Dooley写道：
>> >> > On Wed, Jun 12, 2024 at 12:56:26PM +0100, Jiaxun Yang wrote:
>> >> >> This compatible is used by boston.dts.
>> >> >> 
>> >> >> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> >> >> ---
>> >> >> note: This is a wildcard compatible for all MIPS CPUs,
>> >> >>       I think we should use something like "riscv" for riscv.
>> >> >
>> >> > riscv systems, other than simulators etc are not meant to use the
>> >> > "riscv" compatible. All of the real CPUs use "vendor,cpu", "riscv".
>> >> > I'd suggest you add specific compatibles for your CPUs.
>> >> 
>> >> Boston can be combined with many different CPUs, thus we need to have
>> >> such compatibles.
>> >
>> > Then you'll need different DTs. Different h/w, different DT.
>> 
>> The board have 9 CPU types in total, with hundreds of different possible
>> CPU topologies. Maintaining separate DT for them seems impossible in kernel.
>
> But you could definitely add 9 different compatibles for each of these
> different CPUs.

They are already in current bindings, but we need a default one to fill
in kernel dts.

>
>> We can potentially patch this in bootloader, but for existing firmware it's
>> being doing like this for years. I can see for RISC-V QEMU generated DTB is
>> using a single "riscv" compatible and I do think it's a similar problem.
>
> That "riscv" compatible is only supposed to be used for
> simulators/software models. Real CPUs are not meant to use it. AFAICT,
> your boston is a real platform, even if the CPUs are implemented on an
> FPGA they should still have one. If you take the OpenC906 RISC-V CPU and
> put it on an FPGA, you're still meant to put "thead,c906" in your DT.
>

And sadly, boston is also the platform used by MIPS internal emulators :-(

Thanks
- Jiaxun
>
> 附件:
> * signature.asc

-- 
- Jiaxun

Re: [PATCH v2 7/8] du-bindings: mips: cpu: Add img,mips compatible

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2673 bytes --]

On Sat, Jun 15, 2024 at 08:16:11PM +0100, Jiaxun Yang wrote:
> 
> 
> 在2024年6月15日六月 下午1:28，Conor Dooley写道：
> > On Thu, Jun 13, 2024 at 08:40:18PM +0100, Jiaxun Yang wrote:
> >> 
> >> 
> >> 在2024年6月13日六月 下午7:59，Rob Herring写道：
> >> > On Wed, Jun 12, 2024 at 05:59:24PM +0100, Jiaxun Yang wrote:
> >> >> 
> >> >> 
> >> >> 在2024年6月12日六月 下午5:39，Conor Dooley写道：
> >> >> > On Wed, Jun 12, 2024 at 12:56:26PM +0100, Jiaxun Yang wrote:
> >> >> >> This compatible is used by boston.dts.
> >> >> >> 
> >> >> >> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> >> >> >> ---
> >> >> >> note: This is a wildcard compatible for all MIPS CPUs,
> >> >> >>       I think we should use something like "riscv" for riscv.
> >> >> >
> >> >> > riscv systems, other than simulators etc are not meant to use the
> >> >> > "riscv" compatible. All of the real CPUs use "vendor,cpu", "riscv".
> >> >> > I'd suggest you add specific compatibles for your CPUs.
> >> >> 
> >> >> Boston can be combined with many different CPUs, thus we need to have
> >> >> such compatibles.
> >> >
> >> > Then you'll need different DTs. Different h/w, different DT.
> >> 
> >> The board have 9 CPU types in total, with hundreds of different possible
> >> CPU topologies. Maintaining separate DT for them seems impossible in kernel.
> >
> > But you could definitely add 9 different compatibles for each of these
> > different CPUs.
> 
> They are already in current bindings, but we need a default one to fill
> in kernel dts.

IMO, no you don't. I don't think some "default" dts does anything other
than promote not correctly documenting what the CPU actually is and just
using the default. I'd reject the "riscv" compatibles in isolation if
they arrived now & demand a "qemu,riscv" or w/e compatible.

> 
> >
> >> We can potentially patch this in bootloader, but for existing firmware it's
> >> being doing like this for years. I can see for RISC-V QEMU generated DTB is
> >> using a single "riscv" compatible and I do think it's a similar problem.
> >
> > That "riscv" compatible is only supposed to be used for
> > simulators/software models. Real CPUs are not meant to use it. AFAICT,
> > your boston is a real platform, even if the CPUs are implemented on an
> > FPGA they should still have one. If you take the OpenC906 RISC-V CPU and
> > put it on an FPGA, you're still meant to put "thead,c906" in your DT.
> >
> 
> And sadly, boston is also the platform used by MIPS internal emulators :-(
> 
> Thanks
> - Jiaxun
> >
> > 附件:
> > * signature.asc
> 
> -- 
> - Jiaxun

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH v2 8/8] dt-bindings: mips: img: Add devices binding

[Jiaxun Yang]

Add devices binding for various Imagination Technologies
MIPS based Platforms.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 .../devicetree/bindings/mips/img/devices.yaml      | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/Documentation/devicetree/bindings/mips/img/devices.yaml b/Documentation/devicetree/bindings/mips/img/devices.yaml
new file mode 100644
index 000000000000..460ca96577ad
--- /dev/null
+++ b/Documentation/devicetree/bindings/mips/img/devices.yaml
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mips/img/devices.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Imagination Technologies MIPS based Platforms
+
+maintainers:
+  - Jiaxun Yang <jiaxun.yang@flygoat.com>
+
+properties:
+  $nodename:
+    const: '/'
+  compatible:
+    oneOf:
+
+      - description: IMG Boston
+        const: img,boston
+
+      - description: IMG Marduk (Creator Ci40)
+        items:
+          - const: img,pistachio-marduk
+          - const: img,pistachio
+
+      - description: Imagination University Program MIPSfpga
+        items:
+          - const: img,xilfpga
+          - const: digilent,nexys4ddr
+
+additionalProperties: true
+
+...

-- 
2.43.0

Re: [PATCH v2 8/8] dt-bindings: mips: img: Add devices binding

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1719 bytes --]

On Wed, Jun 12, 2024 at 12:56:27PM +0100, Jiaxun Yang wrote:
> Add devices binding for various Imagination Technologies
> MIPS based Platforms.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>  .../devicetree/bindings/mips/img/devices.yaml      | 33 ++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mips/img/devices.yaml b/Documentation/devicetree/bindings/mips/img/devices.yaml
> new file mode 100644
> index 000000000000..460ca96577ad
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mips/img/devices.yaml
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mips/img/devices.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Imagination Technologies MIPS based Platforms
> +
> +maintainers:
> +  - Jiaxun Yang <jiaxun.yang@flygoat.com>
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +
> +      - description: IMG Boston
> +        const: img,boston
> +
> +      - description: IMG Marduk (Creator Ci40)
> +        items:
> +          - const: img,pistachio-marduk
> +          - const: img,pistachio
> +
> +      - description: Imagination University Program MIPSfpga
> +        items:
> +          - const: img,xilfpga
> +          - const: digilent,nexys4ddr

Usually the order used here is something like:
compatible = "vendor,soc-board", "vendor,soc"
The pistachio one seems to follow that, but AFAICT "boston" is a board
and the order in this one is something like:
compatible = "vendor,soc", "vendor,generic-fpga-board"

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 8/8] dt-bindings: mips: img: Add devices binding

[Jiaxun Yang]

在2024年6月12日六月 下午5:43，Conor Dooley写道：
[...]
> Usually the order used here is something like:
> compatible = "vendor,soc-board", "vendor,soc"
> The pistachio one seems to follow that, but AFAICT "boston" is a board
> and the order in this one is something like:
> compatible = "vendor,soc", "vendor,generic-fpga-board"

Boston is an FPGA & Emulation platform, so I don't have a good answer
for what should I fill as SoC.

Thanks
>
> 附件:
> * signature.asc

-- 
- Jiaxun

Re: [PATCH v2 8/8] dt-bindings: mips: img: Add devices binding

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

On Wed, Jun 12, 2024 at 05:57:55PM +0100, Jiaxun Yang wrote:
> 
> 
> 在2024年6月12日六月 下午5:43，Conor Dooley写道：
> [...]
> > Usually the order used here is something like:
> > compatible = "vendor,soc-board", "vendor,soc"
> > The pistachio one seems to follow that, but AFAICT "boston" is a board
> > and the order in this one is something like:
> > compatible = "vendor,soc", "vendor,generic-fpga-board"
> 
> Boston is an FPGA & Emulation platform, so I don't have a good answer
> for what should I fill as SoC.

Ah right. Probably worth adding a little more information then as to
what the platforms are in the commit message in that case.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 8/8] dt-bindings: mips: img: Add devices binding

[Rob Herring]

On Wed, Jun 12, 2024 at 12:56:27PM +0100, Jiaxun Yang wrote:
> Add devices binding for various Imagination Technologies
> MIPS based Platforms.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>  .../devicetree/bindings/mips/img/devices.yaml      | 33 ++++++++++++++++++++++
>  1 file changed, 33 insertions(+)

Please drop the old bindings or at least the portion covered by 
this. That's 
Documentation/devicetree/bindings/mips/img/pistachio-marduk.txt, 
pistachio.txt, and xilfpga.txt. 

Some of the description can go in here. CPU nodes are documented 
elsewhere by schemas already and can be dropped. The boot protocol isn't 
really DT bindings, so that belongs elsewhere if you want to keep it. 
Documentation/arch/mips/ perhaps?

Rob