devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Caleb Connolly <caleb.connolly@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>,
	 Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	 Alexey Klimov <alexey.klimov@linaro.org>,
	linux-arm-msm@vger.kernel.org,  devicetree@vger.kernel.org,
	Caleb Connolly <caleb.connolly@linaro.org>
Subject: [PATCH 1/2] arm64: dts: qcom: sm6115: add iommu for sdhc_1
Date: Wed, 19 Jun 2024 22:33:38 +0200	[thread overview]
Message-ID: <20240619-rb2-fixes-v1-1-1d2b1d711969@linaro.org> (raw)
In-Reply-To: <20240619-rb2-fixes-v1-0-1d2b1d711969@linaro.org>

The first SDHC can do DMA like most other peripherals, add the missing
iommus entry which is required to set this up.

This may have been working on Linux before since the bootloader
configures it and it may not be full torn down. But other software like
U-Boot needs this to initialize the eMMC properly.

Fixes: 97e563bf5ba1 ("arm64: dts: qcom: sm6115: Add basic soc dtsi")
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm6115.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
index aca0a87092e4..9ed062150aaf 100644
--- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
@@ -1089,8 +1089,9 @@ sdhc_1: mmc@4744000 {
 			clock-names = "iface", "core", "xo", "ice";
 
 			power-domains = <&rpmpd SM6115_VDDCX>;
 			operating-points-v2 = <&sdhc1_opp_table>;
+			iommus = <&apps_smmu 0x00c0 0x0>;
 			interconnects = <&system_noc MASTER_SDCC_1 RPM_ALWAYS_TAG
 					 &bimc SLAVE_EBI_CH0 RPM_ALWAYS_TAG>,
 					<&bimc MASTER_AMPSS_M0 RPM_ALWAYS_TAG
 					 &config_noc SLAVE_SDCC_1 RPM_ALWAYS_TAG>;

-- 
2.45.0


  reply	other threads:[~2024-06-19 20:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-19 20:33 [PATCH 0/2] qcom: dts: qrb4210-rb2 usb/emmc fixes Caleb Connolly
2024-06-19 20:33 ` Caleb Connolly [this message]
2024-06-20 13:11   ` [PATCH 1/2] arm64: dts: qcom: sm6115: add iommu for sdhc_1 Dmitry Baryshkov
2024-06-19 20:33 ` [PATCH 2/2] arm64: dts: qcom: qrb4210-rb2: set role-switch-default-mode Caleb Connolly
2024-06-20 13:15   ` Dmitry Baryshkov
2024-06-20 13:30     ` Caleb Connolly
2024-06-20 15:07       ` Dmitry Baryshkov
2024-06-20 16:49         ` Caleb Connolly
2024-06-20 18:22           ` Dmitry Baryshkov
2024-06-21  5:32           ` Bjorn Andersson
2024-06-21 15:26             ` Dmitry Baryshkov
2024-06-21  6:11 ` (subset) [PATCH 0/2] qcom: dts: qrb4210-rb2 usb/emmc fixes Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240619-rb2-fixes-v1-1-1d2b1d711969@linaro.org \
    --to=caleb.connolly@linaro.org \
    --cc=alexey.klimov@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).