[PATCH 1/3] arm64: dts: mediatek: mt8188: Fix VPPSYS0/1 node name/compatibles

[PATCH 1/3] arm64: dts: mediatek: mt8188: Fix VPPSYS0/1 node name/compatibles

[AngeloGioacchino Del Regno]

Like VDOSYS0/1, the VPPSYS0 and VPPSYS1 are syscon nodes, as
described by the mediatek,mmsys binding: fix the node name to
be syscon@address and add "syscon" to the list of compatible
strings for both VPPSYS0 and VPPSYS1.

Fixes: 9461e0caac9e ("arm64: dts: Add MediaTek MT8188 dts and evaluation board and Makefile")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 arch/arm64/boot/dts/mediatek/mt8188.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
index 3b02170562ae..77c4f2d104cd 100644
--- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
@@ -1331,8 +1331,8 @@ mfgcfg: clock-controller@13fbf000 {
 			#clock-cells = <1>;
 		};
 
-		vppsys0: clock-controller@14000000 {
-			compatible = "mediatek,mt8188-vppsys0";
+		vppsys0: syscon@14000000 {
+			compatible = "mediatek,mt8188-vppsys0", "syscon";
 			reg = <0 0x14000000 0 0x1000>;
 			#clock-cells = <1>;
 		};
@@ -1349,8 +1349,8 @@ wpesys_vpp0: clock-controller@14e02000 {
 			#clock-cells = <1>;
 		};
 
-		vppsys1: clock-controller@14f00000 {
-			compatible = "mediatek,mt8188-vppsys1";
+		vppsys1: syscon@14f00000 {
+			compatible = "mediatek,mt8188-vppsys1", "syscon";
 			reg = <0 0x14f00000 0 0x1000>;
 			#clock-cells = <1>;
 		};
-- 
2.45.2

[PATCH 2/3] dt-bindings: clock: mediatek: Document reset cells for MT8188 sys

[AngeloGioacchino Del Regno]

The MT8188 sys clocks embed a reset controller: add #reset-cells
to the binding to allow using resets.

Fixes: 1086a5310f9c ("dt-bindings: clock: mediatek: Add new MT8188 clock")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 .../devicetree/bindings/clock/mediatek,mt8188-sys-clock.yaml   | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8188-sys-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8188-sys-clock.yaml
index 4cf8d3af9803..db13d51a4903 100644
--- a/Documentation/devicetree/bindings/clock/mediatek,mt8188-sys-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/mediatek,mt8188-sys-clock.yaml
@@ -39,6 +39,9 @@ properties:
   '#clock-cells':
     const: 1
 
+  '#reset-cells':
+    const: 1
+
 required:
   - compatible
   - reg
-- 
2.45.2

[PATCH 3/3] dt-bindings: mailbox: mediatek: Avoid clock-names on MT8188 GCE

[AngeloGioacchino Del Regno]

Add mediatek,mt8188-gce to the list of compatibles for which the
clock-names property is not required.

Fixes: f2b53c295620 ("dt-bindings: mailbox: mediatek,gce-mailbox: add mt8188 compatible name")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 .../devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml     | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
index cef9d7601398..55d4c34aa4b4 100644
--- a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
+++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
@@ -62,7 +62,9 @@ allOf:
         properties:
           compatible:
             contains:
-              const: mediatek,mt8195-gce
+              enum:
+                - mediatek,mt8188-gce
+                - mediatek,mt8195-gce
     then:
       required:
         - clock-names
-- 
2.45.2

Re: [PATCH 3/3] dt-bindings: mailbox: mediatek: Avoid clock-names on MT8188 GCE

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1339 bytes --]

On Wed, Jun 19, 2024 at 10:53:22AM +0200, AngeloGioacchino Del Regno wrote:
> Add mediatek,mt8188-gce to the list of compatibles for which the
> clock-names property is not required.

Because, I assume, it has some internal clock? Why do either of these
things have no clock? Doesn't the internal logic require one?

> 
> Fixes: f2b53c295620 ("dt-bindings: mailbox: mediatek,gce-mailbox: add mt8188 compatible name")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  .../devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml     | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> index cef9d7601398..55d4c34aa4b4 100644
> --- a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> @@ -62,7 +62,9 @@ allOf:
>          properties:
>            compatible:
>              contains:
> -              const: mediatek,mt8195-gce
> +              enum:
> +                - mediatek,mt8188-gce
> +                - mediatek,mt8195-gce
>      then:
>        required:
>          - clock-names
> -- 
> 2.45.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/3] dt-bindings: clock: mediatek: Document reset cells for MT8188 sys

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

On Wed, Jun 19, 2024 at 10:53:21AM +0200, AngeloGioacchino Del Regno wrote:
> The MT8188 sys clocks embed a reset controller: add #reset-cells
> to the binding to allow using resets.
> 
> Fixes: 1086a5310f9c ("dt-bindings: clock: mediatek: Add new MT8188 clock")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 3/3] dt-bindings: mailbox: mediatek: Avoid clock-names on MT8188 GCE

[AngeloGioacchino Del Regno]

Il 19/06/24 19:49, Conor Dooley ha scritto:
> On Wed, Jun 19, 2024 at 10:53:22AM +0200, AngeloGioacchino Del Regno wrote:
>> Add mediatek,mt8188-gce to the list of compatibles for which the
>> clock-names property is not required.
> 
> Because, I assume, it has some internal clock? Why do either of these
> things have no clock? Doesn't the internal logic require one?
> 

Because there's no gce0/gce1 clock, there's only an infracfg_AO clock that is
for one GCE instance, hence there's no need to require clock-names.

I can't remove the clock-names requirement from the older compatibles though,
because the (sorry about this word) driver (eh..) gets the clock by name for
the single GCE SoCs...

...and here comes a self-NACK for this commit, I have to fix the driver and
then stop requiring clock-names on all compatibles, instead of having this
ugly nonsense.

Self-note: gce0/gce1 clocks lookup was implemented in the driver but never
used and never added to the binding - luckily.

Sorry Conor, I just acknowledged that there's a better way of doing that.

Thank you for making me re-read this stuff, I'll send the proper changes
later today, driver change + binding change in a separate series.

As for the other two commits in this series, completely unrelated to GCE,
those are still fine, and are fixing dtbs_check warnings.

Cheers,
Angelo

>>
>> Fixes: f2b53c295620 ("dt-bindings: mailbox: mediatek,gce-mailbox: add mt8188 compatible name")
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>>   .../devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml     | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
>> index cef9d7601398..55d4c34aa4b4 100644
>> --- a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
>> +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
>> @@ -62,7 +62,9 @@ allOf:
>>           properties:
>>             compatible:
>>               contains:
>> -              const: mediatek,mt8195-gce
>> +              enum:
>> +                - mediatek,mt8188-gce
>> +                - mediatek,mt8195-gce
>>       then:
>>         required:
>>           - clock-names
>> -- 
>> 2.45.2
>>

Re: [PATCH 3/3] dt-bindings: mailbox: mediatek: Avoid clock-names on MT8188 GCE

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1742 bytes --]

On Thu, Jun 20, 2024 at 10:01:18AM +0200, AngeloGioacchino Del Regno wrote:
> Il 19/06/24 19:49, Conor Dooley ha scritto:
> > On Wed, Jun 19, 2024 at 10:53:22AM +0200, AngeloGioacchino Del Regno wrote:
> > > Add mediatek,mt8188-gce to the list of compatibles for which the
> > > clock-names property is not required.
> > 
> > Because, I assume, it has some internal clock? Why do either of these
> > things have no clock? Doesn't the internal logic require one?
> > 
> 
> Because there's no gce0/gce1 clock, there's only an infracfg_AO clock that is
> for one GCE instance, hence there's no need to require clock-names.

clock-names, d'oh. I misread that completely yesterday.

> I can't remove the clock-names requirement from the older compatibles though,
> because the (sorry about this word) driver (eh..) gets the clock by name for
> the single GCE SoCs...
> 
> ...and here comes a self-NACK for this commit, I have to fix the driver and
> then stop requiring clock-names on all compatibles, instead of having this
> ugly nonsense.

Is it not worth keeping the clock names, even if ugly or w/e, because
things have been done that way for a while?
Also, what does U-Boot do on these systems to get the clocks?

> Self-note: gce0/gce1 clocks lookup was implemented in the driver but never
> used and never added to the binding - luckily.
> 
> Sorry Conor, I just acknowledged that there's a better way of doing that.
> 
> Thank you for making me re-read this stuff, I'll send the proper changes
> later today, driver change + binding change in a separate series.
> 
> As for the other two commits in this series, completely unrelated to GCE,
> those are still fine, and are fixing dtbs_check warnings.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 3/3] dt-bindings: mailbox: mediatek: Avoid clock-names on MT8188 GCE

[AngeloGioacchino Del Regno]

Il 20/06/24 10:22, Conor Dooley ha scritto:
> On Thu, Jun 20, 2024 at 10:01:18AM +0200, AngeloGioacchino Del Regno wrote:
>> Il 19/06/24 19:49, Conor Dooley ha scritto:
>>> On Wed, Jun 19, 2024 at 10:53:22AM +0200, AngeloGioacchino Del Regno wrote:
>>>> Add mediatek,mt8188-gce to the list of compatibles for which the
>>>> clock-names property is not required.
>>>
>>> Because, I assume, it has some internal clock? Why do either of these
>>> things have no clock? Doesn't the internal logic require one?
>>>
>>
>> Because there's no gce0/gce1 clock, there's only an infracfg_AO clock that is
>> for one GCE instance, hence there's no need to require clock-names.
> 
> clock-names, d'oh. I misread that completely yesterday.
> 
>> I can't remove the clock-names requirement from the older compatibles though,
>> because the (sorry about this word) driver (eh..) gets the clock by name for
>> the single GCE SoCs...
>>
>> ...and here comes a self-NACK for this commit, I have to fix the driver and
>> then stop requiring clock-names on all compatibles, instead of having this
>> ugly nonsense.
> 
> Is it not worth keeping the clock names, even if ugly or w/e, because
> things have been done that way for a while?

It's worth allowing clock-names, but *requiring* that is unnecessary because
there is, and there will always be, only one clock...!

> Also, what does U-Boot do on these systems to get the clocks?
> 

U-Boot doesn't support GCE at all (no driver - at least upstream)...!

>> Self-note: gce0/gce1 clocks lookup was implemented in the driver but never
>> used and never added to the binding - luckily.
>>
>> Sorry Conor, I just acknowledged that there's a better way of doing that.
>>
>> Thank you for making me re-read this stuff, I'll send the proper changes
>> later today, driver change + binding change in a separate series.
>>
>> As for the other two commits in this series, completely unrelated to GCE,
>> those are still fine, and are fixing dtbs_check warnings.

Re: [PATCH 1/3] arm64: dts: mediatek: mt8188: Fix VPPSYS0/1 node name/compatibles

[Fei Shao]

On Wed, Jun 19, 2024 at 4:53 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Like VDOSYS0/1, the VPPSYS0 and VPPSYS1 are syscon nodes, as
> described by the mediatek,mmsys binding: fix the node name to
> be syscon@address and add "syscon" to the list of compatible
> strings for both VPPSYS0 and VPPSYS1.
>
> Fixes: 9461e0caac9e ("arm64: dts: Add MediaTek MT8188 dts and evaluation board and Makefile")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Reviewed-by: Fei Shao <fshao@chromium.org>

> ---
>  arch/arm64/boot/dts/mediatek/mt8188.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> index 3b02170562ae..77c4f2d104cd 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> @@ -1331,8 +1331,8 @@ mfgcfg: clock-controller@13fbf000 {
>                         #clock-cells = <1>;
>                 };
>
> -               vppsys0: clock-controller@14000000 {
> -                       compatible = "mediatek,mt8188-vppsys0";
> +               vppsys0: syscon@14000000 {
> +                       compatible = "mediatek,mt8188-vppsys0", "syscon";
>                         reg = <0 0x14000000 0 0x1000>;
>                         #clock-cells = <1>;
>                 };
> @@ -1349,8 +1349,8 @@ wpesys_vpp0: clock-controller@14e02000 {
>                         #clock-cells = <1>;
>                 };
>
> -               vppsys1: clock-controller@14f00000 {
> -                       compatible = "mediatek,mt8188-vppsys1";
> +               vppsys1: syscon@14f00000 {
> +                       compatible = "mediatek,mt8188-vppsys1", "syscon";
>                         reg = <0 0x14f00000 0 0x1000>;
>                         #clock-cells = <1>;
>                 };
> --
> 2.45.2
>
>

Re: [PATCH 3/3] dt-bindings: mailbox: mediatek: Avoid clock-names on MT8188 GCE

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2478 bytes --]

On Thu, Jun 20, 2024 at 10:32:36AM +0200, AngeloGioacchino Del Regno wrote:
> Il 20/06/24 10:22, Conor Dooley ha scritto:
> > On Thu, Jun 20, 2024 at 10:01:18AM +0200, AngeloGioacchino Del Regno wrote:
> > > Il 19/06/24 19:49, Conor Dooley ha scritto:
> > > > On Wed, Jun 19, 2024 at 10:53:22AM +0200, AngeloGioacchino Del Regno wrote:
> > > > > Add mediatek,mt8188-gce to the list of compatibles for which the
> > > > > clock-names property is not required.
> > > > 
> > > > Because, I assume, it has some internal clock? Why do either of these
> > > > things have no clock? Doesn't the internal logic require one?
> > > > 
> > > 
> > > Because there's no gce0/gce1 clock, there's only an infracfg_AO clock that is
> > > for one GCE instance, hence there's no need to require clock-names.
> > 
> > clock-names, d'oh. I misread that completely yesterday.
> > 
> > > I can't remove the clock-names requirement from the older compatibles though,
> > > because the (sorry about this word) driver (eh..) gets the clock by name for
> > > the single GCE SoCs...
> > > 
> > > ...and here comes a self-NACK for this commit, I have to fix the driver and
> > > then stop requiring clock-names on all compatibles, instead of having this
> > > ugly nonsense.
> > 
> > Is it not worth keeping the clock names, even if ugly or w/e, because
> > things have been done that way for a while?
> 
> It's worth allowing clock-names, but *requiring* that is unnecessary because
> there is, and there will always be, only one clock...!

Right, dunno if I misread you earlier or misunderstood. Fighting fires
at work and replying to mails mid bisection is what I am going to blame
;)

> > Also, what does U-Boot do on these systems to get the clocks?
> > 
> 
> U-Boot doesn't support GCE at all (no driver - at least upstream)...!

Running LIFO through my mailbox today, seeing this after the other
mail..

> 
> > > Self-note: gce0/gce1 clocks lookup was implemented in the driver but never
> > > used and never added to the binding - luckily.
> > > 
> > > Sorry Conor, I just acknowledged that there's a better way of doing that.
> > > 
> > > Thank you for making me re-read this stuff, I'll send the proper changes
> > > later today, driver change + binding change in a separate series.
> > > 
> > > As for the other two commits in this series, completely unrelated to GCE,
> > > those are still fine, and are fixing dtbs_check warnings.
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: (subset) [PATCH 1/3] arm64: dts: mediatek: mt8188: Fix VPPSYS0/1 node name/compatibles

[AngeloGioacchino Del Regno]

On Wed, 19 Jun 2024 10:53:20 +0200, AngeloGioacchino Del Regno wrote:
> Like VDOSYS0/1, the VPPSYS0 and VPPSYS1 are syscon nodes, as
> described by the mediatek,mmsys binding: fix the node name to
> be syscon@address and add "syscon" to the list of compatible
> strings for both VPPSYS0 and VPPSYS1.
> 
> 

Applied to for-next, thanks!

[1/3] arm64: dts: mediatek: mt8188: Fix VPPSYS0/1 node name/compatibles
      commit: 013b7ab4080af0dccae16c6ea8a1e88ad530114c

Cheers,
Angelo

Re: [PATCH 2/3] dt-bindings: clock: mediatek: Document reset cells for MT8188 sys

[Stephen Boyd]

Quoting AngeloGioacchino Del Regno (2024-06-19 01:53:21)
> The MT8188 sys clocks embed a reset controller: add #reset-cells
> to the binding to allow using resets.
> 
> Fixes: 1086a5310f9c ("dt-bindings: clock: mediatek: Add new MT8188 clock")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---

Applied to clk-next