Re: [PATCH] dt-bindings: clock: rcar-gen2: Remove obsolete header files

[Conor Dooley <conor.dooley@microchip.com>]

[-- Attachment #1: Type: text/plain, Size: 1840 bytes --]

On Thu, Jun 20, 2024 at 10:30:25AM +0200, Geert Uytterhoeven wrote:
> Hi Marek, Conor,
> 
> On Wed, Jun 19, 2024 at 9:17 PM Marek Vasut <marek.vasut@mailbox.org> wrote:
> > On 6/19/24 7:48 PM, Conor Dooley wrote:
> > > On Wed, Jun 19, 2024 at 01:22:46PM +0200, Geert Uytterhoeven wrote:
> > >> The clock definitions in <dt-bindings/clock/r8a779?-clock.h> were
> > >> superseded by those in <dt-bindings/clock/r8a779?-cpg-mssr.h> a long
> > >> time ago.
> > >>
> > >> The last DTS user of these files was removed in commit 362b334b17943d84
> > >> ("ARM: dts: r8a7791: Convert to new CPG/MSSR bindings") in v4.15.
> > >> Driver support for the old bindings was removed in commit
> > >> 58256143cff7c2e0 ("clk: renesas: Remove R-Car Gen2 legacy DT clock
> > >> support") in v5.5, so there is no point to keep on carrying these.
> > >>
> > >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > > If U-Boot is not using them,
> > > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > > (and if it is, another task for Marek I guess!)
> 
> Good point!
> 
> U-Boot does have include/dt-bindings/clock/r8a779?-clock.h, despite
> never having used them.  The unused headers and the corresponding
> r8a779?.dtsi files were introduced together, in the various "ARM: dts:
> rmobile: Import R8A779[0-4] DTS from Linux 4.15-rc8") commits in U-Boot
> v2018.03, i.e. after the conversion to the CPG/MSSR DT bindings.
> 
> > U-Boot is using upstream DTs on R-Car via OF_UPSTREAM, so whatever
> > happens in Linux also happens in U-Boot since 2024.07 ... with slight
> > sync delay . I don't expect much breakage.
> 
> So the obsolete headers will be removed automatically from U-Boot
> soon, too?

Not if it is is include/dt-bindings/, only if it is in
dts/upstream/include/dt-bindings AFAIU.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]