From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 827EF1B151F; Thu, 20 Jun 2024 16:16:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718900206; cv=none; b=Luua2Tx5xYSeoLEmXxV1y9TX8EWiM46ou2+Xnk4uIlE2Lz3v15jcjXjwiAD2jCjJbcaMP/6RVX9E2SSbQ9OSsfVkB4bIjQrJtsD+9XgiYcUJXVisy52ZV3ZqVxsGPvvUAVkdJVXKAyupuRoGp4Ayn81OsHAwP1aZHCyKQODoGZ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718900206; c=relaxed/simple; bh=MlmWkVEKzTwzyTEHRJjRJM3FETRdl85oGzHJ0HQkxVg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LEQGDqURe0uW70HaiKhxlK8U6IxOGmiOBbYeTgBA6y+jOI6r/EPDwbE+5HEIWUfBSPi/N8I8aKDYPfSufIwlnITPe/nNceUb+ix7LvrW/WW+cjUCLKHAz3acWIlvZDC7lHuud9u1D7xrMRVpfhlM4wMskP/A8mMeVO7VCyrBONM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZFr5LJbs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZFr5LJbs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37BA7C4AF07; Thu, 20 Jun 2024 16:16:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718900206; bh=MlmWkVEKzTwzyTEHRJjRJM3FETRdl85oGzHJ0HQkxVg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZFr5LJbskoDfbvpN0PmNGIwnRLrx6lgUgzxwXrODA0+ngJDKTh6hyTFYU3x4Vn7Z0 g/QrWGCMv8hC7MYVpJfI+fJHWQaohBTaSXsEcavDwrfkIvinxEy3NIBwI/XLYg40Hr u0qCsGjaUYtXt3ywzot+3gPptjbi5c6Uoy7d5YCQsoiLAdzco5WyuKtMYJUCi+sTfz 3OPp9gZRQaEsRaco717MH4O/smJ+3Gi1fJJu9RRUfru2hjczI1PfvOLQ5hl/IUTEqp Lbd3/rkNlX16ixSzxH2gAmm+MBReO+ulBNh37fGfsilU5kM5nq+mqZIStbaWZgpHiO X/OvA3s/0b+Pw== Date: Thu, 20 Jun 2024 17:16:40 +0100 From: Conor Dooley To: AngeloGioacchino Del Regno Cc: Conor Dooley , krzk+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, jassisinghbrar@gmail.com, garmin.chang@mediatek.com, houlong.wei@mediatek.com, Jason-ch.Chen@mediatek.com, amergnat@baylibre.com, Elvis.Wang@mediatek.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH 3/3] dt-bindings: mailbox: mediatek: Avoid clock-names on MT8188 GCE Message-ID: <20240620-prize-cavalier-01460bf50050@spud> References: <20240619085322.66716-1-angelogioacchino.delregno@collabora.com> <20240619085322.66716-3-angelogioacchino.delregno@collabora.com> <20240619-sleeve-citable-a3dc10e5cd4f@spud> <20240620-district-bullring-c028e0183925@wendy> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jbOS/vXohNu3Z1I1" Content-Disposition: inline In-Reply-To: --jbOS/vXohNu3Z1I1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 20, 2024 at 10:32:36AM +0200, AngeloGioacchino Del Regno wrote: > Il 20/06/24 10:22, Conor Dooley ha scritto: > > On Thu, Jun 20, 2024 at 10:01:18AM +0200, AngeloGioacchino Del Regno wr= ote: > > > Il 19/06/24 19:49, Conor Dooley ha scritto: > > > > On Wed, Jun 19, 2024 at 10:53:22AM +0200, AngeloGioacchino Del Regn= o wrote: > > > > > Add mediatek,mt8188-gce to the list of compatibles for which the > > > > > clock-names property is not required. > > > >=20 > > > > Because, I assume, it has some internal clock? Why do either of the= se > > > > things have no clock? Doesn't the internal logic require one? > > > >=20 > > >=20 > > > Because there's no gce0/gce1 clock, there's only an infracfg_AO clock= that is > > > for one GCE instance, hence there's no need to require clock-names. > >=20 > > clock-names, d'oh. I misread that completely yesterday. > >=20 > > > I can't remove the clock-names requirement from the older compatibles= though, > > > because the (sorry about this word) driver (eh..) gets the clock by n= ame for > > > the single GCE SoCs... > > >=20 > > > ...and here comes a self-NACK for this commit, I have to fix the driv= er and > > > then stop requiring clock-names on all compatibles, instead of having= this > > > ugly nonsense. > >=20 > > Is it not worth keeping the clock names, even if ugly or w/e, because > > things have been done that way for a while? >=20 > It's worth allowing clock-names, but *requiring* that is unnecessary beca= use > there is, and there will always be, only one clock...! Right, dunno if I misread you earlier or misunderstood. Fighting fires at work and replying to mails mid bisection is what I am going to blame ;) > > Also, what does U-Boot do on these systems to get the clocks? > >=20 >=20 > U-Boot doesn't support GCE at all (no driver - at least upstream)...! Running LIFO through my mailbox today, seeing this after the other mail.. >=20 > > > Self-note: gce0/gce1 clocks lookup was implemented in the driver but = never > > > used and never added to the binding - luckily. > > >=20 > > > Sorry Conor, I just acknowledged that there's a better way of doing t= hat. > > >=20 > > > Thank you for making me re-read this stuff, I'll send the proper chan= ges > > > later today, driver change + binding change in a separate series. > > >=20 > > > As for the other two commits in this series, completely unrelated to = GCE, > > > those are still fine, and are fixing dtbs_check warnings. >=20 >=20 --jbOS/vXohNu3Z1I1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZnRV6AAKCRB4tDGHoIJi 0iPkAP9KYQ34Wxhe6bOZwHhYtdnsKdrRh0kI6IDFCx77qgbTEAD+OG9IT9Zrd+R1 2LwxBUbA8JNIZOP3VtParnm8vK8h6wM= =QiGH -----END PGP SIGNATURE----- --jbOS/vXohNu3Z1I1--