Re: [PATCH v9 3/7] coresight: core: Add provision for panic callbacks

From: Linu Cherian <lcherian@marvell.com>
To: James Clark <james.clark@arm.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<coresight@lists.linaro.org>, <linux-kernel@vger.kernel.org>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
	<sgoutham@marvell.com>, <gcherian@marvell.com>,
	<suzuki.poulose@arm.com>, <mike.leach@linaro.org>
Subject: Re: [PATCH v9 3/7] coresight: core: Add provision for panic callbacks
Date: Thu, 20 Jun 2024 09:42:12 +0530	[thread overview]
Message-ID: <20240620041212.GD125816@hyd1403.caveonetworks.com> (raw)
In-Reply-To: <739d24fc-b557-4ef9-875d-d1a800f6c4db@arm.com>

On 2024-06-05 at 21:39:17, James Clark (james.clark@arm.com) wrote:
> 
> 
> On 05/06/2024 09:17, Linu Cherian wrote:
> > Panic callback handlers allows coresight device drivers to sync
> > relevant trace data and trace metadata to reserved memory
> > regions so that they can be retrieved later in the subsequent
> > boot or in the crashdump kernel.
> > 
> > Signed-off-by: Linu Cherian <lcherian@marvell.com>
> > Reviewed-by: James Clark <james.clark@arm.com>
> > ---
> > Changelog from v8:
> > Added Reviewed-by tag.
> > 
> >  drivers/hwtracing/coresight/coresight-core.c | 37 ++++++++++++++++++++
> >  include/linux/coresight.h                    | 12 +++++++
> >  2 files changed, 49 insertions(+)
> > 
> 
> [...]
> 
> >  static int __init coresight_init(void)
> >  {
> >  	int ret;
> > @@ -1377,6 +1408,10 @@ static int __init coresight_init(void)
> >  	if (ret)
> >  		goto exit_bus_unregister;
> >  
> > +	/* Register function to be called for panic */
> > +	ret = atomic_notifier_chain_register(&panic_notifier_list,
> > +					     &coresight_notifier);
> > +
> 
> ret isn't checked here

Ack.

> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel