[PATCH 0/3] arm64: dts: mediatek: Add MT8186 Voltorb Chromebooks

[PATCH 0/3] arm64: dts: mediatek: Add MT8186 Voltorb Chromebooks

[Chen-Yu Tsai]

Hi folks,

This series adds support for the MT8186 Voltorb Chromebooks. This is yet
another product based on the Corsola reference design. This particular
version features a higher end spec-ed SoC, necessitating a beefier
regulator for the big core cluster.

Patch 1 adds an entry for a new regulator IC. How this differs from
the previous iteration is not totally clear.

Patch 2 adds an entry for the Voltorb devices.

Patch 3 adds the device trees for the new devices.


Please have a look. I expect either all three patches to go through the
MediaTek tree; or the first can go through the regulator tree, and the
other two through the MediaTek tree.


Thanks
ChenYu


Chen-Yu Tsai (3):
  dt-bindings: regulator: mt6315: Document MT6319 PMIC
  dt-bindings: arm: mediatek: Add MT8186 Voltorb Chromebooks
  arm64: dts: mediatek: Add MT8186 Voltorb Chromebooks

 .../devicetree/bindings/arm/mediatek.yaml     |   7 ++
 .../bindings/regulator/mt6315-regulator.yaml  |   6 +-
 arch/arm64/boot/dts/mediatek/Makefile         |   2 +
 .../mt8186-corsola-voltorb-sku589824.dts      |  13 +++
 .../mt8186-corsola-voltorb-sku589825.dts      |  25 +++++
 .../dts/mediatek/mt8186-corsola-voltorb.dtsi  | 103 ++++++++++++++++++
 6 files changed, 155 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589824.dts
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589825.dts
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb.dtsi

-- 
2.45.2.741.gdbec12cfda-goog

[PATCH 1/3] dt-bindings: regulator: mt6315: Document MT6319 PMIC

[Chen-Yu Tsai]

The MT6319 is a pin-compatible drop-in replacement for MT6315 with
slightly better electrical characteristics.

It's unclear whether there are any differences, since the downstream
implementation doesn't describe the MT6319 separately. Neither does the
implementation check chip IDs, even though those are available.

Add a new compatible for the MT6319 just in case differences are
discovered later and fall back to the MT6315 compatible.

Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
 .../devicetree/bindings/regulator/mt6315-regulator.yaml     | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml b/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml
index 6317daf76d1f..cd4aa27218a1 100644
--- a/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml
@@ -16,7 +16,11 @@ description: |
 
 properties:
   compatible:
-    const: mediatek,mt6315-regulator
+    oneOf:
+      - items:
+          - const: mediatek,mt6319-regulator
+          - const: mediatek,mt6315-regulator
+      - const: mediatek,mt6315-regulator
 
   reg:
     maxItems: 1
-- 
2.45.2.741.gdbec12cfda-goog

[PATCH 2/3] dt-bindings: arm: mediatek: Add MT8186 Voltorb Chromebooks

[Chen-Yu Tsai]

Add an entry for the MT8186 based Voltorb Chromebooks, also known as the
Acer Chromebook 311 (C723/C723T). The device is a clamshell style laptop
with an optional touchscreen.

Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
 Documentation/devicetree/bindings/arm/mediatek.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index b1b09db0bd65..e7746afeb0b3 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -301,6 +301,13 @@ properties:
           - const: google,tentacruel-sku327683
           - const: google,tentacruel
           - const: mediatek,mt8186
+      - description: Google Voltorb (Acer Chromebook 311 C723/C732T)
+        items:
+          - enum:
+              - google,voltorb-sku589824
+              - google,voltorb-sku589825
+          - const: google,voltorb
+          - const: mediatek,mt8186
       - items:
           - enum:
               - mediatek,mt8186-evb
-- 
2.45.2.741.gdbec12cfda-goog

[PATCH 3/3] arm64: dts: mediatek: Add MT8186 Voltorb Chromebooks

[Chen-Yu Tsai]

Add device trees for the MT8186 based Voltorb Chromebooks, also known
as the Acer Chromebook 311 (C723/C723T). The devices are clamshell
style laptops with an optional touchscreen.

The devices differ from the other existing MT8186 Chromebooks in that
it uses a higher speced / binned SoC which also requires a separate
PMIC for the big core cluster. Also, a different codec is used for
the internal speakers.

Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
 arch/arm64/boot/dts/mediatek/Makefile         |   2 +
 .../mt8186-corsola-voltorb-sku589824.dts      |  13 +++
 .../mt8186-corsola-voltorb-sku589825.dts      |  25 +++++
 .../dts/mediatek/mt8186-corsola-voltorb.dtsi  | 103 ++++++++++++++++++
 4 files changed, 143 insertions(+)
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589824.dts
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589825.dts
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb.dtsi

diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
index a2d128b17c45..e0cb1b35acfd 100644
--- a/arch/arm64/boot/dts/mediatek/Makefile
+++ b/arch/arm64/boot/dts/mediatek/Makefile
@@ -64,6 +64,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-tentacool-sku327681.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-tentacool-sku327683.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-tentacruel-sku262144.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-tentacruel-sku262148.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-voltorb-sku589824.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-voltorb-sku589825.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-evb.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8188-evb.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-asurada-hayato-r1.dtb
diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589824.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589824.dts
new file mode 100644
index 000000000000..d16834eec87a
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589824.dts
@@ -0,0 +1,13 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2022 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8186-corsola-voltorb.dtsi"
+
+/ {
+	model = "Google Voltorb sku589824 board";
+	compatible = "google,voltorb-sku589824", "google,voltorb",
+		     "mediatek,mt8186";
+};
diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589825.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589825.dts
new file mode 100644
index 000000000000..45e57f7706cc
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589825.dts
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2022 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8186-corsola-voltorb.dtsi"
+
+/ {
+	model = "Google Voltorb sku589825 board";
+	compatible = "google,voltorb-sku589825", "google,voltorb",
+		     "mediatek,mt8186";
+};
+
+&i2c1 {
+	touchscreen@10 {
+		compatible = "elan,ekth6915";
+		reg = <0x10>;
+		interrupts-extended = <&pio 12 IRQ_TYPE_LEVEL_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&touchscreen_pins>;
+		reset-gpios = <&pio 60 GPIO_ACTIVE_LOW>;
+		vcc33-supply = <&pp3300_s3>;
+	};
+};
diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb.dtsi
new file mode 100644
index 000000000000..52ec58128d56
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb.dtsi
@@ -0,0 +1,103 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2022 Google LLC
+ */
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/spmi/spmi.h>
+
+#include "mt8186-corsola-steelix.dtsi"
+
+/ {
+	chassis-type = "laptop";
+
+	max98360a: max98360a {
+		compatible = "maxim,max98360a";
+		sdmode-gpios = <&pio 150 GPIO_ACTIVE_HIGH>;
+		#sound-dai-cells = <0>;
+	};
+};
+
+&cpu6 {
+	proc-supply = <&mt6319_buck1>;
+};
+
+&cpu7 {
+	proc-supply = <&mt6319_buck1>;
+};
+
+&gpio_keys {
+	status = "disabled";
+};
+
+&keyboard_controller {
+	linux,keymap = <
+		MATRIX_KEY(0x00, 0x02, KEY_BACK)
+		MATRIX_KEY(0x03, 0x02, KEY_REFRESH)
+		MATRIX_KEY(0x02, 0x02, KEY_ZOOM)
+		MATRIX_KEY(0x01, 0x02, KEY_SCALE)
+		MATRIX_KEY(0x03, 0x04, KEY_SYSRQ)
+		MATRIX_KEY(0x02, 0x04, KEY_BRIGHTNESSDOWN)
+		MATRIX_KEY(0x01, 0x04, KEY_BRIGHTNESSUP)
+		MATRIX_KEY(0x02, 0x09, KEY_MUTE)
+		MATRIX_KEY(0x01, 0x09, KEY_VOLUMEDOWN)
+		MATRIX_KEY(0x00, 0x04, KEY_VOLUMEUP)
+		CROS_STD_MAIN_KEYMAP
+	>;
+};
+
+&mt6366_vproc11_reg {
+	status = "disabled";
+};
+
+&cluster1_opp_14 {
+	opp-hz = /bits/ 64 <2050000000>;
+	opp-microvolt = <1118750>;
+};
+
+&cluster1_opp_15 {
+	opp-hz = /bits/ 64 <2200000000>;
+};
+
+&rt1019p{
+	status = "disabled";
+};
+
+&sound {
+	compatible = "mediatek,mt8186-mt6366-rt5682s-max98360-sound";
+	status = "okay";
+
+	spk-hdmi-playback-dai-link {
+		codec {
+			sound-dai = <&it6505dptx>, <&max98360a>;
+		};
+	};
+};
+
+&spmi {
+	pinctrl-names = "default";
+	pinctrl-0 = <&spmi_pins>;
+	#address-cells = <2>;
+	#size-cells = <0>;
+	status = "okay";
+
+	pmic@6 {
+		compatible = "mediatek,mt6319-regulator", "mediatek,mt6315-regulator";
+		reg = <0x6 SPMI_USID>;
+
+		regulators {
+			mt6319_buck1: vbuck1 {
+					regulator-name = "ppvar_dvdd_proc_bc_mt6319";
+					regulator-min-microvolt = <600000>;
+					regulator-max-microvolt = <1193750>;
+					regulator-enable-ramp-delay = <256>;
+					regulator-allowed-modes = <0 1 2>;
+					regulator-always-on;
+			};
+		};
+	};
+};
+
+&touchscreen {
+	status = "disabled";
+};
-- 
2.45.2.741.gdbec12cfda-goog

Re: [PATCH 1/3] dt-bindings: regulator: mt6315: Document MT6319 PMIC

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 644 bytes --]

On Thu, Jun 20, 2024 at 05:47:36PM +0800, Chen-Yu Tsai wrote:
> The MT6319 is a pin-compatible drop-in replacement for MT6315 with
> slightly better electrical characteristics.
> 
> It's unclear whether there are any differences, since the downstream
> implementation doesn't describe the MT6319 separately. Neither does the
> implementation check chip IDs, even though those are available.
> 
> Add a new compatible for the MT6319 just in case differences are
> discovered later and fall back to the MT6315 compatible.
> 
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/3] dt-bindings: arm: mediatek: Add MT8186 Voltorb Chromebooks

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]

On Thu, Jun 20, 2024 at 05:47:37PM +0800, Chen-Yu Tsai wrote:
> Add an entry for the MT8186 based Voltorb Chromebooks, also known as the
> Acer Chromebook 311 (C723/C723T). The device is a clamshell style laptop
> with an optional touchscreen.
> 
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
>  Documentation/devicetree/bindings/arm/mediatek.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index b1b09db0bd65..e7746afeb0b3 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -301,6 +301,13 @@ properties:
>            - const: google,tentacruel-sku327683
>            - const: google,tentacruel
>            - const: mediatek,mt8186
> +      - description: Google Voltorb (Acer Chromebook 311 C723/C732T)
> +        items:
> +          - enum:
> +              - google,voltorb-sku589824
> +              - google,voltorb-sku589825

This looks rather sane for a chromebook!
Acked-by: Conor Dooley <conor.dooley@microchip.com>

> +          - const: google,voltorb
> +          - const: mediatek,mt8186
>        - items:
>            - enum:
>                - mediatek,mt8186-evb
> -- 
> 2.45.2.741.gdbec12cfda-goog
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: (subset) [PATCH 0/3] arm64: dts: mediatek: Add MT8186 Voltorb Chromebooks

[Mark Brown]

On Thu, 20 Jun 2024 17:47:35 +0800, Chen-Yu Tsai wrote:
> This series adds support for the MT8186 Voltorb Chromebooks. This is yet
> another product based on the Corsola reference design. This particular
> version features a higher end spec-ed SoC, necessitating a beefier
> regulator for the big core cluster.
> 
> Patch 1 adds an entry for a new regulator IC. How this differs from
> the previous iteration is not totally clear.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/3] dt-bindings: regulator: mt6315: Document MT6319 PMIC
      commit: ffe4b381e2ea97c7a5868dbe841c7522b1b0b408

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH 2/3] dt-bindings: arm: mediatek: Add MT8186 Voltorb Chromebooks

[Chen-Yu Tsai]

On Fri, Jun 21, 2024 at 12:13 AM Conor Dooley <conor@kernel.org> wrote:
>
> On Thu, Jun 20, 2024 at 05:47:37PM +0800, Chen-Yu Tsai wrote:
> > Add an entry for the MT8186 based Voltorb Chromebooks, also known as the
> > Acer Chromebook 311 (C723/C723T). The device is a clamshell style laptop
> > with an optional touchscreen.
> >
> > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> > ---
> >  Documentation/devicetree/bindings/arm/mediatek.yaml | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > index b1b09db0bd65..e7746afeb0b3 100644
> > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > @@ -301,6 +301,13 @@ properties:
> >            - const: google,tentacruel-sku327683
> >            - const: google,tentacruel
> >            - const: mediatek,mt8186
> > +      - description: Google Voltorb (Acer Chromebook 311 C723/C732T)
> > +        items:
> > +          - enum:
> > +              - google,voltorb-sku589824
> > +              - google,voltorb-sku589825
>
> This looks rather sane for a chromebook!

It really depends on the OEM/ODM for how many combinations they end up
producing...

> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks!

> > +          - const: google,voltorb
> > +          - const: mediatek,mt8186
> >        - items:
> >            - enum:
> >                - mediatek,mt8186-evb
> > --
> > 2.45.2.741.gdbec12cfda-goog
> >

Re: (subset) [PATCH 0/3] arm64: dts: mediatek: Add MT8186 Voltorb Chromebooks

[AngeloGioacchino Del Regno]

On Thu, 20 Jun 2024 17:47:35 +0800, Chen-Yu Tsai wrote:
> This series adds support for the MT8186 Voltorb Chromebooks. This is yet
> another product based on the Corsola reference design. This particular
> version features a higher end spec-ed SoC, necessitating a beefier
> regulator for the big core cluster.
> 
> Patch 1 adds an entry for a new regulator IC. How this differs from
> the previous iteration is not totally clear.
> 
> [...]

Applied to v6.10-next/dts64, thanks!

[2/3] dt-bindings: arm: mediatek: Add MT8186 Voltorb Chromebooks
      commit: 52225f8c1347328168f113cc2c089bf81e6714d6
[3/3] arm64: dts: mediatek: Add MT8186 Voltorb Chromebooks
      commit: e612fe2dfd7833ae06e7418eba39d7fbddb36799

Cheers,
Angelo