* [PATCH 3/3] dt-bindings: vendor-prefix: Add prefix for Efinix, Inc.
@ 2024-06-20 14:47 iansdannapel
2024-06-20 15:44 ` Conor Dooley
0 siblings, 1 reply; 5+ messages in thread
From: iansdannapel @ 2024-06-20 14:47 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, heiko.stuebner, neil.armstrong,
macromorgan, sre, hvilleneuve, andre.przywara, michael.riesch,
linus.walleij, devicetree, linux-kernel
Cc: Ian Dannapel
From: Ian Dannapel <iansdannapel@gmail.com>
Add entry for Efinix, Inc. (https://www.efinixinc.com/)
Signed-off-by: Ian Dannapel <iansdannapel@gmail.com>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index fbf47f0bacf1..8e9dc26b2a79 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -422,6 +422,8 @@ patternProperties:
description: Emtop Embedded Solutions
"^eeti,.*":
description: eGalax_eMPIA Technology Inc
+ "^efnx,.*":
+ description: Efinix, Inc.
"^einfochips,.*":
description: Einfochips
"^eink,.*":
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 3/3] dt-bindings: vendor-prefix: Add prefix for Efinix, Inc.
2024-06-20 14:47 [PATCH 3/3] dt-bindings: vendor-prefix: Add prefix for Efinix, Inc iansdannapel
@ 2024-06-20 15:44 ` Conor Dooley
0 siblings, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2024-06-20 15:44 UTC (permalink / raw)
To: iansdannapel
Cc: robh, krzk+dt, conor+dt, heiko.stuebner, neil.armstrong,
macromorgan, sre, hvilleneuve, andre.przywara, michael.riesch,
linus.walleij, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]
On Thu, Jun 20, 2024 at 04:47:08PM +0200, iansdannapel@gmail.com wrote:
> From: Ian Dannapel <iansdannapel@gmail.com>
>
> Add entry for Efinix, Inc. (https://www.efinixinc.com/)
>
> Signed-off-by: Ian Dannapel <iansdannapel@gmail.com>
This is a 3/3 patch is but is unthreaded with no user visible on lore:
https://lore.kernel.org/all/20240620144708.125497-1-iansdannapel@gmail.com/
What's gone wrong here?
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index fbf47f0bacf1..8e9dc26b2a79 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -422,6 +422,8 @@ patternProperties:
> description: Emtop Embedded Solutions
> "^eeti,.*":
> description: eGalax_eMPIA Technology Inc
> + "^efnx,.*":
> + description: Efinix, Inc.
> "^einfochips,.*":
> description: Einfochips
> "^eink,.*":
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/3] fpga: Add Efinix Trion & Titanium serial SPI programming driver
@ 2024-09-27 14:14 iansdannapel
2024-09-27 14:14 ` [PATCH 3/3] dt-bindings: vendor-prefix: Add prefix for Efinix, Inc iansdannapel
0 siblings, 1 reply; 5+ messages in thread
From: iansdannapel @ 2024-09-27 14:14 UTC (permalink / raw)
To: mdf, hao.wu, yilun.xu, trix, robh, krzk+dt, conor+dt,
neil.armstrong, heiko.stuebner, rafal, linus.walleij,
iansdannapel, linux-fpga, devicetree, linux-kernel
From: Ian Dannapel <iansdannapel@gmail.com>
Add a new driver for loading binary firmware to volatile
configuration RAM using "SPI passive programming" on Efinix FPGAs.
Signed-off-by: Ian Dannapel <iansdannapel@gmail.com>
---
drivers/fpga/Kconfig | 10 ++
drivers/fpga/Makefile | 1 +
drivers/fpga/efinix-trion-spi-passive.c | 211 ++++++++++++++++++++++++
3 files changed, 222 insertions(+)
create mode 100644 drivers/fpga/efinix-trion-spi-passive.c
diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index 37b35f58f0df..eb1e44c4e3e0 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -83,6 +83,16 @@ config FPGA_MGR_XILINX_SPI
FPGA manager driver support for Xilinx FPGA configuration
over slave serial interface.
+config FPGA_MGR_EFINIX_SPI
+ tristate "Efinix FPGA configuration over SPI passive"
+ depends on SPI
+ help
+ This option enables support for the FPGA manager driver to
+ configure Efinix Trion and Titanium Series FPGAs over SPI
+ using passive serial mode.
+ Warning: Do not activate this if there are other SPI devices
+ on the same bus as it might interfere with the transmission.
+
config FPGA_MGR_ICE40_SPI
tristate "Lattice iCE40 SPI"
depends on OF && SPI
diff --git a/drivers/fpga/Makefile b/drivers/fpga/Makefile
index aeb89bb13517..1a95124ff847 100644
--- a/drivers/fpga/Makefile
+++ b/drivers/fpga/Makefile
@@ -18,6 +18,7 @@ obj-$(CONFIG_FPGA_MGR_TS73XX) += ts73xx-fpga.o
obj-$(CONFIG_FPGA_MGR_XILINX_CORE) += xilinx-core.o
obj-$(CONFIG_FPGA_MGR_XILINX_SELECTMAP) += xilinx-selectmap.o
obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o
+obj-$(CONFIG_FPGA_MGR_EFINIX_SPI) += efinix-trion-spi-passive.o
obj-$(CONFIG_FPGA_MGR_ZYNQ_FPGA) += zynq-fpga.o
obj-$(CONFIG_FPGA_MGR_ZYNQMP_FPGA) += zynqmp-fpga.o
obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA) += versal-fpga.o
diff --git a/drivers/fpga/efinix-trion-spi-passive.c b/drivers/fpga/efinix-trion-spi-passive.c
new file mode 100644
index 000000000000..87ff645265ca
--- /dev/null
+++ b/drivers/fpga/efinix-trion-spi-passive.c
@@ -0,0 +1,211 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Trion and Titanium Series FPGA SPI Passive Programming Driver
+ *
+ * Copyright (C) 2024 iris-GmbH infrared & intelligent sensors
+ *
+ * Ian Dannapel <iansdannapel@gmail.com>
+ *
+ * Manage Efinix FPGA firmware that is loaded over SPI using
+ * the serial configuration interface.
+ */
+
+#include <linux/delay.h>
+#include <linux/device.h>
+#include <linux/fpga/fpga-mgr.h>
+#include <linux/gpio/consumer.h>
+#include <linux/module.h>
+#include <linux/mod_devicetable.h>
+#include <linux/of.h>
+#include <linux/spi/spi.h>
+#include <linux/sizes.h>
+
+struct efinix_spi_conf {
+ struct spi_device *spi;
+ struct gpio_desc *cdone;
+ struct gpio_desc *creset;
+ struct gpio_desc *cs;
+};
+
+static int efinix_spi_get_cdone_gpio(struct efinix_spi_conf *conf)
+{
+ int ret;
+
+ ret = gpiod_get_value(conf->cdone);
+ return ret;
+}
+
+static void efinix_spi_reset(struct efinix_spi_conf *conf)
+{
+ gpiod_set_value(conf->creset, 1);
+ /* wait tCRESET_N */
+ usleep_range(5, 15);
+ gpiod_set_value(conf->creset, 0);
+}
+
+static enum fpga_mgr_states efinix_spi_state(struct fpga_manager *mgr)
+{
+ struct efinix_spi_conf *conf = mgr->priv;
+
+ if (conf->cdone && efinix_spi_get_cdone_gpio(conf) == 1)
+ return FPGA_MGR_STATE_OPERATING;
+
+ return FPGA_MGR_STATE_UNKNOWN;
+}
+
+static int efinix_spi_apply_clk_cycles(struct efinix_spi_conf *conf)
+{
+ char data[13] = {0};
+
+ return spi_write(conf->spi, data, sizeof(data));
+}
+
+static int efinix_spi_write_init(struct fpga_manager *mgr,
+ struct fpga_image_info *info,
+ const char *buf, size_t count)
+{
+ struct efinix_spi_conf *conf = mgr->priv;
+
+ if (info->flags & FPGA_MGR_PARTIAL_RECONFIG) {
+ dev_err(&mgr->dev, "Partial reconfiguration not supported\n");
+ return -EINVAL;
+ }
+
+ /* reset with chip select active */
+ gpiod_set_value(conf->cs, 1);
+ usleep_range(5, 15);
+ efinix_spi_reset(conf);
+
+ /* wait tDMIN */
+ usleep_range(100, 150);
+
+ return 0;
+}
+
+static int efinix_spi_write(struct fpga_manager *mgr, const char *buf,
+ size_t count)
+{
+ struct efinix_spi_conf *conf = mgr->priv;
+ int ret;
+
+ ret = spi_write(conf->spi, buf, count);
+ if (ret) {
+ dev_err(&mgr->dev, "SPI error in firmware write: %d\n",
+ ret);
+ return ret;
+ }
+
+ return 0;
+}
+
+static int efinix_spi_write_complete(struct fpga_manager *mgr,
+ struct fpga_image_info *info)
+{
+ struct efinix_spi_conf *conf = mgr->priv;
+ unsigned long timeout =
+ jiffies + usecs_to_jiffies(info->config_complete_timeout_us);
+ bool expired = false;
+ int done;
+
+ /* append at least 100 clock cycles */
+ efinix_spi_apply_clk_cycles(conf);
+
+ /* release chip select */
+ gpiod_set_value(conf->cs, 0);
+
+ if (conf->cdone) {
+ while (!expired) {
+ expired = time_after(jiffies, timeout);
+
+ done = efinix_spi_get_cdone_gpio(conf);
+ if (done < 0)
+ return done;
+
+ if (done)
+ break;
+ }
+ }
+
+ if (expired)
+ return -ETIMEDOUT;
+
+ /* wait tUSER */
+ usleep_range(75, 125);
+
+ return 0;
+}
+
+static const struct fpga_manager_ops efinix_spi_ops = {
+ .state = efinix_spi_state,
+ .write_init = efinix_spi_write_init,
+ .write = efinix_spi_write,
+ .write_complete = efinix_spi_write_complete,
+};
+
+static int efinix_spi_probe(struct spi_device *spi)
+{
+ struct efinix_spi_conf *conf;
+ struct fpga_manager *mgr;
+
+ conf = devm_kzalloc(&spi->dev, sizeof(*conf), GFP_KERNEL);
+ if (!conf)
+ return -ENOMEM;
+
+ conf->spi = spi;
+
+ conf->creset = devm_gpiod_get(&spi->dev, "creset", GPIOD_OUT_HIGH);
+ if (IS_ERR(conf->creset))
+ return dev_err_probe(&spi->dev, PTR_ERR(conf->creset),
+ "Failed to get RESET gpio\n");
+
+ conf->cs = devm_gpiod_get(&spi->dev, "cs", GPIOD_OUT_HIGH);
+ if (IS_ERR(conf->cs))
+ return dev_err_probe(&spi->dev, PTR_ERR(conf->cs),
+ "Failed to get CHIP_SELECT gpio\n");
+
+ if (!(spi->mode & SPI_CPHA) || !(spi->mode & SPI_CPOL))
+ return dev_err_probe(&spi->dev, -EINVAL,
+ "Unsupported SPI mode, set CPHA and CPOL\n");
+
+ conf->cdone = devm_gpiod_get_optional(&spi->dev, "cdone", GPIOD_IN);
+ if (IS_ERR(conf->cdone))
+ return dev_err_probe(&spi->dev, PTR_ERR(conf->cdone),
+ "Failed to get CDONE gpio\n");
+
+ mgr = devm_fpga_mgr_register(&spi->dev,
+ "Efinix SPI Passive Programming FPGA Manager",
+ &efinix_spi_ops, conf);
+
+ return PTR_ERR_OR_ZERO(mgr);
+}
+
+#ifdef CONFIG_OF
+static const struct of_device_id efinix_spi_of_match[] = {
+ { .compatible = "efinix,trion-spi-passive", },
+ { .compatible = "efinix,titanium-spi-passive", },
+ {}
+};
+MODULE_DEVICE_TABLE(of, efinix_spi_of_match);
+#endif
+
+static const struct spi_device_id efinix_ids[] = {
+ { "trion-spi-passive", 0 },
+ { "titanium-spi-passive", 0 },
+ {},
+};
+MODULE_DEVICE_TABLE(spi, efinix_ids);
+
+static struct spi_driver efinix_spi_passive_driver = {
+ .driver = {
+ .name = "efinix-fpga-spi-passive",
+ .of_match_table = of_match_ptr(efinix_spi_of_match),
+ },
+ .probe = efinix_spi_probe,
+ .id_table = efinix_ids,
+};
+
+module_spi_driver(efinix_spi_passive_driver);
+
+MODULE_LICENSE("GPL");
+MODULE_AUTHOR("Ian Dannapel <iansdannapel@gmail.com>");
+MODULE_DESCRIPTION("Load Efinix FPGA firmware over SPI passive");
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 3/3] dt-bindings: vendor-prefix: Add prefix for Efinix, Inc.
2024-09-27 14:14 [PATCH 1/3] fpga: Add Efinix Trion & Titanium serial SPI programming driver iansdannapel
@ 2024-09-27 14:14 ` iansdannapel
2024-09-27 14:26 ` Krzysztof Kozlowski
2024-09-30 6:23 ` Alexander Dahl
0 siblings, 2 replies; 5+ messages in thread
From: iansdannapel @ 2024-09-27 14:14 UTC (permalink / raw)
To: mdf, hao.wu, yilun.xu, trix, robh, krzk+dt, conor+dt,
neil.armstrong, heiko.stuebner, rafal, linus.walleij,
iansdannapel, linux-fpga, devicetree, linux-kernel
From: Ian Dannapel <iansdannapel@gmail.com>
Add entry for Efinix, Inc. (https://www.efinixinc.com/)
Signed-off-by: Ian Dannapel <iansdannapel@gmail.com>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index b320a39de7fe..cb92df951fa7 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -430,6 +430,8 @@ patternProperties:
description: Emtop Embedded Solutions
"^eeti,.*":
description: eGalax_eMPIA Technology Inc
+ "^efinix,.*":
+ description: Efinix, Inc.
"^einfochips,.*":
description: Einfochips
"^eink,.*":
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 3/3] dt-bindings: vendor-prefix: Add prefix for Efinix, Inc.
2024-09-27 14:14 ` [PATCH 3/3] dt-bindings: vendor-prefix: Add prefix for Efinix, Inc iansdannapel
@ 2024-09-27 14:26 ` Krzysztof Kozlowski
2024-09-30 6:23 ` Alexander Dahl
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-09-27 14:26 UTC (permalink / raw)
To: iansdannapel, mdf, hao.wu, yilun.xu, trix, robh, krzk+dt,
conor+dt, neil.armstrong, heiko.stuebner, rafal, linus.walleij,
linux-fpga, devicetree, linux-kernel
On 27/09/2024 16:14, iansdannapel@gmail.com wrote:
> From: Ian Dannapel <iansdannapel@gmail.com>
>
> Add entry for Efinix, Inc. (https://www.efinixinc.com/)
>
> Signed-off-by: Ian Dannapel <iansdannapel@gmail.com>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
Wrong order, this is supposed to be before first user.
BTW, same comment for device bindings - entire order is mixed up.
Bindings come before users.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] dt-bindings: vendor-prefix: Add prefix for Efinix, Inc.
2024-09-27 14:14 ` [PATCH 3/3] dt-bindings: vendor-prefix: Add prefix for Efinix, Inc iansdannapel
2024-09-27 14:26 ` Krzysztof Kozlowski
@ 2024-09-30 6:23 ` Alexander Dahl
1 sibling, 0 replies; 5+ messages in thread
From: Alexander Dahl @ 2024-09-30 6:23 UTC (permalink / raw)
To: iansdannapel
Cc: mdf, hao.wu, yilun.xu, trix, robh, krzk+dt, conor+dt,
neil.armstrong, heiko.stuebner, rafal, linus.walleij, linux-fpga,
devicetree, linux-kernel
Hello Ian,
Am Fri, Sep 27, 2024 at 04:14:44PM +0200 schrieb iansdannapel@gmail.com:
> From: Ian Dannapel <iansdannapel@gmail.com>
>
> Add entry for Efinix, Inc. (https://www.efinixinc.com/)
>
> Signed-off-by: Ian Dannapel <iansdannapel@gmail.com>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index b320a39de7fe..cb92df951fa7 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -430,6 +430,8 @@ patternProperties:
> description: Emtop Embedded Solutions
> "^eeti,.*":
> description: eGalax_eMPIA Technology Inc
> + "^efinix,.*":
> + description: Efinix, Inc.
> "^einfochips,.*":
> description: Einfochips
> "^eink,.*":
Acked-by: Alexander Dahl <ada@thorsis.com>
Greets
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-09-30 6:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-20 14:47 [PATCH 3/3] dt-bindings: vendor-prefix: Add prefix for Efinix, Inc iansdannapel
2024-06-20 15:44 ` Conor Dooley
-- strict thread matches above, loose matches on Subject: below --
2024-09-27 14:14 [PATCH 1/3] fpga: Add Efinix Trion & Titanium serial SPI programming driver iansdannapel
2024-09-27 14:14 ` [PATCH 3/3] dt-bindings: vendor-prefix: Add prefix for Efinix, Inc iansdannapel
2024-09-27 14:26 ` Krzysztof Kozlowski
2024-09-30 6:23 ` Alexander Dahl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).