[PATCH 1/3] arm64: dts: rockchip: add SFC support for Radxa ROCK 5B

[PATCH 1/3] arm64: dts: rockchip: add SFC support for Radxa ROCK 5B

[FUKAUMI Naoki]

This commit adds support for SPI NOR flash on Radxa ROCK 5B.

SPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency.

Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index 6a3fd6be1793..966bbc582d89 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -449,6 +449,20 @@ &sdio {
 	status = "okay";
 };
 
+&sfc {
+	pinctrl-names = "default";
+	pinctrl-0 = <&fspim2_pins>;
+	status = "okay";
+
+	flash@0 {
+		compatible = "jedec,spi-nor";
+		reg = <0>;
+		spi-max-frequency = <104000000>;
+		spi-rx-bus-width = <4>;
+		spi-tx-bus-width = <1>;
+	};
+};
+
 &uart6 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart6m1_xfer &uart6m1_ctsn &uart6m1_rtsn>;
-- 
2.43.0

[PATCH 2/3] arm64: dts: rockchip: add (but disabled) SFC node for Radxa ROCK 5A

[FUKAUMI Naoki]

This commit adds SFC node for Radxa ROCK 5A.

since sdhci and sfc on RK3588s share pins(i.e. exclusive), it cannot
be enabled both nodes at the same time. so status = "okay" is omitted
here.

you may be able to enable sfc (and disable sdhci) by fdt overlay.

SPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency.

Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
index c0f6a4b1493f..03ed48246d36 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
@@ -377,6 +377,19 @@ &sdmmc {
 	status = "okay";
 };
 
+&sfc {
+	pinctrl-names = "default";
+	pinctrl-0 = <&fspim0_pins>;
+
+	flash@0 {
+		compatible = "jedec,spi-nor";
+		reg = <0>;
+		spi-max-frequency = <104000000>;
+		spi-rx-bus-width = <4>;
+		spi-tx-bus-width = <1>;
+	};
+};
+
 &spi2 {
 	status = "okay";
 	assigned-clocks = <&cru CLK_SPI2>;
-- 
2.43.0

[PATCH 3/3] arm64: dts: rockchip: change spi-max-frequency for Radxa ROCK 3C

[FUKAUMI Naoki]

SPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency.

Fixes: ee219017ddb5 ("arm64: dts: rockchip: Add Radxa ROCK 3C")
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts b/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts
index b242409d378c..f2cc086e5001 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts
@@ -633,7 +633,7 @@ &sfc {
 	flash@0 {
 		compatible = "jedec,spi-nor";
 		reg = <0x0>;
-		spi-max-frequency = <120000000>;
+		spi-max-frequency = <104000000>;
 		spi-rx-bus-width = <4>;
 		spi-tx-bus-width = <1>;
 	};
-- 
2.43.0

Re: [PATCH 3/3] arm64: dts: rockchip: change spi-max-frequency for Radxa ROCK 3C

[Chukun Pan]

Hi, 
> SPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency.

I don't think a fixes tag is needed, because there is no documentation
for this. See also (sfc part):
https://lore.kernel.org/lkml/d7de2213-8dd2-42ec-9a30-a569ac71be3e@kwiboo.se/

>
> Fixes: ee219017ddb5 ("arm64: dts: rockchip: Add Radxa ROCK 3C")
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>

Thanks,
Chukun

-- 
2.25.1

Re: [PATCH 3/3] arm64: dts: rockchip: change spi-max-frequency for Radxa ROCK 3C

[FUKAUMI Naoki]

Hi,

Thank you very much for your comment!

On 6/23/24 13:04, Chukun Pan wrote:
> Hi,
>> SPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency.
> 
> I don't think a fixes tag is needed, because there is no documentation
> for this. See also (sfc part):
> https://lore.kernel.org/lkml/d7de2213-8dd2-42ec-9a30-a569ac71be3e@kwiboo.se/

I see, I'll remove fixes tag in v2.
btw, is this change reasonable(acceptable)?

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

>>
>> Fixes: ee219017ddb5 ("arm64: dts: rockchip: Add Radxa ROCK 3C")
>> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> 
> Thanks,
> Chukun
> 

Re: [PATCH 3/3] arm64: dts: rockchip: change spi-max-frequency for Radxa ROCK 3C

[Chukun Pan]

Hi,
> I see, I'll remove fixes tag in v2.
> btw, is this change reasonable(acceptable)?

I think there's no problem and it's acceptable. It would be better
if you could give examples of flash chips that might be used.

Thanks,
Chukun

-- 
2.25.1

Re: [PATCH 3/3] arm64: dts: rockchip: change spi-max-frequency for Radxa ROCK 3C

[Heiko Stübner]

Am Sonntag, 23. Juni 2024, 06:24:56 CEST schrieb FUKAUMI Naoki:
> Hi,
> 
> Thank you very much for your comment!
> 
> On 6/23/24 13:04, Chukun Pan wrote:
> > Hi,
> >> SPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency.
> > 
> > I don't think a fixes tag is needed, because there is no documentation
> > for this. See also (sfc part):
> > https://lore.kernel.org/lkml/d7de2213-8dd2-42ec-9a30-a569ac71be3e@kwiboo.se/
> 
> I see, I'll remove fixes tag in v2.
> btw, is this change reasonable(acceptable)?

it is, also no need to resend, I just dropped the Fixes tag myself

Re: [PATCH 1/3] arm64: dts: rockchip: add SFC support for Radxa ROCK 5B

[Heiko Stuebner]

On Sun, 23 Jun 2024 11:33:27 +0900, FUKAUMI Naoki wrote:
> This commit adds support for SPI NOR flash on Radxa ROCK 5B.
> 
> SPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency.
> 
> 

Applied, thanks!

[1/3] arm64: dts: rockchip: add SFC support for Radxa ROCK 5B
      commit: 9204a7ecca96403ee3d61c14cb9eb87ec89b0fcd
[2/3] arm64: dts: rockchip: add (but disabled) SFC node for Radxa ROCK 5A
      commit: 00224650dd45e166ea6eb1593f5f064583963ccf
[3/3] arm64: dts: rockchip: change spi-max-frequency for Radxa ROCK 3C
      commit: 06f6dd4d607766a527e37529f2f3f90dd1464293

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

Re: [PATCH 3/3] arm64: dts: rockchip: change spi-max-frequency for Radxa ROCK 3C

[FUKAUMI Naoki]

Hi,

On 6/24/24 19:00, Chukun Pan wrote:
> Hi,
>> I see, I'll remove fixes tag in v2.
>> btw, is this change reasonable(acceptable)?
> 
> I think there's no problem and it's acceptable. It would be better
> if you could give examples of flash chips that might be used.

here is a list of my board:

  ROCK 5A: MXIC (SPI flash module, no schematic)
  ROCK 5B: MXIC (XTX in schematic)
  ROCK 3A: MXIC (Winbond in schematic)
  ROCK 3B: MXIC (Winbond in schematic)
  ROCK 3C: GigaDevice (same as schematic)

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

> Thanks,
> Chukun
>