From: Jonathan Cameron <jic23@kernel.org>
To: Kaustabh Chakraborty <kauschluss@disroot.org>
Cc: linux-iio@vger.kernel.org, denis.ciocca@st.com,
devicetree@vger.kernel.org, linus.walleij@linaro.org,
robh+dt@kernel.org
Subject: Re: [PATCH v5 2/2] dt-bindings: iio: st-sensors: add LIS2DS12 accelerometer
Date: Sun, 23 Jun 2024 11:03:05 +0100 [thread overview]
Message-ID: <20240623110305.5d961052@jic23-huawei> (raw)
In-Reply-To: <20240622123520.39253-2-kauschluss@disroot.org>
On Sat, 22 Jun 2024 18:03:46 +0530
Kaustabh Chakraborty <kauschluss@disroot.org> wrote:
> LIS2DS12 is an accelerometer by STMicroelectronics. It is identifiable by
> its WhoAmI value 0x43.
>
> Its register interface is not compatible with existing parts. For example:
>
> - The full-scale values are present in register 0x20, in bits 2 and 3
> (mask 0x0c). Most other supported sensors have the register address set
> to 0x21, 0x23, 0x24, or 0x25. There is one sensor setting though
> (bearing WhoAmI 0x3b) which has it's address set to 0x20, but the mask is
> set to 0x20, not 0x0c.
>
> - The full-scale values 2G, 4G, 8G, and 16G correspond to the register
> values 0x00, 0x02, 0x03, 0x01 respectively. None of the sensor settings
> have the value 0x01 associated with 16G.
>
> Add the compatible string without any fallback.
>
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
Given the only requested change was this description and everyone seemed
happy with it in previous thread, I'll pick this series up now.
Note that I can still add any tags that come in as it'll only be
pushed out as testing for the next few days.
Applied to the togreg branch of iio.git and pushed out as testing to
let 0-day have a first go at seeing what we missed.
I made one tweak in patch 1 description. Datasheet is a tag
so no blank line between that and the main tags block as it
will break some automation.
> ---
> Documentation/devicetree/bindings/iio/st,st-sensors.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
> index fff7e3d83a02..71c1ee33a393 100644
> --- a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
> +++ b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
> @@ -26,6 +26,7 @@ properties:
> - st,lis2dw12
> - st,lis2hh12
> - st,lis2dh12-accel
> + - st,lis2ds12
> - st,lis302dl
> - st,lis331dl-accel
> - st,lis331dlh-accel
next prev parent reply other threads:[~2024-06-23 10:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 12:33 [PATCH v5 1/2] iio: accel: st_accel: add support for LIS2DS12 Kaustabh Chakraborty
2024-06-22 12:33 ` [PATCH v5 2/2] dt-bindings: iio: st-sensors: add LIS2DS12 accelerometer Kaustabh Chakraborty
2024-06-23 10:03 ` Jonathan Cameron [this message]
2024-06-23 14:30 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240623110305.5d961052@jic23-huawei \
--to=jic23@kernel.org \
--cc=denis.ciocca@st.com \
--cc=devicetree@vger.kernel.org \
--cc=kauschluss@disroot.org \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).