devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: George Chan via B4 Relay <devnull+gchan9527.gmail.com@kernel.org>
To: Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
	 Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	cros-qcom-dts-watchers@chromium.org,
	 Bjorn Andersson <andersson@kernel.org>,
	 Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	 George Chan <gchan9527@gmail.com>
Subject: [PATCH v2 7/8] Add debug log info to vfe block init and set clock rate
Date: Mon, 24 Jun 2024 07:22:46 +0800	[thread overview]
Message-ID: <20240624-b4-sc7180-camss-v2-7-0dfecdc50073@gmail.com> (raw)
In-Reply-To: <20240624-b4-sc7180-camss-v2-0-0dfecdc50073@gmail.com>

From: George Chan <gchan9527@gmail.com>

Print out missing clock's name when doing msm_vfe_subdev_init().
Also print out min clock rate required at vfe_set_clock_rates().

Signed-off-by: George Chan <gchan9527@gmail.com>
---
 drivers/media/platform/qcom/camss/camss-vfe.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
index 05fa1adc1661..fbbf38755c0e 100644
--- a/drivers/media/platform/qcom/camss/camss-vfe.c
+++ b/drivers/media/platform/qcom/camss/camss-vfe.c
@@ -579,7 +579,8 @@ static int vfe_set_clock_rates(struct vfe_device *vfe)
 
 			if (j == clock->nfreqs) {
 				dev_err(dev,
-					"Pixel clock is too high for VFE");
+					"Pixel clock(%s) is too high for VFE, at least set to %lld",
+					 clock->name, min_rate);
 				return -EINVAL;
 			}
 
@@ -1452,8 +1453,10 @@ int msm_vfe_subdev_init(struct camss *camss, struct vfe_device *vfe,
 		struct camss_clock *clock = &vfe->clock[i];
 
 		clock->clk = devm_clk_get(dev, res->clock[i]);
-		if (IS_ERR(clock->clk))
+		if (IS_ERR(clock->clk)) {
+			dev_err(dev, "missing clk %s", res->clock[i]);
 			return PTR_ERR(clock->clk);
+		}
 
 		clock->name = res->clock[i];
 

-- 
2.34.1



  parent reply	other threads:[~2024-06-23 23:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-23 23:22 [PATCH v2 0/8] Add sc7180 camss subsys support George Chan via B4 Relay
2024-06-23 23:22 ` [PATCH v2 1/8] Add qcom,sc7180-camss George Chan via B4 Relay
2024-06-24  4:55   ` Krzysztof Kozlowski
2024-06-23 23:22 ` [PATCH v2 2/8] Add Gen2 v1.2.2 two-phase MIPI CSI-2 DPHY init George Chan via B4 Relay
2024-06-23 23:22 ` [PATCH v2 3/8] Add sc7180 support George Chan via B4 Relay
2024-06-23 23:22 ` [PATCH v2 4/8] Add sc7180 resources George Chan via B4 Relay
2024-06-23 23:22 ` [PATCH v2 5/8] Add debug log info to camss_enable_clocks function George Chan via B4 Relay
2024-06-24 10:07   ` Bryan O'Donoghue
2024-06-23 23:22 ` [PATCH v2 6/8] Add debug log info to msm_csid_subdev_init function George Chan via B4 Relay
2024-06-24 10:08   ` Bryan O'Donoghue
2024-06-24 10:19     ` Krzysztof Kozlowski
2024-06-23 23:22 ` George Chan via B4 Relay [this message]
2024-06-24 10:15   ` [PATCH v2 7/8] Add debug log info to vfe block init and set clock rate Bryan O'Donoghue
2024-06-23 23:22 ` [PATCH RFT v2 8/8] Add support for sc7180 camss subsys George Chan via B4 Relay
2024-06-24  4:55   ` Krzysztof Kozlowski
2024-06-24  4:54 ` [PATCH v2 0/8] Add sc7180 camss subsys support Krzysztof Kozlowski
2024-06-24 10:05 ` Bryan O'Donoghue
2024-06-24 12:07   ` george chan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240624-b4-sc7180-camss-v2-7-0dfecdc50073@gmail.com \
    --to=devnull+gchan9527.gmail.com@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gchan9527@gmail.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=todor.too@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).