* [PATCH] arm64: dts: amlogic: ad402: fix thermal zone node name
@ 2024-06-24 8:59 Neil Armstrong
2024-06-24 9:28 ` Krzysztof Kozlowski
2024-06-24 9:46 ` Neil Armstrong
0 siblings, 2 replies; 6+ messages in thread
From: Neil Armstrong @ 2024-06-24 8:59 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Dmitry Rokosov
Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel,
Neil Armstrong
Fixes the following:
thermal-zones: 'soc_thermal' does not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml#
Fixes: 593ab951232b ("arm64: dts: amlogic: ad402: setup thermal-zones")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts
index 6883471a93b4..0d92f5253b64 100644
--- a/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts
@@ -86,7 +86,7 @@ vddio_1v8: regulator-vddio-1v8 {
};
thermal-zones {
- soc_thermal: soc_thermal {
+ soc_thermal: soc-thermal {
polling-delay = <1000>;
polling-delay-passive = <100>;
sustainable-power = <130>;
---
base-commit: 202661addeb4130fbd99075ab7b4f5290a692542
change-id: 20240624-topic-amlogic-upstream-bindings-fixes-dts-round-2-5ca9b1193bff
Best regards,
--
Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: amlogic: ad402: fix thermal zone node name
2024-06-24 8:59 [PATCH] arm64: dts: amlogic: ad402: fix thermal zone node name Neil Armstrong
@ 2024-06-24 9:28 ` Krzysztof Kozlowski
2024-06-24 9:45 ` Neil Armstrong
2024-06-24 9:46 ` Neil Armstrong
1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-24 9:28 UTC (permalink / raw)
To: Neil Armstrong, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl, Dmitry Rokosov
Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
On 24/06/2024 10:59, Neil Armstrong wrote:
> Fixes the following:
> thermal-zones: 'soc_thermal' does not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml#
>
> Fixes: 593ab951232b ("arm64: dts: amlogic: ad402: setup thermal-zones")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts
> index 6883471a93b4..0d92f5253b64 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts
> @@ -86,7 +86,7 @@ vddio_1v8: regulator-vddio-1v8 {
> };
>
> thermal-zones {
> - soc_thermal: soc_thermal {
> + soc_thermal: soc-thermal {
I was fixing all underscores... but then mentioned above commit
re-introduced them.
Some fixes need to be done more than once to stick. :)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: amlogic: ad402: fix thermal zone node name
2024-06-24 9:28 ` Krzysztof Kozlowski
@ 2024-06-24 9:45 ` Neil Armstrong
2024-06-25 9:53 ` Dmitry Rokosov
0 siblings, 1 reply; 6+ messages in thread
From: Neil Armstrong @ 2024-06-24 9:45 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
Dmitry Rokosov
Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
On 24/06/2024 11:28, Krzysztof Kozlowski wrote:
> On 24/06/2024 10:59, Neil Armstrong wrote:
>> Fixes the following:
>> thermal-zones: 'soc_thermal' does not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'
>> from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml#
>>
>> Fixes: 593ab951232b ("arm64: dts: amlogic: ad402: setup thermal-zones")
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts
>> index 6883471a93b4..0d92f5253b64 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts
>> @@ -86,7 +86,7 @@ vddio_1v8: regulator-vddio-1v8 {
>> };
>>
>> thermal-zones {
>> - soc_thermal: soc_thermal {
>> + soc_thermal: soc-thermal {
>
> I was fixing all underscores... but then mentioned above commit
> re-introduced them.
Sorry about that, I'm removing all dtbs check errors, so I'll be able to spot
this before merging anything now !
>
> Some fixes need to be done more than once to stick. :)
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >
> Best regards,
> Krzysztof
>
Thanks,
Neil
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: amlogic: ad402: fix thermal zone node name
2024-06-24 9:45 ` Neil Armstrong
@ 2024-06-25 9:53 ` Dmitry Rokosov
2024-06-25 9:55 ` Neil Armstrong
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Rokosov @ 2024-06-25 9:53 UTC (permalink / raw)
To: Neil Armstrong
Cc: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
Hello Neil and Krzysztof,
Before posting any commit I've running dt_binding_check and dtbs_check.
Which target should highlight the errors like mentioned in this fix?
Please advise what I'm doing wrong.
My commands:
$ /usr/bin/make ARCH=arm64 INSTALL_MOD_PATH=$ROOT/out/$TARGET/target CROSS_COMPILE="$ROOT/out/$TARGET/host/bin/aarch64-buildroot-linux-gnu-" DEPMOD=$ROOT/out/$TARGET/host/sbin/depmod INSTALL_MOD_STRIP=1 -C $ROOT/out/$TARGET/build/linux-custom dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/example_device.yaml
$ /usr/bin/make ARCH=arm64 INSTALL_MOD_PATH=$ROOT/out/$TARGET/target CROSS_COMPILE="$ROOT/out/$TARGET/host/bin/aarch64-buildroot-linux-gnu-" DEPMOD=$ROOT/out/$TARGET/host/sbin/depmod INSTALL_MOD_STRIP=1 -C $ROOT/out/$TARGET/build/linux-custom dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/example_device.yaml
On Mon, Jun 24, 2024 at 11:45:51AM +0200, Neil Armstrong wrote:
> On 24/06/2024 11:28, Krzysztof Kozlowski wrote:
> > On 24/06/2024 10:59, Neil Armstrong wrote:
> > > Fixes the following:
> > > thermal-zones: 'soc_thermal' does not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'
> > > from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml#
> > >
> > > Fixes: 593ab951232b ("arm64: dts: amlogic: ad402: setup thermal-zones")
> > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> > > ---
> > > arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts
> > > index 6883471a93b4..0d92f5253b64 100644
> > > --- a/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts
> > > +++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts
> > > @@ -86,7 +86,7 @@ vddio_1v8: regulator-vddio-1v8 {
> > > };
> > > thermal-zones {
> > > - soc_thermal: soc_thermal {
> > > + soc_thermal: soc-thermal {
> >
> > I was fixing all underscores... but then mentioned above commit
> > re-introduced them.
>
> Sorry about that, I'm removing all dtbs check errors, so I'll be able to spot
> this before merging anything now !
>
> >
> > Some fixes need to be done more than once to stick. :)
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >
> > Best regards,
> > Krzysztof
> >
>
> Thanks,
> Neil
--
Thank you,
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: amlogic: ad402: fix thermal zone node name
2024-06-25 9:53 ` Dmitry Rokosov
@ 2024-06-25 9:55 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2024-06-25 9:55 UTC (permalink / raw)
To: Dmitry Rokosov
Cc: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
On 25/06/2024 11:53, Dmitry Rokosov wrote:
> Hello Neil and Krzysztof,
>
> Before posting any commit I've running dt_binding_check and dtbs_check.
> Which target should highlight the errors like mentioned in this fix?
> Please advise what I'm doing wrong.
>
> My commands:
>
> $ /usr/bin/make ARCH=arm64 INSTALL_MOD_PATH=$ROOT/out/$TARGET/target CROSS_COMPILE="$ROOT/out/$TARGET/host/bin/aarch64-buildroot-linux-gnu-" DEPMOD=$ROOT/out/$TARGET/host/sbin/depmod INSTALL_MOD_STRIP=1 -C $ROOT/out/$TARGET/build/linux-custom dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/example_device.yaml
> $ /usr/bin/make ARCH=arm64 INSTALL_MOD_PATH=$ROOT/out/$TARGET/target CROSS_COMPILE="$ROOT/out/$TARGET/host/bin/aarch64-buildroot-linux-gnu-" DEPMOD=$ROOT/out/$TARGET/host/sbin/depmod INSTALL_MOD_STRIP=1 -C $ROOT/out/$TARGET/build/linux-custom dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/example_device.yaml
Thus should work, but I use:
make ARCH=arm64 DTBS_CHECK=y $(cd arch/arm64/boot/dts; find amlogic/ -name "*.dts" | sed "s/dts/dtb/")
to only check amlogic dtbs.
Neil
>
> On Mon, Jun 24, 2024 at 11:45:51AM +0200, Neil Armstrong wrote:
>> On 24/06/2024 11:28, Krzysztof Kozlowski wrote:
>>> On 24/06/2024 10:59, Neil Armstrong wrote:
>>>> Fixes the following:
>>>> thermal-zones: 'soc_thermal' does not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'
>>>> from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml#
>>>>
>>>> Fixes: 593ab951232b ("arm64: dts: amlogic: ad402: setup thermal-zones")
>>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>>> ---
>>>> arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts
>>>> index 6883471a93b4..0d92f5253b64 100644
>>>> --- a/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts
>>>> +++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts
>>>> @@ -86,7 +86,7 @@ vddio_1v8: regulator-vddio-1v8 {
>>>> };
>>>> thermal-zones {
>>>> - soc_thermal: soc_thermal {
>>>> + soc_thermal: soc-thermal {
>>>
>>> I was fixing all underscores... but then mentioned above commit
>>> re-introduced them.
>>
>> Sorry about that, I'm removing all dtbs check errors, so I'll be able to spot
>> this before merging anything now !
>>
>>>
>>> Some fixes need to be done more than once to stick. :)
>>>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >
>>> Best regards,
>>> Krzysztof
>>>
>>
>> Thanks,
>> Neil
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: amlogic: ad402: fix thermal zone node name
2024-06-24 8:59 [PATCH] arm64: dts: amlogic: ad402: fix thermal zone node name Neil Armstrong
2024-06-24 9:28 ` Krzysztof Kozlowski
@ 2024-06-24 9:46 ` Neil Armstrong
1 sibling, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2024-06-24 9:46 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Dmitry Rokosov,
Neil Armstrong
Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
Hi,
On Mon, 24 Jun 2024 10:59:36 +0200, Neil Armstrong wrote:
> Fixes the following:
> thermal-zones: 'soc_thermal' does not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml#
>
>
Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.11/arm64-dt)
[1/1] arm64: dts: amlogic: ad402: fix thermal zone node name
https://git.kernel.org/amlogic/c/ca88b172eebfaa923ea752f6eb41ec5c9cb587c5
These changes has been applied on the intermediate git tree [1].
The v6.11/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.
In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].
The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.
If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
--
Neil
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-06-25 9:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-24 8:59 [PATCH] arm64: dts: amlogic: ad402: fix thermal zone node name Neil Armstrong
2024-06-24 9:28 ` Krzysztof Kozlowski
2024-06-24 9:45 ` Neil Armstrong
2024-06-25 9:53 ` Dmitry Rokosov
2024-06-25 9:55 ` Neil Armstrong
2024-06-24 9:46 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).