From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47FC118C05 for ; Mon, 24 Jun 2024 05:29:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719206964; cv=none; b=BCwDzH4S3rrMVOw9OedkV+MyfauDQbjeJraZRrSOQcCGcqGORXig86Fni2wmZQnqhblNYb8HXLBcIG5UBlduSgdhDO6UwQSfE/dlSA30gpICGBElsNcwiKAL8NVo+qbktoH1obfBDV66k5ImN0hDOwleC8KQYBsrBa+9tuDn79k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719206964; c=relaxed/simple; bh=50twyfEJ8ALTho3pL+ku6E2q/cus4h8CQVXWkBsgJ4o=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ejo/FTGh20+0U/kC6moMrwmlFkFMfGdda12sxmltxpKbNMZ75e8Z0Ia+KarTw9tn4zfu8HNND5tKZ/xBdU0VpcxMaK0pYdChNozeX80j1icos3PljA7BBMmpSbEXWwrPXRZlsT6n335MBAe8g+nvAh2QAPCkt++E+k2hU1bVjM0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Y5iseQFR; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Y5iseQFR" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-df771b5e942so7329552276.2 for ; Sun, 23 Jun 2024 22:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719206962; x=1719811762; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=P1I8I99l7a+8VVN3a7Xt/piq3f28W3MFZ3VnliaJyPU=; b=Y5iseQFRU1iKk+YleCi7794DESJI6bmBUHk0J+kVJ2aoxLqJJb0U/sxiQhzriiZsM4 FXgnWCKy/cwa7O70CGqcDjMAGuO4fXLKYSUL8+zREOivnsn7FPQfjgWMeq7Jx8nCOOOv GtjxFzrCrPWmIEU4bqRm7jSdVTXPTOlo21/1B5WVJWFREvr9lq3xgZvtj64aBXvXUhYE EuV7HqhsCXVzoCStfQVJDLxv2abbOUKqxSm4AR6JbWJ2szgOBuiL2B+3Ey8ArPByDsQw 6IaOLegT93Oxw+Jx8hI+sGHLXQJBPkSXpCbWbITvUqMlBSMq3WZdv8K1DgWB6a3QEE/W Hsdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719206962; x=1719811762; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P1I8I99l7a+8VVN3a7Xt/piq3f28W3MFZ3VnliaJyPU=; b=MkEn7HLHXadIv3DxWezkzpnFgOWq/nJUsnRtAidYHiCk9Xcr3ddUg2m6jHSp3icQqu n7nhEbF4fcoUJ9RBzTPyPP9AeV2On4Z9h92X8reY9jcAgGTzglLYQM35GiKAvh4jYkqQ URR6BjwRxSmFgQ4+GYfAnahGqjR4na6+D86WlNs3qqCoZ9yc/TOcwbYXbCP8DfLyhkTM pqFBhrzOPyneQGe7c+tvFwUX8xg7KPWmofWXIKPRWgLStJNGOXsv/o7kseY56qaDKEnz eQkgyuGb/azaD6gRxJTBdzJSg5GNEdMI/+0XaBKa4gmHR856YoKYgekr9pFDItFTyGoJ UqVA== X-Forwarded-Encrypted: i=1; AJvYcCVtfiq7FolLWF3lIRrw5VrjA0twq3MqY9XL5ze3HQAf9k43xhmtLTnDtOLoMi5PC9FresKZkzI2smkBX26VeD+4TCqMtmm2l4Ti+w== X-Gm-Message-State: AOJu0Yxt9LPmN3GrTKhS+wVxhncW/Y7ER7EqRocfWDUSii5mC3A6vkjh 8kzcu+2u3LJuaYw10JMx2+VFyZ+YogzZR73o0r9Oi+xmjDhz/rfHU187YnzxQ/bjXS2qC9skHaD Q2tJ3JTe45Jw8ySXdR5360bV5eg== X-Google-Smtp-Source: AGHT+IFYTSVOMsLqJVDUxHQ8GFvdZHqCOqKjAi9xCBAxDVenSvN+E7dc9z9/aa2vq33ZomTzPFE3OUf1TIIi5BohR5k= X-Received: from aniketm.c.googlers.com ([fda3:e722:ac3:cc00:4f:4b78:c0a8:3387]) (user=aniketmaurya job=sendgmr) by 2002:a05:6902:1146:b0:e02:c619:732 with SMTP id 3f1490d57ef6-e0301098e9emr11043276.8.1719206962420; Sun, 23 Jun 2024 22:29:22 -0700 (PDT) Date: Mon, 24 Jun 2024 05:28:51 +0000 In-Reply-To: <20240624052851.1030799-1-aniketmaurya@google.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240611171600.1105124-1-aniketmaurya@google.com> <20240624052851.1030799-1-aniketmaurya@google.com> X-Mailer: git-send-email 2.45.2.741.gdbec12cfda-goog Message-ID: <20240624052851.1030799-4-aniketmaurya@google.com> Subject: [PATCH v2 3/3] i3c: dw: Use new *_enabled clk APIs From: Aniket To: Alexandre Belloni , Jeremy Kerr , Joel Stanley , Billy Tsai , Rob Herring , Krzysztof Kozlowski Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Aniket Content-Type: text/plain; charset="UTF-8" Move to "enabled" variant of clk_get APIs. It takes care of enable and disable calls during the probe and remove. Signed-off-by: Aniket --- drivers/i3c/master/dw-i3c-master.c | 21 ++------------------- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c index 41cdfd6741e3..37092b8e964f 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -1466,11 +1466,11 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, if (IS_ERR(master->regs)) return PTR_ERR(master->regs); - master->core_clk = devm_clk_get(&pdev->dev, NULL); + master->core_clk = devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(master->core_clk)) return PTR_ERR(master->core_clk); - master->pclk = devm_clk_get_optional(&pdev->dev, "pclk"); + master->pclk = devm_clk_get_optional_enabled(&pdev->dev, "pclk"); if (IS_ERR(master->pclk)) return PTR_ERR(master->pclk); @@ -1479,14 +1479,6 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, if (IS_ERR(master->core_rst)) return PTR_ERR(master->core_rst); - ret = clk_prepare_enable(master->core_clk); - if (ret) - return ret; - - ret = clk_prepare_enable(master->pclk); - if (ret) - goto err_disable_core_clk; - reset_control_deassert(master->core_rst); spin_lock_init(&master->xferqueue.lock); @@ -1528,11 +1520,6 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, err_assert_rst: reset_control_assert(master->core_rst); - clk_disable_unprepare(master->pclk); - -err_disable_core_clk: - clk_disable_unprepare(master->core_clk); - return ret; } EXPORT_SYMBOL_GPL(dw_i3c_common_probe); @@ -1542,10 +1529,6 @@ void dw_i3c_common_remove(struct dw_i3c_master *master) i3c_master_unregister(&master->base); reset_control_assert(master->core_rst); - - clk_disable_unprepare(master->pclk); - - clk_disable_unprepare(master->core_clk); } EXPORT_SYMBOL_GPL(dw_i3c_common_remove); -- 2.45.2.741.gdbec12cfda-goog