devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: PCI: layerscape-pci: Fix property 'fsl,pcie-scfg' type
@ 2024-06-25 21:17 Frank Li
  2024-06-25 21:17 ` [PATCH 2/2] dt-bindings: PCI: layerscape-pci-ep: Allow fallback to fsl,ls-pcie-ep Frank Li
  0 siblings, 1 reply; 3+ messages in thread
From: Frank Li @ 2024-06-25 21:17 UTC (permalink / raw)
  To: Bjorn Helgaas, Lorenzo Pieralisi, Krzysztof Wilczyński,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	open list:PCI SUBSYSTEM,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list
  Cc: imx

fsl,pcie-scfg actually need an argument when there are more than one PCIe
instances. Change it to phandle-array and use items to descript each field
means.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 .../devicetree/bindings/pci/fsl,layerscape-pcie.yaml      | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml
index 793986c5af7ff..679c2989de7a2 100644
--- a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml
@@ -43,10 +43,16 @@ properties:
       - const: config
 
   fsl,pcie-scfg:
-    $ref: /schemas/types.yaml#/definitions/phandle
+    $ref: /schemas/types.yaml#/definitions/phandle-array
     description: A phandle to the SCFG device node. The second entry is the
       physical PCIe controller index starting from '0'. This is used to get
       SCFG PEXN registers.
+    items:
+      items:
+        - description: A phandle to the SCFG device node
+        - description: PCIe controller index starting from '0'
+      minItems: 1
+    maxItems: 1
 
   big-endian:
     $ref: /schemas/types.yaml#/definitions/flag
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] dt-bindings: PCI: layerscape-pci-ep: Allow fallback to fsl,ls-pcie-ep
  2024-06-25 21:17 [PATCH 1/2] dt-bindings: PCI: layerscape-pci: Fix property 'fsl,pcie-scfg' type Frank Li
@ 2024-06-25 21:17 ` Frank Li
  2024-06-25 22:08   ` Frank Li
  0 siblings, 1 reply; 3+ messages in thread
From: Frank Li @ 2024-06-25 21:17 UTC (permalink / raw)
  To: Lorenzo Pieralisi, Krzysztof Wilczyński, Rob Herring,
	Bjorn Helgaas, Krzysztof Kozlowski, Conor Dooley,
	open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list
  Cc: imx

Allow compatible string fallback to general fsl,ls-pcie-ep.
Fix below warning:

arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dtb: pcie_ep@3400000: compatible: ['fsl,ls1046a-pcie-ep', 'fsl,ls-pcie-ep'] is too long

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 .../bindings/pci/fsl,layerscape-pcie-ep.yaml      | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
index 399efa7364c93..21f1edfe814d4 100644
--- a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
+++ b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
@@ -22,12 +22,15 @@ description:
 
 properties:
   compatible:
-    enum:
-      - fsl,ls2088a-pcie-ep
-      - fsl,ls1088a-pcie-ep
-      - fsl,ls1046a-pcie-ep
-      - fsl,ls1028a-pcie-ep
-      - fsl,lx2160ar2-pcie-ep
+    items:
+      - enum:
+          - fsl,ls2088a-pcie-ep
+          - fsl,ls1088a-pcie-ep
+          - fsl,ls1046a-pcie-ep
+          - fsl,ls1028a-pcie-ep
+          - fsl,lx2160ar2-pcie-ep
+      - const: fsl,ls-pcie-ep
+    minItems: 1
 
   reg:
     maxItems: 2
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/2] dt-bindings: PCI: layerscape-pci-ep: Allow fallback to fsl,ls-pcie-ep
  2024-06-25 21:17 ` [PATCH 2/2] dt-bindings: PCI: layerscape-pci-ep: Allow fallback to fsl,ls-pcie-ep Frank Li
@ 2024-06-25 22:08   ` Frank Li
  0 siblings, 0 replies; 3+ messages in thread
From: Frank Li @ 2024-06-25 22:08 UTC (permalink / raw)
  To: Lorenzo Pieralisi, Krzysztof Wilczyński, Rob Herring,
	Bjorn Helgaas, Krzysztof Kozlowski, Conor Dooley,
	open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list
  Cc: imx

On Tue, Jun 25, 2024 at 05:17:47PM -0400, Frank Li wrote:
> Allow compatible string fallback to general fsl,ls-pcie-ep.
> Fix below warning:
> 
> arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dtb: pcie_ep@3400000: compatible: ['fsl,ls1046a-pcie-ep', 'fsl,ls-pcie-ep'] is too long
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---

Sorry, this patch sent out accidently. 'fsl,ls-pcie-ep' actually are
not used in driver.

Frank Li

>  .../bindings/pci/fsl,layerscape-pcie-ep.yaml      | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> index 399efa7364c93..21f1edfe814d4 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> @@ -22,12 +22,15 @@ description:
>  
>  properties:
>    compatible:
> -    enum:
> -      - fsl,ls2088a-pcie-ep
> -      - fsl,ls1088a-pcie-ep
> -      - fsl,ls1046a-pcie-ep
> -      - fsl,ls1028a-pcie-ep
> -      - fsl,lx2160ar2-pcie-ep
> +    items:
> +      - enum:
> +          - fsl,ls2088a-pcie-ep
> +          - fsl,ls1088a-pcie-ep
> +          - fsl,ls1046a-pcie-ep
> +          - fsl,ls1028a-pcie-ep
> +          - fsl,lx2160ar2-pcie-ep
> +      - const: fsl,ls-pcie-ep
> +    minItems: 1
>  
>    reg:
>      maxItems: 2
> -- 
> 2.34.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-06-25 22:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-25 21:17 [PATCH 1/2] dt-bindings: PCI: layerscape-pci: Fix property 'fsl,pcie-scfg' type Frank Li
2024-06-25 21:17 ` [PATCH 2/2] dt-bindings: PCI: layerscape-pci-ep: Allow fallback to fsl,ls-pcie-ep Frank Li
2024-06-25 22:08   ` Frank Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).