* [PATCH] dt-bindings: display/msm/gmu: fix the schema being not applied
@ 2024-06-23 12:59 Krzysztof Kozlowski
2024-06-25 22:51 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-23 12:59 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
Cc: Krzysztof Kozlowski, Akhil P Oommen
dtschema v2024.4, v2024.5 and maybe earlier do not select device nodes for
given binding validation if the schema contains compatible list with
pattern and a const fallback. This leads to binding being a no-op - not
being applied at all. Issue should be fixed in the dtschema but for now
add a work-around do the binding can be used against DTS validation.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Akhil P Oommen <quic_akhilpo@quicinc.com>
---
.../devicetree/bindings/display/msm/gmu.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings/display/msm/gmu.yaml
index b3837368a260..8d1b515f59ec 100644
--- a/Documentation/devicetree/bindings/display/msm/gmu.yaml
+++ b/Documentation/devicetree/bindings/display/msm/gmu.yaml
@@ -17,6 +17,18 @@ description: |
management and support to improve power efficiency and reduce the load on
the CPU.
+# dtschema does not select nodes based on pattern+const, so add custom select
+# as a work-around:
+select:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,adreno-gmu
+ - qcom,adreno-gmu-wrapper
+ required:
+ - compatible
+
properties:
compatible:
oneOf:
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: display/msm/gmu: fix the schema being not applied
2024-06-23 12:59 [PATCH] dt-bindings: display/msm/gmu: fix the schema being not applied Krzysztof Kozlowski
@ 2024-06-25 22:51 ` Rob Herring
2024-06-26 4:31 ` Dmitry Baryshkov
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2024-06-25 22:51 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel, Akhil P Oommen
On Sun, Jun 23, 2024 at 02:59:30PM +0200, Krzysztof Kozlowski wrote:
> dtschema v2024.4, v2024.5 and maybe earlier do not select device nodes for
That should be just since db9c05a08709 ("validator: Rework selecting
schemas for validation") AKA the 6x speed up in v2024.04.
> given binding validation if the schema contains compatible list with
> pattern and a const fallback. This leads to binding being a no-op - not
> being applied at all. Issue should be fixed in the dtschema but for now
> add a work-around do the binding can be used against DTS validation.
The issue is we only look at the first compatible. I'm testing out a fix
and will apply it tomorrow assuming no issues. With that, I don't think
we should apply this patch.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Akhil P Oommen <quic_akhilpo@quicinc.com>
> ---
> .../devicetree/bindings/display/msm/gmu.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings/display/msm/gmu.yaml
> index b3837368a260..8d1b515f59ec 100644
> --- a/Documentation/devicetree/bindings/display/msm/gmu.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/gmu.yaml
> @@ -17,6 +17,18 @@ description: |
> management and support to improve power efficiency and reduce the load on
> the CPU.
>
> +# dtschema does not select nodes based on pattern+const, so add custom select
> +# as a work-around:
> +select:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,adreno-gmu
> + - qcom,adreno-gmu-wrapper
> + required:
> + - compatible
> +
> properties:
> compatible:
> oneOf:
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: display/msm/gmu: fix the schema being not applied
2024-06-25 22:51 ` Rob Herring
@ 2024-06-26 4:31 ` Dmitry Baryshkov
2024-06-26 6:19 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Baryshkov @ 2024-06-26 4:31 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Rob Clark, Abhinav Kumar, Sean Paul,
Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel, Akhil P Oommen
On Tue, Jun 25, 2024 at 04:51:27PM GMT, Rob Herring wrote:
> On Sun, Jun 23, 2024 at 02:59:30PM +0200, Krzysztof Kozlowski wrote:
> > dtschema v2024.4, v2024.5 and maybe earlier do not select device nodes for
>
> That should be just since db9c05a08709 ("validator: Rework selecting
> schemas for validation") AKA the 6x speed up in v2024.04.
>
> > given binding validation if the schema contains compatible list with
> > pattern and a const fallback. This leads to binding being a no-op - not
> > being applied at all. Issue should be fixed in the dtschema but for now
> > add a work-around do the binding can be used against DTS validation.
>
> The issue is we only look at the first compatible. I'm testing out a fix
> and will apply it tomorrow assuming no issues. With that, I don't think
> we should apply this patch.
I think we ended up picking up the next iteration of the patch, but we
can probably land a revert later.
>
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> > ---
> >
> > Cc: Akhil P Oommen <quic_akhilpo@quicinc.com>
> > ---
> > .../devicetree/bindings/display/msm/gmu.yaml | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings/display/msm/gmu.yaml
> > index b3837368a260..8d1b515f59ec 100644
> > --- a/Documentation/devicetree/bindings/display/msm/gmu.yaml
> > +++ b/Documentation/devicetree/bindings/display/msm/gmu.yaml
> > @@ -17,6 +17,18 @@ description: |
> > management and support to improve power efficiency and reduce the load on
> > the CPU.
> >
> > +# dtschema does not select nodes based on pattern+const, so add custom select
> > +# as a work-around:
> > +select:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - qcom,adreno-gmu
> > + - qcom,adreno-gmu-wrapper
> > + required:
> > + - compatible
> > +
> > properties:
> > compatible:
> > oneOf:
> > --
> > 2.43.0
> >
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: display/msm/gmu: fix the schema being not applied
2024-06-26 4:31 ` Dmitry Baryshkov
@ 2024-06-26 6:19 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-26 6:19 UTC (permalink / raw)
To: Dmitry Baryshkov, Rob Herring
Cc: Rob Clark, Abhinav Kumar, Sean Paul, Marijn Suijten,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
dri-devel, freedreno, devicetree, linux-kernel, Akhil P Oommen
On 26/06/2024 06:31, Dmitry Baryshkov wrote:
> On Tue, Jun 25, 2024 at 04:51:27PM GMT, Rob Herring wrote:
>> On Sun, Jun 23, 2024 at 02:59:30PM +0200, Krzysztof Kozlowski wrote:
>>> dtschema v2024.4, v2024.5 and maybe earlier do not select device nodes for
>>
>> That should be just since db9c05a08709 ("validator: Rework selecting
>> schemas for validation") AKA the 6x speed up in v2024.04.
>>
>>> given binding validation if the schema contains compatible list with
>>> pattern and a const fallback. This leads to binding being a no-op - not
>>> being applied at all. Issue should be fixed in the dtschema but for now
>>> add a work-around do the binding can be used against DTS validation.
>>
>> The issue is we only look at the first compatible. I'm testing out a fix
>> and will apply it tomorrow assuming no issues. With that, I don't think
>> we should apply this patch.
>
> I think we ended up picking up the next iteration of the patch, but we
> can probably land a revert later.
gpu patch was applied. This is gmu, so can be just ignored/skipped.
Anyway the code here should not have negative effect, so we can revert
it anytime later, e.g. when users upgrade to fixed dtschema.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-26 6:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-23 12:59 [PATCH] dt-bindings: display/msm/gmu: fix the schema being not applied Krzysztof Kozlowski
2024-06-25 22:51 ` Rob Herring
2024-06-26 4:31 ` Dmitry Baryshkov
2024-06-26 6:19 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).