[PATCH v2 0/3] drm: panel: add support lincolntech LCD197 panel

[PATCH v2 0/3] drm: panel: add support lincolntech LCD197 panel

[Jerome Brunet]

This patchset adds support for the Lincolntech LCD197 1080x1920 DSI panel.

Changes since v1 [1]:
 * Rebased on drm-misc-next
 * Drop vendor prefix change (lincolntech recently added)
 * Use mipi_dsi_dcs_*multi()
 * Drop the shutdown callback
 * Insert mipi_dsi_usleep_range() for _multi usage as suggested.
 * Downcase hexadecimal values

[1]: https://lore.kernel.org/lkml/20240625142552.1000988-1-jbrunet@baylibre.com

Jerome Brunet (3):
  dt-bindings: panel-simple-dsi: add lincoln LCD197 panel bindings
  drm/mipi-dsi: add mipi_dsi_usleep_range helper
  drm/panel: add lincolntech lcd197 support

 .../display/panel/panel-simple-dsi.yaml       |   2 +
 drivers/gpu/drm/panel/Kconfig                 |  11 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../gpu/drm/panel/panel-lincolntech-lcd197.c  | 262 ++++++++++++++++++
 include/drm/drm_mipi_dsi.h                    |   7 +
 5 files changed, 283 insertions(+)
 create mode 100644 drivers/gpu/drm/panel/panel-lincolntech-lcd197.c

-- 
2.43.0

[PATCH v2 1/3] dt-bindings: panel-simple-dsi: add lincoln LCD197 panel bindings

[Jerome Brunet]

This adds the bindings for the 1080x1920 Lincoln LCD197 DSI panel to
panel-simple-dsi.

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 .../devicetree/bindings/display/panel/panel-simple-dsi.yaml     | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
index db5acd2807ed..9b92a05791cc 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
@@ -46,6 +46,8 @@ properties:
       - lg,ld070wx3-sl01
         # LG Corporation 5" HD TFT LCD panel
       - lg,lh500wx1-sd03
+        # Lincoln LCD197 5" 1080x1920 LCD panel
+      - lincolntech,lcd197
         # One Stop Displays OSD101T2587-53TS 10.1" 1920x1200 panel
       - osddisplays,osd101t2587-53ts
         # Panasonic 10" WUXGA TFT LCD panel
-- 
2.43.0

Re: [PATCH v2 1/3] dt-bindings: panel-simple-dsi: add lincoln LCD197 panel bindings

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

On Wed, Jun 26, 2024 at 04:22:07PM +0200, Jerome Brunet wrote:
> This adds the bindings for the 1080x1920 Lincoln LCD197 DSI panel to
> panel-simple-dsi.
> 
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH v2 2/3] drm/mipi-dsi: add mipi_dsi_usleep_range helper

[Jerome Brunet]

Like for mipi_dsi_msleep(), usleep_range() may often be called
in between mipi_dsi_dcs_*() functions and needs a multi compatible
counter part.

Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 include/drm/drm_mipi_dsi.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h
index 71d121aeef24..0f520eeeaa8e 100644
--- a/include/drm/drm_mipi_dsi.h
+++ b/include/drm/drm_mipi_dsi.h
@@ -10,6 +10,7 @@
 #define __DRM_MIPI_DSI_H__
 
 #include <linux/device.h>
+#include <linux/delay.h>
 
 struct mipi_dsi_host;
 struct mipi_dsi_device;
@@ -297,6 +298,12 @@ ssize_t mipi_dsi_generic_read(struct mipi_dsi_device *dsi, const void *params,
 			msleep(delay);	\
 	} while (0)
 
+#define mipi_dsi_usleep_range(ctx, min, max)	\
+	do {					\
+		if (!(ctx)->accum_err)		\
+			usleep_range(min, max);	\
+	} while (0)
+
 /**
  * enum mipi_dsi_dcs_tear_mode - Tearing Effect Output Line mode
  * @MIPI_DSI_DCS_TEAR_MODE_VBLANK: the TE output line consists of V-Blanking
-- 
2.43.0

Re: [PATCH v2 2/3] drm/mipi-dsi: add mipi_dsi_usleep_range helper

[Neil Armstrong]

On 26/06/2024 16:22, Jerome Brunet wrote:
> Like for mipi_dsi_msleep(), usleep_range() may often be called
> in between mipi_dsi_dcs_*() functions and needs a multi compatible
> counter part.
> 
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>   include/drm/drm_mipi_dsi.h | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h
> index 71d121aeef24..0f520eeeaa8e 100644
> --- a/include/drm/drm_mipi_dsi.h
> +++ b/include/drm/drm_mipi_dsi.h
> @@ -10,6 +10,7 @@
>   #define __DRM_MIPI_DSI_H__
>   
>   #include <linux/device.h>
> +#include <linux/delay.h>
>   
>   struct mipi_dsi_host;
>   struct mipi_dsi_device;
> @@ -297,6 +298,12 @@ ssize_t mipi_dsi_generic_read(struct mipi_dsi_device *dsi, const void *params,
>   			msleep(delay);	\
>   	} while (0)
>   
> +#define mipi_dsi_usleep_range(ctx, min, max)	\
> +	do {					\
> +		if (!(ctx)->accum_err)		\
> +			usleep_range(min, max);	\
> +	} while (0)
> +
>   /**
>    * enum mipi_dsi_dcs_tear_mode - Tearing Effect Output Line mode
>    * @MIPI_DSI_DCS_TEAR_MODE_VBLANK: the TE output line consists of V-Blanking

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

[PATCH v2 3/3] drm/panel: add lincolntech lcd197 support

[Jerome Brunet]

Add support for the Lincoln Technologies LCD197 1080x1920 DSI panel.

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 drivers/gpu/drm/panel/Kconfig                 |  11 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../gpu/drm/panel/panel-lincolntech-lcd197.c  | 262 ++++++++++++++++++
 3 files changed, 274 insertions(+)
 create mode 100644 drivers/gpu/drm/panel/panel-lincolntech-lcd197.c

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index bf4eadfe21cb..30206be56f68 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -328,6 +328,17 @@ config DRM_PANEL_LEADTEK_LTK500HD1829
 	  24 bit RGB per pixel. It provides a MIPI DSI interface to
 	  the host and has a built-in LED backlight.
 
+config DRM_PANEL_LINCOLNTECH_LCD197
+	tristate "Lincoln Technologies lcd197 panel"
+	depends on OF
+	depends on DRM_MIPI_DSI
+	depends on BACKLIGHT_CLASS_DEVICE
+	help
+	  Say Y here if you want to enable support for lincolntech lcd197
+	  TFT-LCD modules. The panel has a 1080x1920 resolution and uses
+	  24 bit RGB per pixel. It provides a MIPI DSI interface to
+	  the host.
+
 config DRM_PANEL_LG_LB035Q02
 	tristate "LG LB035Q024573 RGB panel"
 	depends on GPIOLIB && OF && SPI
diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
index 051b75b3df7b..7706ff9087d8 100644
--- a/drivers/gpu/drm/panel/Makefile
+++ b/drivers/gpu/drm/panel/Makefile
@@ -33,6 +33,7 @@ obj-$(CONFIG_DRM_PANEL_KHADAS_TS050) += panel-khadas-ts050.o
 obj-$(CONFIG_DRM_PANEL_KINGDISPLAY_KD097D04) += panel-kingdisplay-kd097d04.o
 obj-$(CONFIG_DRM_PANEL_LEADTEK_LTK050H3146W) += panel-leadtek-ltk050h3146w.o
 obj-$(CONFIG_DRM_PANEL_LEADTEK_LTK500HD1829) += panel-leadtek-ltk500hd1829.o
+obj-$(CONFIG_DRM_PANEL_LINCOLNTECH_LCD197) += panel-lincolntech-lcd197.o
 obj-$(CONFIG_DRM_PANEL_LG_LB035Q02) += panel-lg-lb035q02.o
 obj-$(CONFIG_DRM_PANEL_LG_LG4573) += panel-lg-lg4573.o
 obj-$(CONFIG_DRM_PANEL_LG_SW43408) += panel-lg-sw43408.o
diff --git a/drivers/gpu/drm/panel/panel-lincolntech-lcd197.c b/drivers/gpu/drm/panel/panel-lincolntech-lcd197.c
new file mode 100644
index 000000000000..032c542aab0f
--- /dev/null
+++ b/drivers/gpu/drm/panel/panel-lincolntech-lcd197.c
@@ -0,0 +1,262 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2024 BayLibre, SAS
+ * Author: Jerome Brunet <jbrunet@baylibre.com>
+ */
+
+#include <linux/gpio/consumer.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/regulator/consumer.h>
+
+#include <video/mipi_display.h>
+
+#include <drm/drm_device.h>
+#include <drm/drm_probe_helper.h>
+#include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modes.h>
+#include <drm/drm_panel.h>
+
+struct lincoln_lcd197_panel {
+	struct drm_panel panel;
+	struct mipi_dsi_device *dsi;
+	struct regulator *supply;
+	struct gpio_desc *enable_gpio;
+	struct gpio_desc *reset_gpio;
+};
+
+static inline
+struct lincoln_lcd197_panel *to_lincoln_lcd197_panel(struct drm_panel *panel)
+{
+	return container_of(panel, struct lincoln_lcd197_panel, panel);
+}
+
+static int lincoln_lcd197_panel_prepare(struct drm_panel *panel)
+{
+	struct lincoln_lcd197_panel *lcd = to_lincoln_lcd197_panel(panel);
+	struct mipi_dsi_multi_context ctx = { .dsi = lcd->dsi };
+	int err;
+
+	gpiod_set_value_cansleep(lcd->enable_gpio, 0);
+	err = regulator_enable(lcd->supply);
+	if (err < 0)
+		return err;
+
+	gpiod_set_value_cansleep(lcd->enable_gpio, 1);
+	usleep_range(1000, 2000);
+	gpiod_set_value_cansleep(lcd->reset_gpio, 1);
+	usleep_range(5000, 6000);
+	gpiod_set_value_cansleep(lcd->reset_gpio, 0);
+	msleep(50);
+
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xb9, 0xff, 0x83, 0x99);
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xd2, 0x55);
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xb1, 0x02, 0x04, 0x70, 0x90, 0x01,
+			       0x32, 0x33, 0x11, 0x11, 0x4d, 0x57, 0x56, 0x73,
+			       0x02, 0x02);
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xb2, 0x00, 0x80, 0x80, 0xae, 0x0a,
+			       0x0e, 0x75, 0x11, 0x00, 0x00, 0x00);
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xb4, 0x00, 0xff, 0x04, 0xa4, 0x02,
+			       0xa0, 0x00, 0x00, 0x10, 0x00, 0x00, 0x02, 0x00,
+			       0x24, 0x02, 0x04, 0x0a, 0x21, 0x03, 0x00, 0x00,
+			       0x08, 0xa6, 0x88, 0x04, 0xa4, 0x02, 0xa0, 0x00,
+			       0x00, 0x10, 0x00, 0x00, 0x02, 0x00, 0x24, 0x02,
+			       0x04, 0x0a, 0x00, 0x00, 0x08, 0xa6, 0x00, 0x08,
+			       0x11);
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xd3, 0x00, 0x00, 0x00, 0x00, 0x00,
+			       0x00, 0x18, 0x18, 0x32, 0x10, 0x09, 0x00, 0x09,
+			       0x32, 0x10, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+			       0x00, 0x00, 0x11, 0x00, 0x02, 0x02, 0x03, 0x00,
+			       0x00, 0x00, 0x0a, 0x40);
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xd5, 0x18, 0x18, 0x18, 0x18, 0x21,
+			       0x20, 0x18, 0x18, 0x19, 0x19, 0x19, 0x19, 0x18,
+			       0x18, 0x18, 0x18, 0x03, 0x02, 0x01, 0x00, 0x2f,
+			       0x2f, 0x30, 0x30, 0x31, 0x31, 0x18, 0x18, 0x18,
+			       0x18, 0x18, 0x18);
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xd6, 0x18, 0x18, 0x18, 0x18, 0x20,
+			       0x21, 0x19, 0x19, 0x18, 0x18, 0x19, 0x19, 0x18,
+			       0x18, 0x18, 0x18, 0x00, 0x01, 0x02, 0x03, 0x2f,
+			       0x2f, 0x30, 0x30, 0x31, 0x31, 0x18, 0x18, 0x18,
+			       0x18, 0x18, 0x18);
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xbd, 0x01);
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xd8, 0x0a, 0xbe, 0xfa, 0xa0, 0x0a,
+			       0xbe, 0xfa, 0xa0);
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xd8, 0x0f, 0xff, 0xff, 0xe0, 0x0f,
+			       0xff, 0xff, 0xe0);
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xbd, 0x02);
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xd8, 0x0f, 0xff, 0xff, 0xe0, 0x0f,
+			       0xff, 0xff, 0xe0);
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xe0, 0x01, 0x11, 0x1c, 0x17, 0x39,
+			       0x43, 0x54, 0x51, 0x5a, 0x64, 0x6c, 0x74, 0x7a,
+			       0x83, 0x8d, 0x92, 0x99, 0xa4, 0xa9, 0xb4, 0xaa,
+			       0xba, 0xbe, 0x63, 0x5e, 0x69, 0x73, 0x01, 0x11,
+			       0x1c, 0x17, 0x39, 0x43, 0x54, 0x51, 0x5a, 0x64,
+			       0x6c, 0x74, 0x7a, 0x83, 0x8d, 0x92, 0x99, 0xa4,
+			       0xa7, 0xb2, 0xa9, 0xba, 0xbe, 0x63, 0x5e, 0x69,
+			       0x73);
+	mipi_dsi_usleep_range(&ctx, 200, 300);
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xb6, 0x92, 0x92);
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xcc, 0x00);
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xbf, 0x40, 0x41, 0x50, 0x49);
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xc6, 0xff, 0xf9);
+	mipi_dsi_dcs_write_seq_multi(&ctx, 0xc0, 0x25, 0x5a);
+	mipi_dsi_dcs_write_seq_multi(&ctx, MIPI_DCS_SET_ADDRESS_MODE, 0x02);
+	mipi_dsi_dcs_exit_sleep_mode_multi(&ctx);
+	mipi_dsi_msleep(&ctx, 120);
+
+	if (ctx.accum_err) {
+		gpiod_set_value_cansleep(lcd->enable_gpio, 0);
+		gpiod_set_value_cansleep(lcd->reset_gpio, 1);
+		regulator_disable(lcd->supply);
+	}
+
+	return ctx.accum_err;
+}
+
+static int lincoln_lcd197_panel_unprepare(struct drm_panel *panel)
+{
+	struct lincoln_lcd197_panel *lcd = to_lincoln_lcd197_panel(panel);
+	struct mipi_dsi_multi_context ctx = { .dsi = lcd->dsi };
+
+	mipi_dsi_dcs_enter_sleep_mode_multi(&ctx);
+	mipi_dsi_usleep_range(&ctx, 5000, 6000);
+	gpiod_set_value_cansleep(lcd->enable_gpio, 0);
+	gpiod_set_value_cansleep(lcd->reset_gpio, 1);
+	regulator_disable(lcd->supply);
+
+	return ctx.accum_err;
+}
+
+static int lincoln_lcd197_panel_enable(struct drm_panel *panel)
+{
+	struct lincoln_lcd197_panel *lcd = to_lincoln_lcd197_panel(panel);
+	struct mipi_dsi_multi_context ctx = { .dsi = lcd->dsi };
+
+	mipi_dsi_dcs_set_display_on_multi(&ctx);
+	mipi_dsi_msleep(&ctx, 20);
+
+	return ctx.accum_err;
+}
+
+static int lincoln_lcd197_panel_disable(struct drm_panel *panel)
+{
+	struct lincoln_lcd197_panel *lcd = to_lincoln_lcd197_panel(panel);
+	struct mipi_dsi_multi_context ctx = { .dsi = lcd->dsi };
+
+	mipi_dsi_dcs_set_display_off_multi(&ctx);
+	mipi_dsi_msleep(&ctx, 50);
+
+	return ctx.accum_err;
+}
+
+static const struct drm_display_mode lcd197_mode = {
+	.clock = 154002,
+	.hdisplay = 1080,
+	.hsync_start = 1080 + 20,
+	.hsync_end = 1080 + 20 + 6,
+	.htotal = 1080 + 204,
+	.vdisplay = 1920,
+	.vsync_start = 1920 + 4,
+	.vsync_end = 1920 + 4 + 4,
+	.vtotal = 1920 + 79,
+	.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+	.width_mm = 79,
+	.height_mm = 125,
+	.type = DRM_MODE_TYPE_DRIVER,
+};
+
+static int lincoln_lcd197_panel_get_modes(struct drm_panel *panel,
+					  struct drm_connector *connector)
+{
+	return drm_connector_helper_get_modes_fixed(connector, &lcd197_mode);
+}
+
+static const struct drm_panel_funcs lincoln_lcd197_panel_funcs = {
+	.prepare = lincoln_lcd197_panel_prepare,
+	.unprepare = lincoln_lcd197_panel_unprepare,
+	.enable = lincoln_lcd197_panel_enable,
+	.disable = lincoln_lcd197_panel_disable,
+	.get_modes = lincoln_lcd197_panel_get_modes,
+};
+
+static int lincoln_lcd197_panel_probe(struct mipi_dsi_device *dsi)
+{
+	struct lincoln_lcd197_panel *lcd;
+	struct device *dev = &dsi->dev;
+	int err;
+
+	dsi->lanes = 4;
+	dsi->format = MIPI_DSI_FMT_RGB888;
+	dsi->mode_flags = (MIPI_DSI_MODE_VIDEO |
+			   MIPI_DSI_MODE_VIDEO_BURST);
+
+	lcd = devm_kzalloc(&dsi->dev, sizeof(*lcd), GFP_KERNEL);
+	if (!lcd)
+		return -ENOMEM;
+
+	mipi_dsi_set_drvdata(dsi, lcd);
+	lcd->dsi = dsi;
+
+	lcd->supply = devm_regulator_get(dev, "power");
+	if (IS_ERR(lcd->supply))
+		return dev_err_probe(dev, PTR_ERR(lcd->supply),
+				     "failed to get power supply");
+
+	lcd->enable_gpio = devm_gpiod_get(dev, "enable",
+					  GPIOD_OUT_HIGH);
+	if (IS_ERR(lcd->enable_gpio))
+		return dev_err_probe(dev, PTR_ERR(lcd->enable_gpio),
+				     "failed to get enable gpio");
+
+	lcd->reset_gpio = devm_gpiod_get(dev, "reset",
+					  GPIOD_OUT_HIGH);
+	if (IS_ERR(lcd->reset_gpio))
+		return dev_err_probe(dev, PTR_ERR(lcd->reset_gpio),
+				     "failed to get reset gpio");
+
+	drm_panel_init(&lcd->panel, dev,
+		       &lincoln_lcd197_panel_funcs, DRM_MODE_CONNECTOR_DSI);
+
+	err = drm_panel_of_backlight(&lcd->panel);
+	if (err)
+		return err;
+
+	drm_panel_add(&lcd->panel);
+	err = mipi_dsi_attach(dsi);
+	if (err)
+		drm_panel_remove(&lcd->panel);
+
+	return err;
+}
+
+static void lincoln_lcd197_panel_remove(struct mipi_dsi_device *dsi)
+{
+	struct lincoln_lcd197_panel *lcd = mipi_dsi_get_drvdata(dsi);
+	int err;
+
+	err = mipi_dsi_detach(dsi);
+	if (err < 0)
+		dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", err);
+
+	drm_panel_remove(&lcd->panel);
+}
+
+static const struct of_device_id lincoln_lcd197_of_match[] = {
+	{ .compatible = "lincolntech,lcd197", },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, lincoln_lcd197_of_match);
+
+static struct mipi_dsi_driver lincoln_lcd197_panel_driver = {
+	.driver = {
+		.name = "panel-lincolntech-lcd197",
+		.of_match_table = lincoln_lcd197_of_match,
+	},
+	.probe = lincoln_lcd197_panel_probe,
+	.remove = lincoln_lcd197_panel_remove,
+};
+module_mipi_dsi_driver(lincoln_lcd197_panel_driver);
+
+MODULE_AUTHOR("Jerome Brunet <jbrunet@baylibre.com>");
+MODULE_DESCRIPTION("Lincoln Technologies LCD197 panel driver");
+MODULE_LICENSE("GPL");
-- 
2.43.0

Re: [PATCH v2 3/3] drm/panel: add lincolntech lcd197 support

[Neil Armstrong]

On 26/06/2024 16:22, Jerome Brunet wrote:
> Add support for the Lincoln Technologies LCD197 1080x1920 DSI panel.
> 
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>   drivers/gpu/drm/panel/Kconfig                 |  11 +
>   drivers/gpu/drm/panel/Makefile                |   1 +
>   .../gpu/drm/panel/panel-lincolntech-lcd197.c  | 262 ++++++++++++++++++
>   3 files changed, 274 insertions(+)
>   create mode 100644 drivers/gpu/drm/panel/panel-lincolntech-lcd197.c
> 
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index bf4eadfe21cb..30206be56f68 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -328,6 +328,17 @@ config DRM_PANEL_LEADTEK_LTK500HD1829
>   	  24 bit RGB per pixel. It provides a MIPI DSI interface to
>   	  the host and has a built-in LED backlight.
>   
> +config DRM_PANEL_LINCOLNTECH_LCD197
> +	tristate "Lincoln Technologies lcd197 panel"
> +	depends on OF
> +	depends on DRM_MIPI_DSI
> +	depends on BACKLIGHT_CLASS_DEVICE
> +	help
> +	  Say Y here if you want to enable support for lincolntech lcd197
> +	  TFT-LCD modules. The panel has a 1080x1920 resolution and uses
> +	  24 bit RGB per pixel. It provides a MIPI DSI interface to
> +	  the host.
> +
>   config DRM_PANEL_LG_LB035Q02
>   	tristate "LG LB035Q024573 RGB panel"
>   	depends on GPIOLIB && OF && SPI
> diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
> index 051b75b3df7b..7706ff9087d8 100644
> --- a/drivers/gpu/drm/panel/Makefile
> +++ b/drivers/gpu/drm/panel/Makefile
> @@ -33,6 +33,7 @@ obj-$(CONFIG_DRM_PANEL_KHADAS_TS050) += panel-khadas-ts050.o
>   obj-$(CONFIG_DRM_PANEL_KINGDISPLAY_KD097D04) += panel-kingdisplay-kd097d04.o
>   obj-$(CONFIG_DRM_PANEL_LEADTEK_LTK050H3146W) += panel-leadtek-ltk050h3146w.o
>   obj-$(CONFIG_DRM_PANEL_LEADTEK_LTK500HD1829) += panel-leadtek-ltk500hd1829.o
> +obj-$(CONFIG_DRM_PANEL_LINCOLNTECH_LCD197) += panel-lincolntech-lcd197.o
>   obj-$(CONFIG_DRM_PANEL_LG_LB035Q02) += panel-lg-lb035q02.o
>   obj-$(CONFIG_DRM_PANEL_LG_LG4573) += panel-lg-lg4573.o
>   obj-$(CONFIG_DRM_PANEL_LG_SW43408) += panel-lg-sw43408.o
> diff --git a/drivers/gpu/drm/panel/panel-lincolntech-lcd197.c b/drivers/gpu/drm/panel/panel-lincolntech-lcd197.c
> new file mode 100644
> index 000000000000..032c542aab0f
> --- /dev/null
> +++ b/drivers/gpu/drm/panel/panel-lincolntech-lcd197.c
> @@ -0,0 +1,262 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2024 BayLibre, SAS
> + * Author: Jerome Brunet <jbrunet@baylibre.com>
> + */
> +
> +#include <linux/gpio/consumer.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/regulator/consumer.h>
> +
> +#include <video/mipi_display.h>
> +
> +#include <drm/drm_device.h>
> +#include <drm/drm_probe_helper.h>
> +#include <drm/drm_mipi_dsi.h>
> +#include <drm/drm_modes.h>
> +#include <drm/drm_panel.h>
> +
> +struct lincoln_lcd197_panel {
> +	struct drm_panel panel;
> +	struct mipi_dsi_device *dsi;
> +	struct regulator *supply;
> +	struct gpio_desc *enable_gpio;
> +	struct gpio_desc *reset_gpio;
> +};
> +
> +static inline
> +struct lincoln_lcd197_panel *to_lincoln_lcd197_panel(struct drm_panel *panel)
> +{
> +	return container_of(panel, struct lincoln_lcd197_panel, panel);
> +}
> +
> +static int lincoln_lcd197_panel_prepare(struct drm_panel *panel)
> +{
> +	struct lincoln_lcd197_panel *lcd = to_lincoln_lcd197_panel(panel);
> +	struct mipi_dsi_multi_context ctx = { .dsi = lcd->dsi };
> +	int err;
> +
> +	gpiod_set_value_cansleep(lcd->enable_gpio, 0);
> +	err = regulator_enable(lcd->supply);
> +	if (err < 0)
> +		return err;
> +
> +	gpiod_set_value_cansleep(lcd->enable_gpio, 1);
> +	usleep_range(1000, 2000);
> +	gpiod_set_value_cansleep(lcd->reset_gpio, 1);
> +	usleep_range(5000, 6000);
> +	gpiod_set_value_cansleep(lcd->reset_gpio, 0);
> +	msleep(50);
> +
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xb9, 0xff, 0x83, 0x99);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xd2, 0x55);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xb1, 0x02, 0x04, 0x70, 0x90, 0x01,
> +			       0x32, 0x33, 0x11, 0x11, 0x4d, 0x57, 0x56, 0x73,
> +			       0x02, 0x02);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xb2, 0x00, 0x80, 0x80, 0xae, 0x0a,
> +			       0x0e, 0x75, 0x11, 0x00, 0x00, 0x00);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xb4, 0x00, 0xff, 0x04, 0xa4, 0x02,
> +			       0xa0, 0x00, 0x00, 0x10, 0x00, 0x00, 0x02, 0x00,
> +			       0x24, 0x02, 0x04, 0x0a, 0x21, 0x03, 0x00, 0x00,
> +			       0x08, 0xa6, 0x88, 0x04, 0xa4, 0x02, 0xa0, 0x00,
> +			       0x00, 0x10, 0x00, 0x00, 0x02, 0x00, 0x24, 0x02,
> +			       0x04, 0x0a, 0x00, 0x00, 0x08, 0xa6, 0x00, 0x08,
> +			       0x11);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xd3, 0x00, 0x00, 0x00, 0x00, 0x00,
> +			       0x00, 0x18, 0x18, 0x32, 0x10, 0x09, 0x00, 0x09,
> +			       0x32, 0x10, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +			       0x00, 0x00, 0x11, 0x00, 0x02, 0x02, 0x03, 0x00,
> +			       0x00, 0x00, 0x0a, 0x40);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xd5, 0x18, 0x18, 0x18, 0x18, 0x21,
> +			       0x20, 0x18, 0x18, 0x19, 0x19, 0x19, 0x19, 0x18,
> +			       0x18, 0x18, 0x18, 0x03, 0x02, 0x01, 0x00, 0x2f,
> +			       0x2f, 0x30, 0x30, 0x31, 0x31, 0x18, 0x18, 0x18,
> +			       0x18, 0x18, 0x18);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xd6, 0x18, 0x18, 0x18, 0x18, 0x20,
> +			       0x21, 0x19, 0x19, 0x18, 0x18, 0x19, 0x19, 0x18,
> +			       0x18, 0x18, 0x18, 0x00, 0x01, 0x02, 0x03, 0x2f,
> +			       0x2f, 0x30, 0x30, 0x31, 0x31, 0x18, 0x18, 0x18,
> +			       0x18, 0x18, 0x18);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xbd, 0x01);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xd8, 0x0a, 0xbe, 0xfa, 0xa0, 0x0a,
> +			       0xbe, 0xfa, 0xa0);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xd8, 0x0f, 0xff, 0xff, 0xe0, 0x0f,
> +			       0xff, 0xff, 0xe0);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xbd, 0x02);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xd8, 0x0f, 0xff, 0xff, 0xe0, 0x0f,
> +			       0xff, 0xff, 0xe0);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xe0, 0x01, 0x11, 0x1c, 0x17, 0x39,
> +			       0x43, 0x54, 0x51, 0x5a, 0x64, 0x6c, 0x74, 0x7a,
> +			       0x83, 0x8d, 0x92, 0x99, 0xa4, 0xa9, 0xb4, 0xaa,
> +			       0xba, 0xbe, 0x63, 0x5e, 0x69, 0x73, 0x01, 0x11,
> +			       0x1c, 0x17, 0x39, 0x43, 0x54, 0x51, 0x5a, 0x64,
> +			       0x6c, 0x74, 0x7a, 0x83, 0x8d, 0x92, 0x99, 0xa4,
> +			       0xa7, 0xb2, 0xa9, 0xba, 0xbe, 0x63, 0x5e, 0x69,
> +			       0x73);
> +	mipi_dsi_usleep_range(&ctx, 200, 300);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xb6, 0x92, 0x92);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xcc, 0x00);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xbf, 0x40, 0x41, 0x50, 0x49);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xc6, 0xff, 0xf9);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, 0xc0, 0x25, 0x5a);
> +	mipi_dsi_dcs_write_seq_multi(&ctx, MIPI_DCS_SET_ADDRESS_MODE, 0x02);
> +	mipi_dsi_dcs_exit_sleep_mode_multi(&ctx);
> +	mipi_dsi_msleep(&ctx, 120);
> +
> +	if (ctx.accum_err) {
> +		gpiod_set_value_cansleep(lcd->enable_gpio, 0);
> +		gpiod_set_value_cansleep(lcd->reset_gpio, 1);
> +		regulator_disable(lcd->supply);
> +	}
> +
> +	return ctx.accum_err;
> +}
> +
> +static int lincoln_lcd197_panel_unprepare(struct drm_panel *panel)
> +{
> +	struct lincoln_lcd197_panel *lcd = to_lincoln_lcd197_panel(panel);
> +	struct mipi_dsi_multi_context ctx = { .dsi = lcd->dsi };
> +
> +	mipi_dsi_dcs_enter_sleep_mode_multi(&ctx);
> +	mipi_dsi_usleep_range(&ctx, 5000, 6000);
> +	gpiod_set_value_cansleep(lcd->enable_gpio, 0);
> +	gpiod_set_value_cansleep(lcd->reset_gpio, 1);
> +	regulator_disable(lcd->supply);
> +
> +	return ctx.accum_err;
> +}
> +
> +static int lincoln_lcd197_panel_enable(struct drm_panel *panel)
> +{
> +	struct lincoln_lcd197_panel *lcd = to_lincoln_lcd197_panel(panel);
> +	struct mipi_dsi_multi_context ctx = { .dsi = lcd->dsi };
> +
> +	mipi_dsi_dcs_set_display_on_multi(&ctx);
> +	mipi_dsi_msleep(&ctx, 20);
> +
> +	return ctx.accum_err;
> +}
> +
> +static int lincoln_lcd197_panel_disable(struct drm_panel *panel)
> +{
> +	struct lincoln_lcd197_panel *lcd = to_lincoln_lcd197_panel(panel);
> +	struct mipi_dsi_multi_context ctx = { .dsi = lcd->dsi };
> +
> +	mipi_dsi_dcs_set_display_off_multi(&ctx);
> +	mipi_dsi_msleep(&ctx, 50);
> +
> +	return ctx.accum_err;
> +}
> +
> +static const struct drm_display_mode lcd197_mode = {
> +	.clock = 154002,
> +	.hdisplay = 1080,
> +	.hsync_start = 1080 + 20,
> +	.hsync_end = 1080 + 20 + 6,
> +	.htotal = 1080 + 204,
> +	.vdisplay = 1920,
> +	.vsync_start = 1920 + 4,
> +	.vsync_end = 1920 + 4 + 4,
> +	.vtotal = 1920 + 79,
> +	.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> +	.width_mm = 79,
> +	.height_mm = 125,
> +	.type = DRM_MODE_TYPE_DRIVER,
> +};
> +
> +static int lincoln_lcd197_panel_get_modes(struct drm_panel *panel,
> +					  struct drm_connector *connector)
> +{
> +	return drm_connector_helper_get_modes_fixed(connector, &lcd197_mode);
> +}
> +
> +static const struct drm_panel_funcs lincoln_lcd197_panel_funcs = {
> +	.prepare = lincoln_lcd197_panel_prepare,
> +	.unprepare = lincoln_lcd197_panel_unprepare,
> +	.enable = lincoln_lcd197_panel_enable,
> +	.disable = lincoln_lcd197_panel_disable,
> +	.get_modes = lincoln_lcd197_panel_get_modes,
> +};
> +
> +static int lincoln_lcd197_panel_probe(struct mipi_dsi_device *dsi)
> +{
> +	struct lincoln_lcd197_panel *lcd;
> +	struct device *dev = &dsi->dev;
> +	int err;
> +
> +	dsi->lanes = 4;
> +	dsi->format = MIPI_DSI_FMT_RGB888;
> +	dsi->mode_flags = (MIPI_DSI_MODE_VIDEO |
> +			   MIPI_DSI_MODE_VIDEO_BURST);
> +
> +	lcd = devm_kzalloc(&dsi->dev, sizeof(*lcd), GFP_KERNEL);
> +	if (!lcd)
> +		return -ENOMEM;
> +
> +	mipi_dsi_set_drvdata(dsi, lcd);
> +	lcd->dsi = dsi;
> +
> +	lcd->supply = devm_regulator_get(dev, "power");
> +	if (IS_ERR(lcd->supply))
> +		return dev_err_probe(dev, PTR_ERR(lcd->supply),
> +				     "failed to get power supply");
> +
> +	lcd->enable_gpio = devm_gpiod_get(dev, "enable",
> +					  GPIOD_OUT_HIGH);
> +	if (IS_ERR(lcd->enable_gpio))
> +		return dev_err_probe(dev, PTR_ERR(lcd->enable_gpio),
> +				     "failed to get enable gpio");
> +
> +	lcd->reset_gpio = devm_gpiod_get(dev, "reset",
> +					  GPIOD_OUT_HIGH);
> +	if (IS_ERR(lcd->reset_gpio))
> +		return dev_err_probe(dev, PTR_ERR(lcd->reset_gpio),
> +				     "failed to get reset gpio");
> +
> +	drm_panel_init(&lcd->panel, dev,
> +		       &lincoln_lcd197_panel_funcs, DRM_MODE_CONNECTOR_DSI);
> +
> +	err = drm_panel_of_backlight(&lcd->panel);
> +	if (err)
> +		return err;
> +
> +	drm_panel_add(&lcd->panel);
> +	err = mipi_dsi_attach(dsi);
> +	if (err)
> +		drm_panel_remove(&lcd->panel);
> +
> +	return err;
> +}
> +
> +static void lincoln_lcd197_panel_remove(struct mipi_dsi_device *dsi)
> +{
> +	struct lincoln_lcd197_panel *lcd = mipi_dsi_get_drvdata(dsi);
> +	int err;
> +
> +	err = mipi_dsi_detach(dsi);
> +	if (err < 0)
> +		dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", err);
> +
> +	drm_panel_remove(&lcd->panel);
> +}
> +
> +static const struct of_device_id lincoln_lcd197_of_match[] = {
> +	{ .compatible = "lincolntech,lcd197", },
> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, lincoln_lcd197_of_match);
> +
> +static struct mipi_dsi_driver lincoln_lcd197_panel_driver = {
> +	.driver = {
> +		.name = "panel-lincolntech-lcd197",
> +		.of_match_table = lincoln_lcd197_of_match,
> +	},
> +	.probe = lincoln_lcd197_panel_probe,
> +	.remove = lincoln_lcd197_panel_remove,
> +};
> +module_mipi_dsi_driver(lincoln_lcd197_panel_driver);
> +
> +MODULE_AUTHOR("Jerome Brunet <jbrunet@baylibre.com>");
> +MODULE_DESCRIPTION("Lincoln Technologies LCD197 panel driver");
> +MODULE_LICENSE("GPL");

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Re: [PATCH v2 0/3] drm: panel: add support lincolntech LCD197 panel

[Neil Armstrong]

Hi,

On Wed, 26 Jun 2024 16:22:06 +0200, Jerome Brunet wrote:
> This patchset adds support for the Lincolntech LCD197 1080x1920 DSI panel.
> 
> Changes since v1 [1]:
>  * Rebased on drm-misc-next
>  * Drop vendor prefix change (lincolntech recently added)
>  * Use mipi_dsi_dcs_*multi()
>  * Drop the shutdown callback
>  * Insert mipi_dsi_usleep_range() for _multi usage as suggested.
>  * Downcase hexadecimal values
> 
> [...]

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)

[1/3] dt-bindings: panel-simple-dsi: add lincoln LCD197 panel bindings
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/47d5c1934edcbda13d4fab4d7019b9ec8be0fe08
[2/3] drm/mipi-dsi: add mipi_dsi_usleep_range helper
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/3ebc76c424bc0f0768f5c346667e8f51217917ba
[3/3] drm/panel: add lincolntech lcd197 support
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/c5207ed4638314aca89afb45629902288efe5f4e

-- 
Neil