Devicetree
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Ryan Walklin <ryan@testtoast.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Jessica Zhang <quic_jesszhan@quicinc.com>,
	Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Hironori KIKUCHI <kikuchan98@gmail.com>,
	Chris Morgan <macroalpha82@gmail.com>
Subject: Re: [PATCH 3/3] dt-bindings: display: panel: correct Anbernic RG35XX panel example
Date: Wed, 26 Jun 2024 16:38:50 +0100	[thread overview]
Message-ID: <20240626-duo-outage-1601a51239b9@spud> (raw)
In-Reply-To: <20240626112005.248576-4-ryan@testtoast.com>

[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]

On Wed, Jun 26, 2024 at 11:17:50PM +1200, Ryan Walklin wrote:
> make dt_bindings_check reports that sck-gpios and num-chipselects are
> required for spi nodes, therefore add these to the example.
> 
> Signed-off-by: Ryan Walklin <ryan@testtoast.com>

huh, are you sure it does? It doesn't for me...

> ---
>  .../bindings/display/panel/anbernic,rg35xx-panel.yaml          | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
> index a7d5ad0f29389..610601c1594f3 100644
> --- a/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
> @@ -40,6 +40,9 @@ examples:
>          #address-cells = <1>;
>          #size-cells = <0>;
> 
> +        sck-gpios = <&pio 8 9 GPIO_ACTIVE_HIGH>; // PI9
> +        num-chipselects = <1>;
> +
>          panel@0 {
>              compatible = "anbernic,rg35xx-panel";
>              reg = <0>;
> -- 
> 2.45.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2024-06-26 15:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-26 11:17 [PATCH 0/3] Correct WL-355608-A8 panel compatible Ryan Walklin
2024-06-26 11:17 ` [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel Ryan Walklin
2024-06-26 12:25   ` Neil Armstrong
2024-06-26 15:04     ` Maxime Ripard
2024-06-26 15:34       ` Conor Dooley
2024-06-27 17:59         ` Maxime Ripard
2024-06-30  8:16           ` Ryan Walklin
2024-08-27 16:28             ` Neil Armstrong
2024-08-28  7:01               ` Maxime Ripard
2024-08-30  1:43                 ` Ryan Walklin
2024-08-30  7:56                   ` Neil Armstrong
2024-09-03  1:52                     ` Ryan Walklin
2024-06-26 11:17 ` [PATCH 2/3] drm: panel: nv3052c: Correct WL-355608-A8 panel compatible Ryan Walklin
2024-06-26 11:17 ` [PATCH 3/3] dt-bindings: display: panel: correct Anbernic RG35XX panel example Ryan Walklin
2024-06-26 15:38   ` Conor Dooley [this message]
2024-06-30  8:25     ` Ryan Walklin
2024-08-27 13:10 ` [PATCH 0/3] Correct WL-355608-A8 panel compatible Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240626-duo-outage-1601a51239b9@spud \
    --to=conor@kernel.org \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kikuchan98@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=macroalpha82@gmail.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_jesszhan@quicinc.com \
    --cc=robh@kernel.org \
    --cc=ryan@testtoast.com \
    --cc=sam@ravnborg.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox