[RFT][PATCH 0/2] dts: ti: Fix build warns in usb@31000000

[RFT][PATCH 0/2] dts: ti: Fix build warns in usb@31000000

[Dhruva Gole]

Hi,

The series has been marked as RFT because although I was able to boot
test, it needs to be made sure that usb features aren't affected by this
change. Ideally, looking at the driver, I don't think it really is
looking at port@X but incase I missed anything please feel free to point
out.

I'm working on top of tag: next-20240625

Dhruva Gole (2):
  arm64: dts: ti: k3-am62p5-sk: fix graph_child_address warnings
  arm64: dts: ti: k3-am62x-sk-common: Fix graph_child_address warns

 arch/arm64/boot/dts/ti/k3-am62p5-sk.dts        | 16 ++++------------
 arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 17 ++++-------------
 2 files changed, 8 insertions(+), 25 deletions(-)


base-commit: 0fc4bfab2cd45f9acb86c4f04b5191e114e901ed
-- 
2.34.1

[RFT][PATCH 1/2] arm64: dts: ti: k3-am62p5-sk: fix graph_child_address warnings

[Dhruva Gole]

Fix the following warnings that are thrown when building dtbs with W=1:

../arch/arm64/boot/dts/ti/k3-am62p5-sk.dts:367.10-376.6: Warning (graph_child_address): /bus@f0000/i2c@20000000/usb-power-controller@3f/connector/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
../arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi:647.22-657.5: Warning (graph_child_address): /bus@f0000/usb@f900000/usb@31000000: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
  also defined at ../arch/arm64/boot/dts/ti/k3-am62p5-sk.dts:517.7-528.3

Cc: Roger Quadros <rogerq@kernel.org>
Signed-off-by: Dhruva Gole <d-gole@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
index fb980d46e304..ff65955551a3 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
@@ -364,14 +364,9 @@ connector {
 			self-powered;
 			data-role = "dual";
 			power-role = "sink";
-			ports {
-				#address-cells = <1>;
-				#size-cells = <0>;
-				port@0 {
-					reg = <0>;
-					usb_con_hs: endpoint {
-						remote-endpoint = <&usb0_hs_ep>;
-					};
+			port {
+				usb_con_hs: endpoint {
+				remote-endpoint = <&usb0_hs_ep>;
 				};
 			};
 		};
@@ -516,11 +511,8 @@ &usbss1 {
 
 &usb0 {
 	usb-role-switch;
-	#address-cells = <1>;
-	#size-cells = <0>;
 
-	port@0 {
-		reg = <0>;
+	port {
 		usb0_hs_ep: endpoint {
 			remote-endpoint = <&usb_con_hs>;
 		};
-- 
2.34.1

Re: [RFT][PATCH 1/2] arm64: dts: ti: k3-am62p5-sk: fix graph_child_address warnings

[Roger Quadros]

On 26/06/2024 13:15, Dhruva Gole wrote:
> Fix the following warnings that are thrown when building dtbs with W=1:
> 
> ../arch/arm64/boot/dts/ti/k3-am62p5-sk.dts:367.10-376.6: Warning (graph_child_address): /bus@f0000/i2c@20000000/usb-power-controller@3f/connector/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> ../arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi:647.22-657.5: Warning (graph_child_address): /bus@f0000/usb@f900000/usb@31000000: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
>   also defined at ../arch/arm64/boot/dts/ti/k3-am62p5-sk.dts:517.7-528.3
> 
> Cc: Roger Quadros <rogerq@kernel.org>
> Signed-off-by: Dhruva Gole <d-gole@ti.com>

Reviewed-by: Roger Quadros <rogerq@kernel.org>

[RFT][PATCH 2/2] arm64: dts: ti: k3-am62x-sk-common: Fix graph_child_address warns

[Dhruva Gole]

Fix the following warnings when compiling dtbs with W=1:

../arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi:343.10-353.6: Warning (graph_child_address): /bus@f0000/i2c@20000000/tps6598x@3f/connector/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
../arch/arm64/boot/dts/ti/k3-am62-main.dtsi:633.22-643.5: Warning (graph_child_address): /bus@f0000/dwc3-usb@f900000/usb@31000000: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary

Cc: Roger Quadros <rogerq@kernel.org>
Signed-off-by: Dhruva Gole <d-gole@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 17 ++++-------------
 1 file changed, 4 insertions(+), 13 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
index ce7ab338f468..465743d6cc21 100644
--- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
@@ -340,15 +340,9 @@ connector {
 			self-powered;
 			data-role = "dual";
 			power-role = "sink";
-			ports {
-				#address-cells = <1>;
-				#size-cells = <0>;
-
-				port@0 {
-					reg = <0>;
-					usb_con_hs: endpoint {
-						remote-endpoint = <&usb0_hs_ep>;
-					};
+			port {
+				usb_con_hs: endpoint {
+					remote-endpoint = <&usb0_hs_ep>;
 				};
 			};
 		};
@@ -475,12 +469,9 @@ &usbss1 {
 
 &usb0 {
 	bootph-all;
-	#address-cells = <1>;
-	#size-cells = <0>;
 	usb-role-switch;
 
-	port@0 {
-		reg = <0>;
+	port {
 		usb0_hs_ep: endpoint {
 		    remote-endpoint = <&usb_con_hs>;
 	       };
-- 
2.34.1

Re: [RFT][PATCH 2/2] arm64: dts: ti: k3-am62x-sk-common: Fix graph_child_address warns

[Roger Quadros]

On 26/06/2024 13:15, Dhruva Gole wrote:
> Fix the following warnings when compiling dtbs with W=1:
> 
> ../arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi:343.10-353.6: Warning (graph_child_address): /bus@f0000/i2c@20000000/tps6598x@3f/connector/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> ../arch/arm64/boot/dts/ti/k3-am62-main.dtsi:633.22-643.5: Warning (graph_child_address): /bus@f0000/dwc3-usb@f900000/usb@31000000: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> 
> Cc: Roger Quadros <rogerq@kernel.org>
> Signed-off-by: Dhruva Gole <d-gole@ti.com>

Tested-by: Roger Quadros <rogerq@kernel.org>

Re: [RFT][PATCH 0/2] dts: ti: Fix build warns in usb@31000000

[Vignesh Raghavendra]

Hi Dhruva Gole,

On Wed, 26 Jun 2024 15:45:18 +0530, Dhruva Gole wrote:
> The series has been marked as RFT because although I was able to boot
> test, it needs to be made sure that usb features aren't affected by this
> change. Ideally, looking at the driver, I don't think it really is
> looking at port@X but incase I missed anything please feel free to point
> out.
> 
> I'm working on top of tag: next-20240625
> 
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/2] arm64: dts: ti: k3-am62p5-sk: fix graph_child_address warnings
      commit: 28a950c404679aba602e3311c733a19b7c945ab4
[2/2] arm64: dts: ti: k3-am62x-sk-common: Fix graph_child_address warns
      commit: cf645197f045147cd0232c7a205cdfed49590756

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh