From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75E67125D5 for ; Thu, 27 Jun 2024 16:16:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719504964; cv=none; b=tJ5GbVC3pvf0boaDKZdWOuZGKYHR6DkHr4sO+dJGID5Bm0h86O6rr0H9D+O63pEJwLQWrobFX2/6kffVVBwW3ehq9lAYsPkmdvw+g6aQP3WEh8qGtiuKvERkPK4UTuGJQeERPzlMDhb0s389zij2RT+qC0a1E18nWGP4W2SngVE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719504964; c=relaxed/simple; bh=K7c7Tx/3He/q87nxZHcjEEng/1qj921BjrT9VEi1+Hs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Qw4IJ2yaSb9wctAtXgO3KlTP95bGJYp5eikQRIVnZ2jYLkCYHZaKpsJ2mrAD/zowCcwLeM4KDN/HKB8jLDVeKoQ3ox5ZA7/fnmnYgWNaZfII5bGQAB3wC217kThXBtFiuve21e1UETXh+N7laT7GPkADWDCVULAWkwRkqP/S8RU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hu1PvAP6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hu1PvAP6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8C6AC2BBFC; Thu, 27 Jun 2024 16:15:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719504964; bh=K7c7Tx/3He/q87nxZHcjEEng/1qj921BjrT9VEi1+Hs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hu1PvAP6ZKVn0NLwjayviOkvW8z9WohVpCofjvKPM2XNBcoEXOFxaDSqRN4LK40pk WkKe59SHzoOeq/+ykXeFfp3pCIj9kbyhJr0ou2hc95d4f3aeutbzbmnngl9QrYNSvI IjL8Uxuy45qrXu1eQ7RNSPfXqVs2hbnwY6NhOYKxrXpnw/p3rhCXpDpEJBg/G1mqxn bkSdQ0gpxK/GVYsaiYFRpWNkQ7M33X1Y4leT7SnqYmUTGE6XmkS2149B7js2BjRKTj 3plIuDo/xzIxR/qjDNnR+iz5gneAPR0+h/MM8eE6k6sL+XjPFrIvg9U8t/Z0QDgjbG qoKe3AaByLFWA== Date: Thu, 27 Jun 2024 17:15:57 +0100 From: Conor Dooley To: Marc Gonzalez Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Arnaud Vrac , Pierre-Hugues Husson , Dmitry Baryshkov Subject: Re: [PATCH v2 1/2] dt-bindings: display: bridge: add TI TDP158 Message-ID: <20240627-headscarf-density-81bce4f05db4@spud> References: <20240625-tdp158-v2-0-a3b344707fa7@freebox.fr> <20240625-tdp158-v2-1-a3b344707fa7@freebox.fr> <20240626-blah-unseated-6cab234bae61@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="51j+MB7mBaap5O9i" Content-Disposition: inline In-Reply-To: --51j+MB7mBaap5O9i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 26, 2024 at 07:20:46PM +0200, Marc Gonzalez wrote: > On 26/06/2024 18:08, Conor Dooley wrote: >=20 > > On Tue, Jun 25, 2024 at 06:38:12PM +0200, Marc Gonzalez wrote: > > > >> The TI TDP158 is an HDMI to TMDS Redriver. > >> > >> Signed-off-by: Marc Gonzalez > >> --- > >> .../bindings/display/bridge/ti,tdp158.yaml | 48 +++++++++++++= +++++++++ > >> 1 file changed, 48 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,tdp15= 8.yaml b/Documentation/devicetree/bindings/display/bridge/ti,tdp158.yaml > >> new file mode 100644 > >> index 0000000000000..b687699e2ba80 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/display/bridge/ti,tdp158.yaml > >> @@ -0,0 +1,48 @@ > >> +# SPDX-License-Identifier: GPL-2.0-only > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/display/bridge/ti,tdp158.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: TI TDP158 HDMI to TMDS Redriver > >> + > >> +maintainers: > >> + - Arnaud Vrac > >> + > >> +properties: > >> + compatible: > >> + const: ti,tdp158 > >> + > >> + reg: > >> + description: I2C address of the device > >> + > >> + enable-gpios: > >> + description: GPIO controlling bridge enable > >> + > >> + vcc-supply: > >> + description: Power supply 3.3V > >> + > >> + vdd-supply: > >> + description: Power supply 1.1V > >=20 > > Are these supplies not also required? Surely the device needs the power > > to function? >=20 > Maybe if the hamsters spin fast enough in their wheels, > these supplies won't be required? :) >=20 > The reason I hesitated to mark them as required, > is because the HW engineer told us that on our board > they were connected to a power line that is shared > between several functional blocks. >=20 > I suppose that's not a reason? Then all of those blocks should have their supplies described in the devicetree! FWIW, if you don't put them in your dts, you'll get validation failures but the regulator core will produce dummy regulators so your driver should "just workTM". I'd suggest that you add the supplies though to these other functional blocks so that the OS can manage them properly. > Required means "device doesn't work if they're not connected" ? Correct. Thanks, Conor. --51j+MB7mBaap5O9i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZn2QPQAKCRB4tDGHoIJi 0i6XAQChdyjhbaQztpw+CtTA1/jCwob7Fi1bMxWkvk9HlRCwTgEAvCKfze8ePxUC qM4DvTLH0GmtnZV0kZoAeKfijK9ngww= =+dA0 -----END PGP SIGNATURE----- --51j+MB7mBaap5O9i--