Re: [PATCH v3 1/3] dt-bindings: iio: accel: add ADXL380

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3341 bytes --]

On Thu, Jun 27, 2024 at 01:25:17PM +0300, Antoniu Miclaus wrote:
> Add dt-bindings for ADXL380/ADLX382 low noise density, low
> power, 3-axis accelerometer with selectable measurement ranges.
> 
> Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> changes in v3:
>  - add power support
>  - add support for both interrupts
>  .../bindings/iio/accel/adi,adxl380.yaml       | 103 ++++++++++++++++++
>  MAINTAINERS                                   |   7 ++
>  2 files changed, 110 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adxl380.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl380.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl380.yaml
> new file mode 100644
> index 000000000000..55e25a9b31ac
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl380.yaml
> @@ -0,0 +1,103 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/accel/adi,adxl380.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices ADXL380/382 3-Axis Digital Accelerometer
> +
> +maintainers:
> +  - Ramona Gradinariu <ramona.gradinariu@analog.com>
> +  - Antoniu Miclaus <antoniu.miclaus@analog.com>
> +
> +description: |
> +  The ADXL380/ADXL382 is a low noise density, low power, 3-axis
> +  accelerometer with selectable measurement ranges. The ADXL380
> +  supports the ±4 g, ±8 g, and ±16 g ranges, and the ADXL382 supports
> +  ±15 g, ±30 g, and ±60 g ranges.
> +  The ADXL380/ADXL382 offers industry leading noise, enabling precision
> +  applications with minimal calibration. The low noise, and low power
> +  ADXL380/ADXL382 enables accurate measurement in an environment with
> +  high vibration, heart sounds and audio.
> +
> +  In addition to its low power consumption, the ADXL380/ADXL382 has
> +  many features to enable true system level performance. These
> +  include a built-in micropower temperature sensor, single / double /
> +  triple tap detection and a state machine to prevent a false
> +  triggering. In addition, the ADXL380/ADXL382 has provisions for
> +  external control of the sampling time and/or an external clock.

Please cull the marketing from the descriptions. "Industry leading" may
or may not be accurate at the time of going to print, but might be
completely incorrect in 5 years. Ditto "low power consumption".

With the marketing gone,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

> diff --git a/MAINTAINERS b/MAINTAINERS
> index be590c462d91..1425182c85e2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -618,6 +618,13 @@ F:	drivers/iio/accel/adxl372.c
>  F:	drivers/iio/accel/adxl372_i2c.c
>  F:	drivers/iio/accel/adxl372_spi.c
>  
> +ADXL380 THREE-AXIS DIGITAL ACCELEROMETER DRIVER
> +M:	Ramona Gradinariu <ramona.gradinariu@analog.com>
> +M:	Antoniu Miclaus <antoniu.miclaus@analog.com>
> +S:	Supported
> +W:	https://ez.analog.com/linux-software-drivers

Seems like having a website like
https://wiki.analog.com/resources/tools-software/linux-drivers/input-misc/adxl345
would make more sense than a generic forum for all of your drivers?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]