From: Lee Jones <lee@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Jacky Huang <ychuang3@nuvoton.com>,
Shan-Chun Hung <schung@nuvoton.com>,
Khuong Dinh <khuong@os.amperecomputing.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chuanhua Lei <lchuanhua@maxlinear.com>,
Rahul Tanwar <rtanwar@maxlinear.com>,
Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
Daniel Machon <daniel.machon@microchip.com>,
UNGLinuxDriver@microchip.com, Nishanth Menon <nm@ti.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Conor Dooley <conor.dooley@microchip.com>,
Rahul Tanwar <rahul.tanwar@linux.intel.com>,
Amireddy Mallikarjuna reddy <mallikarjunax.reddy@intel.com>,
"Zhu, Yi Xin" <Yixin.zhu@intel.com>,
Maxime Ripard <mripard@kernel.org>
Subject: Re: [PATCH v3 0/7] dt-bindings: mfd: syscon: Document more compatibles and require simpe-mfd description
Date: Thu, 27 Jun 2024 09:18:53 +0100 [thread overview]
Message-ID: <20240627081853.GF2532839@google.com> (raw)
In-Reply-To: <20240626-dt-bindings-mfd-syscon-split-v3-0-3409903bb99b@linaro.org>
On Wed, 26 Jun 2024, Krzysztof Kozlowski wrote:
> Hi,
>
> Dependency
> ==========
> Rebased on Lee's MFD tree, because dependency is there already:
> https://lore.kernel.org/all/171828959006.2643902.8308227314531523435.b4-ty@kernel.org/
>
> Merging
> =======
> Preferrably everything via MFD tree (file/context dependencies).
>
> Changes in v3
> =============
> - Add tags
> - intel,lgm-syscon: change maintainers (email bounce)
> - syscon/Split: drop unneeded |, use const instead of enum in select:
> - Link to v2: https://lore.kernel.org/r/20240616-dt-bindings-mfd-syscon-split-v2-0-571b5850174a@linaro.org
>
> Changes in v2
> =============
> - Add acks
> - lgm-syscon: add ranges to binding and example
> - syscon.yaml: add big select with all compatibles for older dtschema
> - Link to v1: https://lore.kernel.org/r/20240519-dt-bindings-mfd-syscon-split-v1-0-aaf996e2313a@linaro.org
>
> Description/problem
> ===================
> Simple syscon nodes can be documented in common syscon.yaml, however
> devices with simple-mfd compatible, thus some children, should have
> their own schema listing these children. Such listing makes the binding
> specific, allows better validation (so the incorrect child would not
> appear in the simple-mfd node) and actually enforces repeated rule for
> simple-mfd devices:
>
> "simple-mfd" is only for simple devices, where the children do not
> depend on the parent.
>
> Currently the syscon+simple-mfd binding is quite broad and allows
> any child or property, thus above rule cannot be enforced.
>
> Solution
> ========
> 1. Split the syscon.yaml binding into common syscon properties, used
> potentially by many bindings, and only simple syscon devices (NO
> simple-mfd!).
> 2. Move some known simple-mfd bindings from syscon.yaml to dedicated
> files.
>
> This patchset might introduce new dtbs_check warnings for devices having
> simple-mfd and being part of syscon.yaml previously. I fixed some of
> them, but probably not all.
>
> Best regards,
> Krzysztof
>
> To: Lee Jones <lee@kernel.org>
> To: Rob Herring <robh@kernel.org>
> To: Krzysztof Kozlowski <krzk+dt@kernel.org>
> To: Conor Dooley <conor+dt@kernel.org>
> To: Lars Povlsen <lars.povlsen@microchip.com>
> To: Steen Hegelund <Steen.Hegelund@microchip.com>
> To: Daniel Machon <daniel.machon@microchip.com>
> To: UNGLinuxDriver@microchip.com
> To: Nishanth Menon <nm@ti.com>
> To: Matthias Brugger <matthias.bgg@gmail.com>
> To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-mediatek@lists.infradead.org
>
> ---
> Krzysztof Kozlowski (7):
> dt-bindings: mfd: syscon: Drop hwlocks
> dt-bindings: soc: sprd: sc9863a-glbregs: Document SC9863A syscon
> dt-bindings: soc: intel: lgm-syscon: Move to dedicated schema
> dt-bindings: soc: microchip: sparx5-cpu-syscon: Move to dedicated schema
> dt-bindings: soc: ti: am654-serdes-ctrl: Move to dedicated schema
> dt-bindings: mfd: syscon: Split and enforce documenting MFD children
> dt-bindings: mfd: syscon: Add APM poweroff mailbox
>
> .../devicetree/bindings/mfd/syscon-common.yaml | 71 +++++
> Documentation/devicetree/bindings/mfd/syscon.yaml | 306 ++++++++++++---------
> .../bindings/soc/intel/intel,lgm-syscon.yaml | 57 ++++
> .../soc/microchip/microchip,sparx5-cpu-syscon.yaml | 49 ++++
> .../bindings/soc/sprd/sprd,sc9863a-glbregs.yaml | 55 ++++
> .../bindings/soc/ti/ti,am654-serdes-ctrl.yaml | 42 +++
> 6 files changed, 457 insertions(+), 123 deletions(-)
> ---
> base-commit: 8dc7c29f608649f3d9eca826e9d4fe4b8a32c472
> change-id: 20240517-dt-bindings-mfd-syscon-split-37e23996523d
Okay, I tried to apply these whilst fixing up all the conflicts, but
lost the will to live. Please rebase and [RESEND].
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-06-27 8:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 10:09 [PATCH v3 0/7] dt-bindings: mfd: syscon: Document more compatibles and require simpe-mfd description Krzysztof Kozlowski
2024-06-26 10:09 ` [PATCH v3 1/7] dt-bindings: mfd: syscon: Drop hwlocks Krzysztof Kozlowski
2024-06-26 10:09 ` [PATCH v3 2/7] dt-bindings: soc: sprd: sc9863a-glbregs: Document SC9863A syscon Krzysztof Kozlowski
2024-06-26 10:09 ` [PATCH v3 3/7] dt-bindings: soc: intel: lgm-syscon: Move to dedicated schema Krzysztof Kozlowski
2024-06-26 10:09 ` [PATCH v3 4/7] dt-bindings: soc: microchip: sparx5-cpu-syscon: " Krzysztof Kozlowski
2024-06-26 10:09 ` [PATCH v3 5/7] dt-bindings: soc: ti: am654-serdes-ctrl: " Krzysztof Kozlowski
2024-06-26 10:09 ` [PATCH v3 6/7] dt-bindings: mfd: syscon: Split and enforce documenting MFD children Krzysztof Kozlowski
2024-06-26 10:09 ` [PATCH v3 7/7] dt-bindings: mfd: syscon: Add APM poweroff mailbox Krzysztof Kozlowski
2024-06-27 8:18 ` Lee Jones [this message]
2024-06-27 10:24 ` [PATCH v3 0/7] dt-bindings: mfd: syscon: Document more compatibles and require simpe-mfd description Krzysztof Kozlowski
2024-06-27 10:26 ` Krzysztof Kozlowski
2024-06-28 8:09 ` Lee Jones
2024-06-28 14:30 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240627081853.GF2532839@google.com \
--to=lee@kernel.org \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Yixin.zhu@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=daniel.machon@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=khuong@os.amperecomputing.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars.povlsen@microchip.com \
--cc=lchuanhua@maxlinear.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mallikarjunax.reddy@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=nm@ti.com \
--cc=orsonzhai@gmail.com \
--cc=rahul.tanwar@linux.intel.com \
--cc=robh@kernel.org \
--cc=rtanwar@maxlinear.com \
--cc=schung@nuvoton.com \
--cc=ychuang3@nuvoton.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).