From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 045FA1991BB; Thu, 27 Jun 2024 15:56:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719503788; cv=none; b=Z2/Cjtzq1sD5eHfJjN6aKEE1XIYaRQgh4sGvG83go4IKuL2Ydt8Mrt7KPk5itAE4vhtYazIxFTp8UICKxTTo/hLsPwqODKP8JhxDW6AZyrC8oNHj7qjRQe5ilWjurexxhIVNThp3RKHVQsUk3D1k4MXNq6IxAG0/wJat8Nc1saU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719503788; c=relaxed/simple; bh=6dZaJznz0z/Um3prps8njOwBk/YYpaBXEvp4VEuRNjQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Otz7pWHJgu3XhM1CFtVjliqliU6fX5A3bfRluElF+bpmffufjrG4uEnTJPpSwFZKXNB+GYd1m7OLrLG13roZlweX6Uc2b/m1p7bBoBbTEodR7067U98xz+2X0A4ITzNRTcaN7xhkhT3aG6yiMGvlelTwlCm1E5tToJ/6vougp8Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org; spf=pass smtp.mailfrom=gentoo.org; arc=none smtp.client-ip=140.211.166.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gentoo.org Date: Thu, 27 Jun 2024 15:56:20 +0000 From: Yixun Lan To: Conor Dooley Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Lezcano , Thomas Gleixner , Samuel Holland , Anup Patel , Greg Kroah-Hartman , Jiri Slaby , Lubomir Rintel , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-riscv@lists.infradead.org, linux-serial@vger.kernel.org, Inochi Amaoto , Meng Zhang , Yangyu Chen Subject: Re: [PATCH v2 00/10] riscv: add initial support for SpacemiT K1 Message-ID: <20240627155620.GA1622265@ofsar> References: <20240627-k1-01-basic-dt-v2-0-cc06c7555f07@gentoo.org> <20240627-flinch-rented-1f2a2e5d73ca@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240627-flinch-rented-1f2a2e5d73ca@spud> Hi Conor: On 16:39 Thu 27 Jun , Conor Dooley wrote: > On Thu, Jun 27, 2024 at 03:31:14PM +0000, Yixun Lan wrote: > > SpacemiT K1 is an ideal chip for some new extension such as RISC-V Vector > > 1.0 and Zicond evaluation now. Add initial support for it to allow more > > people to participate in building drivers to mainline for it. > > > > This kernel has been tested upon Banana Pi BPI-F3 board on vendor U-Boot > > bootflow generated by Armbian SDK[1] and patched OpenSBI[2] to enable > > Zicboz, which does not in the vendor dts on its U-Boot. Then successfully > > booted to busybox on initrd with this log[3]. > > > > As previous discussion in patch v1[4], maintainer expect more basic drivers > > ready before really merging it, which would be fine. For other follow-up patches, > > that are clk, pinctrl/gpio, reset.. My current goal would target at a headless > > system including SD card, emmc, and ethernet. > > > > P.S: talked to Yangyu, I will help and take care of this patch series, thanks > > --- > > Changes in v2: > > - fix timebase-frequency according to current setting > > - add other uart dt nodes, fix input frequency > > - introduce new uart compatible for K1 SoC > > - add 'k1' prefix to bananapi-f3.dts > > - fix k1-clint compatible > > - fix some typos > > - Link to v1: https://lore.kernel.org/r/tencent_BC64B7B1876F5D10479BD19112F73F262505@qq.com > > I will take a closer look at this series later, but there's a few > patches here missing Acks that I gave alongside some nitpick remarks. > Could you look at v1 again and add those to whatever other comments I > leave when I take a closer look? > sure, thanks for your quick reply, I will do this tomorrow, and potentially wait all reviews, combine all tags I receive in v2, and address them in v3.. -- Yixun Lan (dlan) Gentoo Linux Developer GPG Key ID AABEFD55