[PATCH v2 0/2] Input: exc3000 - EXC81W32 controller support

[PATCH v2 0/2] Input: exc3000 - EXC81W32 controller support

[Philipp Zabel]

EXC81W32 controllers use the same protocol and have the same resolution
as the EXC80 controllers. They can be supported by the exc3000 driver
with minimal changes.

Their featureset may differ, though. Looking at the messages, it appears
the EXC81 also supports touch pressure or area measurement, for example.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
Changes in v2:
- split device tree binding compatible update out of the driver patch
- Link to v1: https://lore.kernel.org/r/20240626-input-exc3000-exc81w32-v1-1-ac42d3b87aff@pengutronix.de

---
Philipp Zabel (2):
      dt-bindings: input: touchscreen: exc3000: add EXC81W32
      Input: exc3000 - add EXC81W32 support

 .../devicetree/bindings/input/touchscreen/eeti,exc3000.yaml        | 1 +
 drivers/input/touchscreen/exc3000.c                                | 7 +++++++
 2 files changed, 8 insertions(+)
---
base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
change-id: 20240626-input-exc3000-exc81w32-58585ba4a98f

Best regards,
-- 
Philipp Zabel <p.zabel@pengutronix.de>

[PATCH v2 1/2] dt-bindings: input: touchscreen: exc3000: add EXC81W32

[Philipp Zabel]

Add compatible for EXC81W32 touchscreen controllers.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
v2: new patch, split out of driver patch
---
 Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml b/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml
index 9dc25d30a0a8..c299838e2680 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml
@@ -18,6 +18,7 @@ properties:
       - eeti,exc3000
       - eeti,exc80h60
       - eeti,exc80h84
+      - eeti,exc81w32
   reg:
     const: 0x2a
   interrupts:

-- 
2.39.2

Re: [PATCH v2 1/2] dt-bindings: input: touchscreen: exc3000: add EXC81W32

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]

On Fri, Jun 28, 2024 at 10:35:51AM +0200, Philipp Zabel wrote:
> Add compatible for EXC81W32 touchscreen controllers.

Could you please mention in your commit messages what makes a fallback
compatible inappropriate here?

Thanks,
Conor.

> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> v2: new patch, split out of driver patch
> ---
>  Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml b/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml
> index 9dc25d30a0a8..c299838e2680 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml
> @@ -18,6 +18,7 @@ properties:
>        - eeti,exc3000
>        - eeti,exc80h60
>        - eeti,exc80h84
> +      - eeti,exc81w32
>    reg:
>      const: 0x2a
>    interrupts:
> 
> -- 
> 2.39.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 1/2] dt-bindings: input: touchscreen: exc3000: add EXC81W32

[Philipp Zabel]

Hi Conor,

On Fr, 2024-06-28 at 17:21 +0100, Conor Dooley wrote:
> On Fri, Jun 28, 2024 at 10:35:51AM +0200, Philipp Zabel wrote:
> > Add compatible for EXC81W32 touchscreen controllers.
> 
> Could you please mention in your commit messages what makes a fallback
> compatible inappropriate here?

thank for pointing this out. Actually, I'm not sure a fallback
compatible is inappropriate at all. There just is none currently, even
though EXC80H60 and EXC80H84 already look compatible to me.

To my understanding, there's EXC80[WH]{32,46,60,84} models, that should
only differ in ball pitch (W or H) and targeted display size (the last
number).
I don't know if there are actual relevant differences between what I
assume are model generations, such as EXC80 to EXC81. At least the
limited currently implemented feature set in the exc3000 driver is
identical.

Given that EXC80H60, EXC80H84, and now EXC81W32 all share the same 16K
resolution and the same message format (possible differences in
capability to measure touch area nonwithstanding), should I prepend
this series with a patch:

@@ -14,10 +14,13 @@
 
 properties:
   compatible:
-    enum:
-      - eeti,exc3000
-      - eeti,exc80h60
-      - eeti,exc80h84
+    oneOf:
+      - const: eeti,exc3000
+      - items:
+          - enum:
+              - eeti,exc80h60
+          - const: eeti,exc80h84
+      - const: eeti,exc80h84
   reg:
     const: 0x2a
   interrupts:

regards
Philipp

Re: [PATCH v2 1/2] dt-bindings: input: touchscreen: exc3000: add EXC81W32

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1767 bytes --]

On Mon, Jul 01, 2024 at 02:47:50PM +0200, Philipp Zabel wrote:
> Hi Conor,
> 
> On Fr, 2024-06-28 at 17:21 +0100, Conor Dooley wrote:
> > On Fri, Jun 28, 2024 at 10:35:51AM +0200, Philipp Zabel wrote:
> > > Add compatible for EXC81W32 touchscreen controllers.
> > 
> > Could you please mention in your commit messages what makes a fallback
> > compatible inappropriate here?
> 
> thank for pointing this out. Actually, I'm not sure a fallback
> compatible is inappropriate at all. There just is none currently, even
> though EXC80H60 and EXC80H84 already look compatible to me.
> 
> To my understanding, there's EXC80[WH]{32,46,60,84} models, that should
> only differ in ball pitch (W or H) and targeted display size (the last
> number).
> I don't know if there are actual relevant differences between what I
> assume are model generations, such as EXC80 to EXC81. At least the
> limited currently implemented feature set in the exc3000 driver is
> identical.
> 
> Given that EXC80H60, EXC80H84, and now EXC81W32 all share the same 16K
> resolution and the same message format (possible differences in
> capability to measure touch area nonwithstanding), should I prepend
> this series with a patch:

If you're prepared to update the two users to avoid adding more
dtbs_check warnings, sure.

Thanks,
Conor.

> 
> @@ -14,10 +14,13 @@
>  
>  properties:
>    compatible:
> -    enum:
> -      - eeti,exc3000
> -      - eeti,exc80h60
> -      - eeti,exc80h84
> +    oneOf:
> +      - const: eeti,exc3000
> +      - items:
> +          - enum:
> +              - eeti,exc80h60
> +          - const: eeti,exc80h84
> +      - const: eeti,exc80h84
>    reg:
>      const: 0x2a
>    interrupts:
> 
> regards
> Philipp

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 1/2] dt-bindings: input: touchscreen: exc3000: add EXC81W32

[Philipp Zabel]

On Mo, 2024-07-01 at 15:42 +0100, Conor Dooley wrote:
> On Mon, Jul 01, 2024 at 02:47:50PM +0200, Philipp Zabel wrote:
> > Hi Conor,
> > 
> > On Fr, 2024-06-28 at 17:21 +0100, Conor Dooley wrote:
> > > On Fri, Jun 28, 2024 at 10:35:51AM +0200, Philipp Zabel wrote:
> > > > Add compatible for EXC81W32 touchscreen controllers.
> > > 
> > > Could you please mention in your commit messages what makes a fallback
> > > compatible inappropriate here?
> > 
> > thank for pointing this out. Actually, I'm not sure a fallback
> > compatible is inappropriate at all. There just is none currently, even
> > though EXC80H60 and EXC80H84 already look compatible to me.
> > 
> > To my understanding, there's EXC80[WH]{32,46,60,84} models, that should
> > only differ in ball pitch (W or H) and targeted display size (the last
> > number).
> > I don't know if there are actual relevant differences between what I
> > assume are model generations, such as EXC80 to EXC81. At least the
> > limited currently implemented feature set in the exc3000 driver is
> > identical.
> > 
> > Given that EXC80H60, EXC80H84, and now EXC81W32 all share the same 16K
> > resolution and the same message format (possible differences in
> > capability to measure touch area nonwithstanding), should I prepend
> > this series with a patch:
> 
> If you're prepared to update the two users to avoid adding more
> dtbs_check warnings, sure.

I'll follow up with another patch series, thanks.

regards
Philipp

[PATCH v2 2/2] Input: exc3000 - add EXC81W32 support

[Philipp Zabel]

Add support for EXC81W32 controllers.

Tested with firmware reported as type "PCAP81X32 Series",
model "Orion_0183_1019", fw_version "8001280G".

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
v2: split device tree binding compatible update out of this patch
---
 drivers/input/touchscreen/exc3000.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/input/touchscreen/exc3000.c b/drivers/input/touchscreen/exc3000.c
index a4030cc9ff60..2e77cfb63f32 100644
--- a/drivers/input/touchscreen/exc3000.c
+++ b/drivers/input/touchscreen/exc3000.c
@@ -53,6 +53,7 @@ enum eeti_dev_id {
 	EETI_EXC3000,
 	EETI_EXC80H60,
 	EETI_EXC80H84,
+	EETI_EXC81W32,
 };
 
 static struct eeti_dev_info exc3000_info[] = {
@@ -68,6 +69,10 @@ static struct eeti_dev_info exc3000_info[] = {
 		.name = "EETI EXC80H84 Touch Screen",
 		.max_xy = SZ_16K - 1,
 	},
+	[EETI_EXC81W32] = {
+		.name = "EETI EXC81W32 Touch Screen",
+		.max_xy = SZ_16K - 1,
+	},
 };
 
 struct exc3000_data {
@@ -441,6 +446,7 @@ static const struct i2c_device_id exc3000_id[] = {
 	{ "exc3000", EETI_EXC3000 },
 	{ "exc80h60", EETI_EXC80H60 },
 	{ "exc80h84", EETI_EXC80H84 },
+	{ "exc81w32", EETI_EXC81W32 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, exc3000_id);
@@ -450,6 +456,7 @@ static const struct of_device_id exc3000_of_match[] = {
 	{ .compatible = "eeti,exc3000", .data = &exc3000_info[EETI_EXC3000] },
 	{ .compatible = "eeti,exc80h60", .data = &exc3000_info[EETI_EXC80H60] },
 	{ .compatible = "eeti,exc80h84", .data = &exc3000_info[EETI_EXC80H84] },
+	{ .compatible = "eeti,exc81w32", .data = &exc3000_info[EETI_EXC81W32] },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, exc3000_of_match);

-- 
2.39.2