* [PATCH 1/1] dt-bindings: can: fsl,flexcan: add can-transceiver for fsl,flexcan
@ 2024-06-25 20:31 Frank Li
2024-06-26 8:19 ` Krzysztof Kozlowski
2024-06-28 21:41 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Frank Li @ 2024-06-25 20:31 UTC (permalink / raw)
To: Marc Kleine-Budde, Vincent Mailhol, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, open list:CAN NETWORK DRIVERS,
open list:NETWORKING DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
Add 'can-transceiver' children node for fsl,flexcan to allow update
can-transceiver property.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
index f197d9b516bb2..d003200247b03 100644
--- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
+++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
@@ -80,6 +80,9 @@ properties:
node then controller is assumed to be little endian. If this property is
present then controller is assumed to be big endian.
+ can-transceiver:
+ $ref: can-transceiver.yaml#
+
fsl,stop-mode:
description: |
Register bits of stop mode control.
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] dt-bindings: can: fsl,flexcan: add can-transceiver for fsl,flexcan
2024-06-25 20:31 [PATCH 1/1] dt-bindings: can: fsl,flexcan: add can-transceiver for fsl,flexcan Frank Li
@ 2024-06-26 8:19 ` Krzysztof Kozlowski
2024-06-26 16:29 ` Frank Li
2024-06-28 21:41 ` Rob Herring
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-26 8:19 UTC (permalink / raw)
To: Frank Li, Marc Kleine-Budde, Vincent Mailhol, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, open list:CAN NETWORK DRIVERS,
open list:NETWORKING DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
On 25/06/2024 22:31, Frank Li wrote:
> Add 'can-transceiver' children node for fsl,flexcan to allow update
> can-transceiver property.
I don't understand. Who and how updates can-transceiver property? What
is can-transceiver property (I assume you speak about something
different than child node)?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] dt-bindings: can: fsl,flexcan: add can-transceiver for fsl,flexcan
2024-06-26 8:19 ` Krzysztof Kozlowski
@ 2024-06-26 16:29 ` Frank Li
0 siblings, 0 replies; 4+ messages in thread
From: Frank Li @ 2024-06-26 16:29 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Marc Kleine-Budde, Vincent Mailhol, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, open list:CAN NETWORK DRIVERS,
open list:NETWORKING DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Wed, Jun 26, 2024 at 10:19:56AM +0200, Krzysztof Kozlowski wrote:
> On 25/06/2024 22:31, Frank Li wrote:
> > Add 'can-transceiver' children node for fsl,flexcan to allow update
> > can-transceiver property.
>
> I don't understand. Who and how updates can-transceiver property? What
> is can-transceiver property (I assume you speak about something
> different than child node)?
can-transceiver is chhild node. dts like this
&can0 {
status = "okay";
can-transceiver {
max-bitrate = <5000000>;
};
};
Or, I can simple said
"Add 'can-transceiver' children node for fsl,flexcan."
'can-transceiver' should be common child node for CAN node.
Frank
>
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] dt-bindings: can: fsl,flexcan: add can-transceiver for fsl,flexcan
2024-06-25 20:31 [PATCH 1/1] dt-bindings: can: fsl,flexcan: add can-transceiver for fsl,flexcan Frank Li
2024-06-26 8:19 ` Krzysztof Kozlowski
@ 2024-06-28 21:41 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2024-06-28 21:41 UTC (permalink / raw)
To: Frank Li
Cc: Marc Kleine-Budde, Vincent Mailhol, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Krzysztof Kozlowski, Conor Dooley,
open list:CAN NETWORK DRIVERS, open list:NETWORKING DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Tue, Jun 25, 2024 at 04:31:45PM -0400, Frank Li wrote:
> Add 'can-transceiver' children node for fsl,flexcan to allow update
> can-transceiver property.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> index f197d9b516bb2..d003200247b03 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> +++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> @@ -80,6 +80,9 @@ properties:
> node then controller is assumed to be little endian. If this property is
> present then controller is assumed to be big endian.
>
> + can-transceiver:
> + $ref: can-transceiver.yaml#
unevaluatedProperties: false
> +
> fsl,stop-mode:
> description: |
> Register bits of stop mode control.
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-28 21:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-25 20:31 [PATCH 1/1] dt-bindings: can: fsl,flexcan: add can-transceiver for fsl,flexcan Frank Li
2024-06-26 8:19 ` Krzysztof Kozlowski
2024-06-26 16:29 ` Frank Li
2024-06-28 21:41 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).