From: Jonathan Cameron <jic23@kernel.org>
To: Guillaume Stols <gstols@baylibre.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Beniamin Bia <beniamin.bia@analog.com>,
Stefan Popa <stefan.popa@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
jstephan@baylibre.com, dlechner@baylibre.com
Subject: Re: [PATCH v2 05/10] dt-bindings: iio: adc: adi,ad7606: add supply properties
Date: Sat, 29 Jun 2024 16:30:43 +0100 [thread overview]
Message-ID: <20240629163043.5e96e80c@jic23-huawei> (raw)
In-Reply-To: <20240628-cleanup-ad7606-v2-5-96e02f90256d@baylibre.com>
On Fri, 28 Jun 2024 14:48:23 +0000
Guillaume Stols <gstols@baylibre.com> wrote:
> Add voltage supplies
>
> Signed-off-by: Guillaume Stols <gstols@baylibre.com>
Trivial comment inline. No need to reroll for that though.
> ---
> Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> index 509970922cda..a1c38a5812f7 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> @@ -35,6 +35,15 @@ properties:
>
> avcc-supply: true
>
> + vdrive-supply:
> + description:
> + Determines the voltage level at which the interface logic pins will
> + operate.
> +
> + refin-supply:
> + description:
> + The voltage supply for optional external reference voltage.
> +
> interrupts:
> description:
> The BUSY pin falling edge indicates that the conversion is over, and thus
> @@ -106,9 +115,11 @@ required:
> - reg
> - spi-cpha
> - avcc-supply
> + - vdrive-supply
> - interrupts
> - adi,conversion-start-gpios
>
> +
Unrelated white space change. Remember to check patches for these.
If whitespace changes are needed have an additional patch that just does
that.
> allOf:
> - $ref: /schemas/spi/spi-peripheral-props.yaml#
>
> @@ -130,6 +141,7 @@ examples:
> spi-cpha;
>
> avcc-supply = <&adc_vref>;
> + vdrive-supply = <&vdd_supply>;
>
> interrupts = <25 IRQ_TYPE_EDGE_FALLING>;
> interrupt-parent = <&gpio>;
>
next prev parent reply other threads:[~2024-06-29 15:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 14:48 [PATCH v2 00/10] iio: adc: ad7606: Improvements Guillaume Stols
2024-06-28 14:48 ` [PATCH v2 01/10] dt-bindings: iio: adc: adi,ad7606: add missing datasheet link Guillaume Stols
2024-06-29 15:18 ` Jonathan Cameron
2024-06-28 14:48 ` [PATCH v2 02/10] dt-bindings: iio: adc: adi,ad7606: comment and sort the compatible names Guillaume Stols
2024-06-29 15:22 ` Jonathan Cameron
2024-06-30 14:00 ` Conor Dooley
2024-06-28 14:48 ` [PATCH v2 03/10] dt-bindings: iio: adc: adi,ad7606: normalize textwidth Guillaume Stols
2024-07-01 17:13 ` Rob Herring (Arm)
2024-06-28 14:48 ` [PATCH v2 04/10] dt-bindings: iio: adc: adi,ad7606: improve descriptions Guillaume Stols
2024-06-29 15:29 ` Jonathan Cameron
2024-07-01 17:19 ` Rob Herring (Arm)
2024-06-28 14:48 ` [PATCH v2 05/10] dt-bindings: iio: adc: adi,ad7606: add supply properties Guillaume Stols
2024-06-29 15:30 ` Jonathan Cameron [this message]
2024-06-28 14:48 ` [PATCH v2 06/10] dt-bindings: iio: adc: adi,ad7606: fix example Guillaume Stols
2024-06-28 14:48 ` [PATCH v2 07/10] dt-bindings: iio: adc: adi,ad7606: add conditions Guillaume Stols
2024-06-28 15:15 ` Conor Dooley
2024-06-28 14:48 ` [PATCH v2 08/10] iio: adc: ad7606: fix oversampling gpio array Guillaume Stols
2024-06-28 14:48 ` [PATCH v2 09/10] iio: adc: ad7606: fix standby gpio state to match the documentation Guillaume Stols
2024-06-28 14:48 ` [PATCH v2 10/10] iio: adc: ad7606: switch mutexes to scoped_guard Guillaume Stols
2024-06-29 15:36 ` Jonathan Cameron
2024-06-28 15:53 ` [PATCH v2 00/10] iio: adc: ad7606: Improvements Conor Dooley
2024-06-28 15:55 ` Conor Dooley
2024-06-29 15:38 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240629163043.5e96e80c@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=beniamin.bia@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=gstols@baylibre.com \
--cc=jstephan@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).