From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3267014B947; Mon, 1 Jul 2024 17:17:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719854269; cv=none; b=P5yWlM+SnV1gkW41gmCHbnSTbld8iMaDi9sPrgPtNJxnkGlQ82ViU6IhZgdPZYDhw8FPh221BCK1hohbJ3yOQbvRcPINCQO9hA9PlqoP0Y4KBwQorQhLtR8dMoXSEU2vko1y4tz9TEl1GbGEwBgAk4XEFk8QpQXK84K/ykbaUKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719854269; c=relaxed/simple; bh=wcPmXYJTY/CZ/O9Vqbj7WeF4g6HD757l9DFr+Lr3X9Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jozwk3RnL8d2D1NFXTxf8eY0Q95E6TonH3+TRSQUVRLk25tGfP5GDlZFSRj+1d4Ju8IMfR3EZqUKjHiIjKlQNNrQaDGLDhrwoxzWYSDIBRU22YTnE3RbnpybqgzIhno3mJCu0TvacR5ANGd1TKQPkSkDoJegX2vwd8pZY0s5JlU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bolHJ7sr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bolHJ7sr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EFA6C32781; Mon, 1 Jul 2024 17:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719854268; bh=wcPmXYJTY/CZ/O9Vqbj7WeF4g6HD757l9DFr+Lr3X9Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bolHJ7srqPaWrIl0M7Fhi0mOI0NKVup0Hn+YS7KAXpRUutabBFd/cH9HhGpudTeV/ uv7e/pJWjXF0xIqIObZEzLmCVLiROKFrGY9DclRq3vLFsIUpgSqiHA0cZI98b2e+4Z 9NR7tE9tBEhkO/K/FxFFvCqoNoeVsQTtxPBWrGQA/qfrasM5+dcfBILq8bafUqDlb+ 3nN9ZqhY/IiImL76A6ncDncuO2j6H7FX9HwEVXiGc2kMJobxe4BipfR3drCZjsKz/a rdnYQUqY5DTQYSGdHyEPhwLSnmdKgle8x7vli2BEMW9E1E1L4giRA11pdFU06OqdZl WyauZ5knxF9Rw== Date: Mon, 1 Jul 2024 11:17:47 -0600 From: Rob Herring To: Jonathan Cameron Cc: AngeloGioacchino Del Regno , lars@metafoo.de, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, lee@kernel.org, andy@kernel.org, nuno.sa@analog.com, bigunclemax@gmail.com, dlechner@baylibre.com, marius.cristea@microchip.com, marcelo.schmitt@analog.com, fr0st61te@gmail.com, mitrutzceclan@gmail.com, mike.looijmans@topic.nl, marcus.folkesson@gmail.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, andy.shevchenko@gmail.com, kernel@collabora.com Subject: Re: [PATCH v2 1/5] dt-bindings: iio: adc: Add MediaTek MT6359 PMIC AUXADC Message-ID: <20240701171747.GA133215-robh@kernel.org> References: <20240604123008.327424-1-angelogioacchino.delregno@collabora.com> <20240604123008.327424-2-angelogioacchino.delregno@collabora.com> <20240605235239.GA3455504-robh@kernel.org> <20240617203314.641e84a9@jic23-huawei> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240617203314.641e84a9@jic23-huawei> On Mon, Jun 17, 2024 at 08:33:14PM +0100, Jonathan Cameron wrote: > On Mon, 10 Jun 2024 10:00:55 +0200 > AngeloGioacchino Del Regno wrote: > > > Il 06/06/24 01:52, Rob Herring ha scritto: > > > On Tue, Jun 04, 2024 at 02:30:04PM +0200, AngeloGioacchino Del Regno wrote: > > >> Add a new binding for the MT6350 Series (MT6357/8/9) PMIC AUXADC, > > >> providing various ADC channels for both internal temperatures and > > >> voltages, audio accessory detection (hp/mic/hp+mic and buttons, > > >> usually on a 3.5mm jack) other than some basic battery statistics > > >> on boards where the battery is managed by this PMIC. > > >> > > >> Also add the necessary dt-binding headers for devicetree consumers. > > >> > > >> Signed-off-by: AngeloGioacchino Del Regno > > >> --- > > >> .../iio/adc/mediatek,mt6359-auxadc.yaml | 33 +++++++++++++++++++ > > >> .../iio/adc/mediatek,mt6357-auxadc.h | 21 ++++++++++++ > > >> .../iio/adc/mediatek,mt6358-auxadc.h | 22 +++++++++++++ > > >> .../iio/adc/mediatek,mt6359-auxadc.h | 22 +++++++++++++ > > >> 4 files changed, 98 insertions(+) > > >> create mode 100644 Documentation/devicetree/bindings/iio/adc/mediatek,mt6359-auxadc.yaml > > >> create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6357-auxadc.h > > >> create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6358-auxadc.h > > >> create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6359-auxadc.h > > >> > > >> diff --git a/Documentation/devicetree/bindings/iio/adc/mediatek,mt6359-auxadc.yaml b/Documentation/devicetree/bindings/iio/adc/mediatek,mt6359-auxadc.yaml > > >> new file mode 100644 > > >> index 000000000000..6497c416094d > > >> --- /dev/null > > >> +++ b/Documentation/devicetree/bindings/iio/adc/mediatek,mt6359-auxadc.yaml > > >> @@ -0,0 +1,33 @@ > > >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > >> +%YAML 1.2 > > >> +--- > > >> +$id: http://devicetree.org/schemas/iio/adc/mediatek,mt6359-auxadc.yaml# > > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > > >> + > > >> +title: MediaTek MT6350 series PMIC AUXADC > > >> + > > >> +maintainers: > > >> + - AngeloGioacchino Del Regno > > >> + > > >> +description: > > >> + The Auxiliary Analog/Digital Converter (AUXADC) is an ADC found > > >> + in some MediaTek PMICs, performing various PMIC related measurements > > >> + such as battery and PMIC internal voltage regulators temperatures, > > >> + accessory detection resistance (usually, for a 3.5mm audio jack) > > >> + other than voltages for various PMIC internal components. > > >> + > > >> +properties: > > >> + compatible: > > >> + enum: > > >> + - mediatek,mt6357-auxadc > > >> + - mediatek,mt6358-auxadc > > >> + - mediatek,mt6359-auxadc > > >> + > > >> + "#io-channel-cells": > > >> + const: 1 > > > > > > Why do you need a node here? Just add #io-channel-cells to the parent > > > node. > > > > > > > Because some boards will want to avoid probing the related driver, as that will > > trigger a reset and this may not play well with ECs (namely, some Chromebooks), > > which are reading the same AUXADC block. > > > > If I avoid using a new node, instead of just using `status`, I'll have to add a > > "mediatek,disable-auxadc" property to the parent node, which isn't pretty... > > Rob, does this answer the question to your satisfaction? > > If you are fine with this I'd like to queue it up (with the typo in one of the > patch descriptions that Andy caught fixed up). Yes. Reviewed-by: Rob Herring