* [PATCH v1 1/3] dt-bindings: vendor-prefixes: Add prefix for ieisystems
@ 2024-07-01 10:52 George Liu
2024-07-01 10:52 ` [PATCH v1 2/3] dt-bindings: arm: aspeed: add IEIT x86 platform BMC boards George Liu
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: George Liu @ 2024-07-01 10:52 UTC (permalink / raw)
To: linux-aspeed
Cc: devicetree, openbmc, linux-kernel, robh+dt, linux-arm-kernel,
krzysztof.kozlowski+dt, conor+dt, joel, andrew
Add a vendor prefix entry for ieisystems
Signed-off-by: George Liu <liuxiwei@ieisystem.com>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 573578db9509..0ffa8d06aea9 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -609,6 +609,8 @@ patternProperties:
description: IC Plus Corp.
"^idt,.*":
description: Integrated Device Technologies, Inc.
+ "^ieit,.*":
+ description: IEIT SYSTEMS Co.，Ltd.
"^ifi,.*":
description: Ingenieurburo Fur Ic-Technologie (I/F/I)
"^ilitek,.*":
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v1 2/3] dt-bindings: arm: aspeed: add IEIT x86 platform BMC boards 2024-07-01 10:52 [PATCH v1 1/3] dt-bindings: vendor-prefixes: Add prefix for ieisystems George Liu @ 2024-07-01 10:52 ` George Liu 2024-07-01 15:03 ` Conor Dooley 2024-07-01 10:52 ` [PATCH v1 3/3] ARM: dts: aspeed: Add IEISystems NF5280M7 BMC machine George Liu ` (2 subsequent siblings) 3 siblings, 1 reply; 7+ messages in thread From: George Liu @ 2024-07-01 10:52 UTC (permalink / raw) To: linux-aspeed Cc: devicetree, openbmc, linux-kernel, robh+dt, linux-arm-kernel, krzysztof.kozlowski+dt, conor+dt, joel, andrew Document the new compatibles used on the ieisystems Signed-off-by: George Liu <liuxiwei@ieisystem.com> --- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index e386d0ebfb14..818fbe9c45fc 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml @@ -92,6 +92,7 @@ properties: - ibm,rainier-bmc - ibm,system1-bmc - ibm,tacoma-bmc + - ieit,nf5280m7-bmc - inventec,starscream-bmc - inventec,transformer-bmc - jabil,rbp-bmc -- 2.34.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v1 2/3] dt-bindings: arm: aspeed: add IEIT x86 platform BMC boards 2024-07-01 10:52 ` [PATCH v1 2/3] dt-bindings: arm: aspeed: add IEIT x86 platform BMC boards George Liu @ 2024-07-01 15:03 ` Conor Dooley 0 siblings, 0 replies; 7+ messages in thread From: Conor Dooley @ 2024-07-01 15:03 UTC (permalink / raw) To: George Liu Cc: linux-aspeed, devicetree, openbmc, linux-kernel, robh+dt, linux-arm-kernel, krzysztof.kozlowski+dt, conor+dt, joel, andrew [-- Attachment #1: Type: text/plain, Size: 1032 bytes --] On Mon, Jul 01, 2024 at 06:52:58PM +0800, George Liu wrote: > Document the new compatibles used on the ieisystems > > Signed-off-by: George Liu <liuxiwei@ieisystem.com> > --- > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > index e386d0ebfb14..818fbe9c45fc 100644 > --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > @@ -92,6 +92,7 @@ properties: > - ibm,rainier-bmc > - ibm,system1-bmc > - ibm,tacoma-bmc > + - ieit,nf5280m7-bmc This is a singular item, but your commit message's $body and $subject both sound plural. Is that intentional? > - inventec,starscream-bmc > - inventec,transformer-bmc > - jabil,rbp-bmc > -- > 2.34.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v1 3/3] ARM: dts: aspeed: Add IEISystems NF5280M7 BMC machine 2024-07-01 10:52 [PATCH v1 1/3] dt-bindings: vendor-prefixes: Add prefix for ieisystems George Liu 2024-07-01 10:52 ` [PATCH v1 2/3] dt-bindings: arm: aspeed: add IEIT x86 platform BMC boards George Liu @ 2024-07-01 10:52 ` George Liu 2024-07-02 10:47 ` Krzysztof Kozlowski 2024-07-01 18:29 ` [PATCH v1 1/3] dt-bindings: vendor-prefixes: Add prefix for ieisystems Rob Herring 2024-07-01 18:31 ` Rob Herring 3 siblings, 1 reply; 7+ messages in thread From: George Liu @ 2024-07-01 10:52 UTC (permalink / raw) To: linux-aspeed Cc: devicetree, openbmc, linux-kernel, robh+dt, linux-arm-kernel, krzysztof.kozlowski+dt, conor+dt, joel, andrew The IEISystems NF5280M7 is an x86 platform server with an AST2600-based BMC. This dts file provides a basic configuration for its OpenBMC development. Signed-off-by: George Liu <liuxiwei@ieisystem.com> --- arch/arm/boot/dts/aspeed/Makefile | 1 + .../aspeed/aspeed-bmc-ieisystems-nf5280m7.dts | 659 ++++++++++++++++++ 2 files changed, 660 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ieisystems-nf5280m7.dts diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile index 5e3392621697..51531d494415 100644 --- a/arch/arm/boot/dts/aspeed/Makefile +++ b/arch/arm/boot/dts/aspeed/Makefile @@ -40,6 +40,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-ibm-rainier-1s4u.dtb \ aspeed-bmc-ibm-rainier-4u.dtb \ aspeed-bmc-ibm-system1.dtb \ + aspeed-bmc-ieisystems-nf5280m7.dtb \ aspeed-bmc-intel-s2600wf.dtb \ aspeed-bmc-inspur-fp5280g2.dtb \ aspeed-bmc-inspur-nf5280m6.dtb \ diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ieisystems-nf5280m7.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ieisystems-nf5280m7.dts new file mode 100644 index 000000000000..a17cf9cdba0e --- /dev/null +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ieisystems-nf5280m7.dts @@ -0,0 +1,659 @@ +// SPDX-License-Identifier: GPL-2.0+ +// Copyright (c) 2023 IEISystems Corporation + +/dts-v1/; + +#include "aspeed-g6.dtsi" +#include <dt-bindings/gpio/aspeed-gpio.h> +#include <dt-bindings/leds/leds-pca955x.h> +#include <dt-bindings/i2c/i2c.h> + +/ { + model = "NF5280M7 BMC"; + compatible = "ieisystems,nf5280m7-bmc", "aspeed,ast2600"; + aliases { + i2c200 = &bus2_mux70_0; + i2c500 = &bus5_mux00; + i2c501 = &bus5_mux01; + i2c600 = &i2c6s0ch0; + i2c601 = &i2c6s0ch1; + i2c602 = &i2c6s0ch2; + i2c603 = &i2c6s0ch3; + i2c604 = &i2c6s0ch4; + i2c605 = &i2c6s0ch5; + i2c606 = &i2c6s0ch6; + i2c607 = &i2c6s0ch7; + i2c610 = &i2c6s1ch0; + i2c611 = &i2c6s1ch1; + i2c612 = &i2c6s1ch2; + i2c613 = &i2c6s1ch3; + i2c614 = &i2c6s1ch4; + i2c615 = &i2c6s1ch5; + i2c616 = &i2c6s1ch6; + i2c617 = &i2c6s1ch7; + i2c620 = &i2c6s2ch0; + i2c621 = &i2c6s2ch1; + i2c622 = &i2c6s2ch2; + i2c623 = &i2c6s2ch3; + i2c624 = &i2c6s2ch4; + i2c625 = &i2c6s2ch5; + i2c626 = &i2c6s2ch6; + i2c627 = &i2c6s2ch7; + }; + + chosen { + stdout-path = &uart5; + bootargs = "console=ttyS4,115200n8 earlycon"; + }; + + memory@80000000 { + device_type = "memory"; + reg = <0x80000000 0x80000000>; + }; + + reserved-memory { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + video_engine_memory: jpegbuffer { + size = <0x02000000>; /* 32M */ + alignment = <0x01000000>; + compatible = "shared-dma-pool"; + reusable; + }; + + vga_memory: frammebuffer { + no-map; + reg = <0x9ff00000 0x01000000>; /* 16M */ + }; + }; + + iio-hwmon { + compatible = "iio-hwmon"; + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>, + <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>, + <&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>, + <&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>; + }; + + gpio-keys { + compatible = "gpio-keys"; + + cpld { + label = "cpld"; + gpios = <&gpio0 ASPEED_GPIO(N, 2) GPIO_ACTIVE_HIGH>; + linux,code = <ASPEED_GPIO(N, 2)>; + }; + }; + + leds { + compatible = "gpio-leds"; + + fan-fault { + label = "fan-fault"; + gpios = <&gpio0 ASPEED_GPIO(B, 0) GPIO_ACTIVE_LOW>; + }; + + system-hot { + label = "system-hot"; + gpios = <&gpio0 ASPEED_GPIO(B, 1) GPIO_ACTIVE_LOW>; + }; + + psu-fault { + label = "psu-fault"; + gpios = <&gpio0 ASPEED_GPIO(B, 2) GPIO_ACTIVE_LOW>; + }; + + heartbeat { + label = "heartbeat"; + gpios = <&gpio0 ASPEED_GPIO(P, 7) GPIO_ACTIVE_LOW>; + }; + + memory-fault { + label = "memory-fault"; + gpios = <&gpio0 ASPEED_GPIO(Y, 2) GPIO_ACTIVE_LOW>; + }; + + system-fault { + label = "system-fault"; + gpios = <&gpio0 ASPEED_GPIO(Y, 3) GPIO_ACTIVE_LOW>; + }; + }; +}; + +&fmc { + status = "okay"; + flash@0 { + status = "okay"; + m25p,fast-read; + label = "bmc"; + spi-max-frequency = <50000000>; +#include "openbmc-flash-layout-64.dtsi" + }; + flash@1 { + status = "okay"; + m25p,fast-read; + label = "alt-bmc"; + spi-max-frequency = <50000000>; +#include "openbmc-flash-layout-64-alt.dtsi" + }; +}; + + +&spi1 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_spi1_default>; + + flash@0 { + status = "okay"; + m25p,fast-read; + label = "bios"; + spi-max-frequency = <50000000>; + }; +}; + +&peci0 { + status = "okay"; + gpios = <&gpio0 ASPEED_GPIO(F, 6) 0>; + + peci-client@30 { + compatible = "intel,peci-client"; + reg = <0x30>; + }; + + peci-client@31 { + compatible = "intel,peci-client"; + reg = <0x31>; + }; +}; + +&gpio0 { + status = "okay"; + gpio-line-names = + /*A0-A7*/ "","","","","","","","", + /*B0-B7*/ "","","","","","","","", + /*C0-C7*/ "","","","","","","","", + /*D0-D7*/ "","","","","","","","", + /*E0-E7*/ "","","","","","","","", + /*F0-F7*/ "","","","","","","","", + /*G0-G7*/ "","","","","","","","", + /*H0-H7*/ "","","","","","","","", + /*I0-I7*/ "","","","","","POWER_OUT","RESET_OUT","", + /*J0-J7*/ "","","","","","","","", + /*K0-K7*/ "","","","","","","","", + /*L0-L7*/ "","","","","","","","", + /*M0-M7*/ "","","","","","","","", + /*N0-N7*/ "","","","","","","","", + /*O0-O7*/ "","","","","","","","", + /*P0-P7*/ "RESET_BUTTON","","","NMI_BUTTON","NMI_OUT","","","", + /*Q0-Q7*/ "","","","","","","","", + /*R0-R7*/ "","","","","","","","", + /*S0-S7*/ "","","","SIO_ONCONTROL","","","","", + /*T0-T7*/ "","","","","","","","", + /*U0-U7*/ "","","","","","","","", + /*V0-V7*/ "","SIO_S5","POWER_BUTTON","","PS_PWROK","","","", + /*W0-W7*/ "","","","","","","","", + /*X0-X7*/ "","","POST_COMPLETE","","","","","", + /*Y0-Y7*/ "","","","","","","","", + /*Z0-Z7*/ "","","","","","","",""; +}; + +&kcs3 { + aspeed,lpc-io-reg = <0xCA2>; + status = "okay"; +}; + +&kcs4 { + aspeed,lpc-io-reg = <0xCA4>; + status = "okay"; +}; + +&lpc_snoop { + snoop-ports = <0x80>; + status = "okay"; +}; + +&mdio1 { + status = "okay"; + + ethphy1: ethernet-phy@0 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <0>; + }; +}; + +&mac2 { + status = "okay"; + + phy-mode = "rgmii"; + phy-handle = <ðphy1>; + + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rgmii3_default>; +}; + +&mac3 { + status = "okay"; + + phy-mode = "rmii"; + use-ncsi; + + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii4_default>; +}; + +&adc0 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default + &pinctrl_adc2_default &pinctrl_adc3_default + &pinctrl_adc4_default &pinctrl_adc5_default + &pinctrl_adc6_default &pinctrl_adc7_default>; +}; + +&adc1 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default + &pinctrl_adc10_default &pinctrl_adc11_default + &pinctrl_adc12_default &pinctrl_adc13_default + &pinctrl_adc14_default &pinctrl_adc15_default>; +}; + +&uart1 { + status = "okay"; +}; + +&uart3 { + status = "okay"; +}; + +&uart4 { + status = "okay"; +}; + +&uart5 { + status = "okay"; +}; + +&vuart1 { + status = "okay"; +}; + +&i2c0 { + multi-master; + status = "okay"; +}; + +&i2c1 { + multi-master; + status = "okay"; + + eeprom@50 { + compatible = "atmel,24c256"; + reg = <0x50>; + }; +}; + +&i2c2 { + status = "okay"; + pca9546@70{ + compatible = "nxp,pca9546"; + reg = <0x70>; + bus2_mux70_0: i2c@2{ + reg = <0>; + tmp112@49{ + compatible = "ti,tmp112"; + reg = <0x49>; + label = "Inlet_Temp"; + }; + emc1413@4c{ + compatible = "microchip,emc1413"; + reg = <0x4c>; + label = "Outlet_Temp"; + }; + }; + }; +}; + +&i2c4 { + multi-master; + status = "okay"; + ipmb0@10 { + compatible = "ipmb-dev"; + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; + i2c-protocol; + }; +}; + +&i2c5 { + bus-frequency = <1000000>; + multi-master; + status = "okay"; + pca9546@70{ + compatible = "nxp,pca9546"; + reg = <0x70>; + bus5_mux00: i2c@0 { + reg = <0>; + status = "okay"; + vrmp2888@76 { + compatible = "mps,mp2888"; + reg = <0x76>; + }; + vrmp2888@72 { + compatible = "mps,mp2888"; + reg = <0x72>; + }; + vrmp2888@62{ + compatible = "mps,mp2888"; + reg = <0x62>; + }; + }; + bus5_mux01: i2c@1{ + reg = <1>; + status = "okay"; + vrmp2888@76{ + compatible = "mps,mp2888"; + reg = <0x76>; + }; + vrmp2888@72 { + compatible = "mps,mp2888"; + reg = <0x72>; + }; + vrmp2888@62{ + compatible = "mps,mp2888"; + reg = <0x62>; + }; + }; + bus5_mux02: i2c@2{ + reg = <2>; + }; + bus5_mux03: i2c@3{ + reg = <3>; + }; + }; +}; + +&i2c6 { + multi-master; + status = "okay"; + + i2c-switch@70 { + compatible = "nxp,pca9548"; + reg = <0x70>; + #address-cells = <1>; + #size-cells = <0>; + + i2c6s0ch0: i2c@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + eeprom@50 { + compatible = "atmel,24c256"; + reg = <0x50>; + }; + pca9548@71 { + compatible = "nxp,pca9548"; + reg = <0x71>; + i2c-mux-idle-disconnect; + + i2c6s1ch0: i2c@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + }; + i2c6s1ch1: i2c@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + }; + i2c6s1ch2: i2c@2 { + #address-cells = <1>; + #size-cells = <0>; + reg = <2>; + }; + i2c6s1ch3: i2c@3 { + #address-cells = <1>; + #size-cells = <0>; + reg = <3>; + }; + i2c6s1ch4: i2c@4 { + #address-cells = <1>; + #size-cells = <0>; + reg = <4>; + }; + i2c6s1ch5: i2c@5 { + #address-cells = <1>; + #size-cells = <0>; + reg = <5>; + }; + i2c6s1ch6: i2c@6 { + #address-cells = <1>; + #size-cells = <0>; + reg = <6>; + }; + i2c6s1ch7: i2c@7 { + #address-cells = <1>; + #size-cells = <0>; + reg = <7>; + }; + }; + + pca9548@72 { + compatible = "nxp,pca9548"; + reg = <0x72>; + i2c-mux-idle-disconnect; + + i2c6s2ch0: i2c@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + }; + i2c6s2ch1: i2c@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + }; + i2c6s2ch2: i2c@2 { + #address-cells = <1>; + #size-cells = <0>; + reg = <2>; + }; + i2c6s2ch3: i2c@3 { + #address-cells = <1>; + #size-cells = <0>; + reg = <3>; + }; + i2c6s2ch4: i2c@4 { + #address-cells = <1>; + #size-cells = <0>; + reg = <4>; + }; + i2c6s2ch5: i2c@5 { + #address-cells = <1>; + #size-cells = <0>; + reg = <5>; + }; + i2c6s2ch6: i2c@6 { + #address-cells = <1>; + #size-cells = <0>; + reg = <6>; + }; + i2c6s2ch7: i2c@7 { + #address-cells = <1>; + #size-cells = <0>; + reg = <7>; + }; + }; + }; + i2c6s0ch1: i2c@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + + eeprom@50 { + compatible = "atmel,24c256"; + reg = <0x50>; + }; + }; + i2c6s0ch2: i2c@2 { + #address-cells = <1>; + #size-cells = <0>; + reg = <2>; + + eeprom@50 { + compatible = "atmel,24c256"; + reg = <0x50>; + }; + }; + i2c6s0ch3: i2c@3 { + #address-cells = <1>; + #size-cells = <0>; + reg = <3>; + + eeprom@50 { + compatible = "atmel,24c256"; + reg = <0x50>; + }; + }; + i2c6s0ch4: i2c@4 { + #address-cells = <1>; + #size-cells = <0>; + reg = <4>; + + eeprom@50 { + compatible = "atmel,24c256"; + reg = <0x50>; + }; + }; + i2c6s0ch5: i2c@5 { + #address-cells = <1>; + #size-cells = <0>; + reg = <5>; + + eeprom@50 { + compatible = "atmel,24c256"; + reg = <0x50>; + }; + }; + i2c6s0ch6: i2c@6 { + #address-cells = <1>; + #size-cells = <0>; + reg = <6>; + eeprom@50 { + compatible = "atmel,24c256"; + reg = <0x50>; + }; + }; + i2c6s0ch7: i2c@7 { + #address-cells = <1>; + #size-cells = <0>; + reg = <7>; + + eeprom@50 { + compatible = "atmel,24c256"; + reg = <0x50>; + }; + }; + }; +}; + +&i2c7 { + multi-master; + #retries = <3>; + status = "okay"; + + adc128d818@1d { + compatible = "ti,adc128d818"; + reg = <0x1d>; + ti,mode = /bits/ 8 <0x01>; + }; + adc128d818@1e { + compatible = "ti,adc128d818"; + reg = <0x1e>; + ti,mode = /bits/ 8 <0x01>; + }; + adc128d818@2d { + compatible = "ti,adc128d818"; + reg = <0x2d>; + ti,mode = /bits/ 8 <0x01>; + }; + ina226@45 { + compatible = "ti,ina226"; + reg = <0x45>; + shunt-resistor = <500>; + }; +}; + +&i2c8 { + multi-master; + status = "okay"; +}; + +&i2c9 { + multi-master; + status = "okay"; +}; + +&i2c10 { + status = "okay"; + + pca0: pca9555@21 { + compatible = "nxp,pca9555"; + reg = <0x21>; + #address-cells = <1>; + #size-cells = <0>; + gpio-controller; + #gpio-cells = <2>; + + gpio-line-names = + "", "", "", "", + "", "", + "FAN_PRSNT8_D_N", "FAN_PRSNT9_D_N", + "", "", "", "", + "", "", "", ""; + }; + + pca1: pca9555@22 { + compatible = "nxp,pca9555"; + reg = <0x22>; + #address-cells = <1>; + #size-cells = <0>; + gpio-controller; + #gpio-cells = <2>; + + gpio-line-names = "FAN_PRSNT0_D_N", "FAN_PRSNT1_D_N", + "FAN_PRSNT2_D_N", "FAN_PRSNT3_D_N", + "FAN_PRSNT4_D_N", "FAN_PRSNT5_D_N", + "FAN_PRSNT6_D_N", "FAN_PRSNT7_D_N", + "", "", "", "", + "", "", "", ""; + }; + +}; + +&i2c11 { + status = "okay"; +}; + +&i2c12 { + multi-master; + status = "okay"; +}; + +&i2c13 { + multi-master; + status = "okay"; +}; + +&video { + status = "okay"; + memory-region = <&video_engine_memory>; +}; + +&vhub { + status = "okay"; +}; -- 2.34.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v1 3/3] ARM: dts: aspeed: Add IEISystems NF5280M7 BMC machine 2024-07-01 10:52 ` [PATCH v1 3/3] ARM: dts: aspeed: Add IEISystems NF5280M7 BMC machine George Liu @ 2024-07-02 10:47 ` Krzysztof Kozlowski 0 siblings, 0 replies; 7+ messages in thread From: Krzysztof Kozlowski @ 2024-07-02 10:47 UTC (permalink / raw) To: George Liu, linux-aspeed Cc: devicetree, openbmc, linux-kernel, robh+dt, linux-arm-kernel, krzysztof.kozlowski+dt, conor+dt, joel, andrew On 01/07/2024 12:52, George Liu wrote: > The IEISystems NF5280M7 is an x86 platform server with an > AST2600-based BMC. > This dts file provides a basic configuration for its OpenBMC > development. > ... > + i2c613 = &i2c6s1ch3; > + i2c614 = &i2c6s1ch4; > + i2c615 = &i2c6s1ch5; > + i2c616 = &i2c6s1ch6; > + i2c617 = &i2c6s1ch7; > + i2c620 = &i2c6s2ch0; > + i2c621 = &i2c6s2ch1; > + i2c622 = &i2c6s2ch2; > + i2c623 = &i2c6s2ch3; > + i2c624 = &i2c6s2ch4; > + i2c625 = &i2c6s2ch5; > + i2c626 = &i2c6s2ch6; > + i2c627 = &i2c6s2ch7; > + }; > + > + chosen { > + stdout-path = &uart5; > + bootargs = "console=ttyS4,115200n8 earlycon"; earlycon is debugging tool, not production, drop. This leads to totally redundant bootargs, so drop it entirely. > + }; > + > + memory@80000000 { > + device_type = "memory"; > + reg = <0x80000000 0x80000000>; > + }; > + ... > +&i2c2 { > + status = "okay"; Missing blank line (everywhere) > + pca9546@70{ Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "nxp,pca9546"; > + reg = <0x70>; > + bus2_mux70_0: i2c@2{ > + reg = <0>; > + tmp112@49{ Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Everywhere: missing space before { > + compatible = "ti,tmp112"; > + reg = <0x49>; > + label = "Inlet_Temp"; > + }; Missing blank line > + emc1413@4c{ Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "microchip,emc1413"; > + reg = <0x4c>; > + label = "Outlet_Temp"; > + }; > + }; > + }; > +}; > + > +&i2c4 { > + multi-master; > + status = "okay"; > + ipmb0@10 { > + compatible = "ipmb-dev"; > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; > + i2c-protocol; > + }; > +}; > + > +&i2c5 { > + bus-frequency = <1000000>; > + multi-master; > + status = "okay"; > + pca9546@70{ Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Above comment applies to multiple places. > + compatible = "nxp,pca9546"; > + reg = <0x70>; > + bus5_mux00: i2c@0 { > + reg = <0>; > + status = "okay"; Where is it disabled? > + vrmp2888@76 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "mps,mp2888"; > + reg = <0x76>; > + }; > + vrmp2888@72 { > + compatible = "mps,mp2888"; > + reg = <0x72>; > + }; > + vrmp2888@62{ > + compatible = "mps,mp2888"; > + reg = <0x62>; > + }; > + }; > + bus5_mux01: i2c@1{ > + reg = <1>; > + status = "okay"; Where is it disabled? > + vrmp2888@76{ Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "mps,mp2888"; > + reg = <0x76>; > + }; > + vrmp2888@72 { > + compatible = "mps,mp2888"; > + reg = <0x72>; > + }; > + vrmp2888@62{ > + compatible = "mps,mp2888"; > + reg = <0x62>; > + }; > + }; > + bus5_mux02: i2c@2{ > + reg = <2>; > + }; > + bus5_mux03: i2c@3{ > + reg = <3>; > + }; > + }; > +}; > + > +&i2c6 { > + multi-master; > + status = "okay"; > + > + i2c-switch@70 { > + compatible = "nxp,pca9548"; > + reg = <0x70>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + i2c6s0ch0: i2c@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0>; > + > + eeprom@50 { > + compatible = "atmel,24c256"; > + reg = <0x50>; > + }; > + pca9548@71 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "nxp,pca9548"; > + reg = <0x71>; > + i2c-mux-idle-disconnect; > + > + i2c6s1ch0: i2c@0 { > + }; > + }; > +}; > + > +&i2c7 { > + multi-master; > + #retries = <3>; > + status = "okay"; > + > + adc128d818@1d { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "ti,adc128d818"; > + reg = <0x1d>; > + ti,mode = /bits/ 8 <0x01>; > + }; Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 1/3] dt-bindings: vendor-prefixes: Add prefix for ieisystems 2024-07-01 10:52 [PATCH v1 1/3] dt-bindings: vendor-prefixes: Add prefix for ieisystems George Liu 2024-07-01 10:52 ` [PATCH v1 2/3] dt-bindings: arm: aspeed: add IEIT x86 platform BMC boards George Liu 2024-07-01 10:52 ` [PATCH v1 3/3] ARM: dts: aspeed: Add IEISystems NF5280M7 BMC machine George Liu @ 2024-07-01 18:29 ` Rob Herring 2024-07-01 18:31 ` Rob Herring 3 siblings, 0 replies; 7+ messages in thread From: Rob Herring @ 2024-07-01 18:29 UTC (permalink / raw) To: George Liu Cc: linux-aspeed, devicetree, openbmc, linux-kernel, linux-arm-kernel, krzysztof.kozlowski+dt, conor+dt, joel, andrew On Mon, Jul 01, 2024 at 06:52:57PM +0800, George Liu wrote: > Add a vendor prefix entry for ieisystems ieisystems or IEIT SYSTEMS > > Signed-off-by: George Liu <liuxiwei@ieisystem.com> Or ieisystem? Using the domain name (minus .com, etc.) is common practice. > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > index 573578db9509..0ffa8d06aea9 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -609,6 +609,8 @@ patternProperties: > description: IC Plus Corp. > "^idt,.*": > description: Integrated Device Technologies, Inc. > + "^ieit,.*": > + description: IEIT SYSTEMS Co.，Ltd. > "^ifi,.*": > description: Ingenieurburo Fur Ic-Technologie (I/F/I) > "^ilitek,.*": > -- > 2.34.1 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 1/3] dt-bindings: vendor-prefixes: Add prefix for ieisystems 2024-07-01 10:52 [PATCH v1 1/3] dt-bindings: vendor-prefixes: Add prefix for ieisystems George Liu ` (2 preceding siblings ...) 2024-07-01 18:29 ` [PATCH v1 1/3] dt-bindings: vendor-prefixes: Add prefix for ieisystems Rob Herring @ 2024-07-01 18:31 ` Rob Herring 3 siblings, 0 replies; 7+ messages in thread From: Rob Herring @ 2024-07-01 18:31 UTC (permalink / raw) To: George Liu Cc: linux-aspeed, devicetree, openbmc, linux-kernel, linux-arm-kernel, krzysztof.kozlowski+dt, conor+dt, joel, andrew On Mon, Jul 01, 2024 at 06:52:57PM +0800, George Liu wrote: > Add a vendor prefix entry for ieisystems > > Signed-off-by: George Liu <liuxiwei@ieisystem.com> Also note that checkpatch.pl reports an author/Sob email mismatch. > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > index 573578db9509..0ffa8d06aea9 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -609,6 +609,8 @@ patternProperties: > description: IC Plus Corp. > "^idt,.*": > description: Integrated Device Technologies, Inc. > + "^ieit,.*": > + description: IEIT SYSTEMS Co.，Ltd. > "^ifi,.*": > description: Ingenieurburo Fur Ic-Technologie (I/F/I) > "^ilitek,.*": > -- > 2.34.1 > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-07-02 10:47 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-07-01 10:52 [PATCH v1 1/3] dt-bindings: vendor-prefixes: Add prefix for ieisystems George Liu 2024-07-01 10:52 ` [PATCH v1 2/3] dt-bindings: arm: aspeed: add IEIT x86 platform BMC boards George Liu 2024-07-01 15:03 ` Conor Dooley 2024-07-01 10:52 ` [PATCH v1 3/3] ARM: dts: aspeed: Add IEISystems NF5280M7 BMC machine George Liu 2024-07-02 10:47 ` Krzysztof Kozlowski 2024-07-01 18:29 ` [PATCH v1 1/3] dt-bindings: vendor-prefixes: Add prefix for ieisystems Rob Herring 2024-07-01 18:31 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).