From: Rob Herring <robh@kernel.org>
To: George Stark <gnstark@salutedevices.com>
Cc: ukleinek@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
neil.armstrong@linaro.org, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
hkallweit1@gmail.com, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@salutedevices.com
Subject: Re: [PATCH v2 2/3] dt-bindings: pwm: amlogic: Add optional power-domains
Date: Mon, 1 Jul 2024 12:36:31 -0600 [thread overview]
Message-ID: <20240701183631.GA349021-robh@kernel.org> (raw)
In-Reply-To: <20240701172016.523402-3-gnstark@salutedevices.com>
On Mon, Jul 01, 2024 at 08:20:15PM +0300, George Stark wrote:
> On newer SoCs, the PWM can require a power-domain to operate so add it
> as optional.
If required, then how is it optional?
If the 'newer SoCs' means the one you just added, then this should be
squashed into the prior patch with a conditional schema making it
required for the new compatible.
>
> Signed-off-by: George Stark <gnstark@salutedevices.com>
> ---
> Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
> index da22cb3ed878..c814d88748dd 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
> @@ -60,6 +60,9 @@ properties:
> minItems: 1
> maxItems: 2
>
> + power-domains:
> + maxItems: 1
> +
> "#pwm-cells":
> const: 3
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2024-07-01 18:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 17:20 [PATCH v2 0/3] pwm: meson: add pwm support for A1 George Stark
2024-07-01 17:20 ` [PATCH v2 1/3] dt-bindings: pwm: amlogic: Add new bindings for meson A1 PWM George Stark
2024-07-01 17:20 ` [PATCH v2 2/3] dt-bindings: pwm: amlogic: Add optional power-domains George Stark
2024-07-01 18:36 ` Rob Herring [this message]
2024-07-02 12:29 ` George Stark
2024-07-01 17:20 ` [PATCH v2 3/3] arm64: dts: meson: a1: add definitions for meson PWM George Stark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701183631.GA349021-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gnstark@salutedevices.com \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=kernel@salutedevices.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).