Re: [PATCH 3/9] dt-bindings: display: renesas,rzg2l-du: Document RZ/G2UL DU bindings

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1505 bytes --]

On Tue, Jul 02, 2024 at 03:33:17PM +0000, Biju Das wrote:
> Hi Conor,
> 
> Thanks for the feedback.
> 
> > -----Original Message-----
> > From: Conor Dooley <conor@kernel.org>
> > Sent: Tuesday, July 2, 2024 3:51 PM
> > Subject: Re: [PATCH 3/9] dt-bindings: display: renesas,rzg2l-du: Document RZ/G2UL DU bindings
> > 
> > On Tue, Jul 02, 2024 at 10:46:13AM +0100, Biju Das wrote:
> > > Document DU found in RZ/G2UL SoC. The DU block is identical to RZ/G2L
> > > SoC, but has only DPI interface.
> > >
> > > While at it, add missing required property port@1 for RZ/G2L and
> > > RZ/V2L SoCs.
> > 
> > A new required property is an ABI break, it deserves more of an explanation than "in passing..."
> 
> RZ/G2L LCDC documents both port@0 and port@1 that is described here in [1]
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml?h=next-20240702#n59
> 
> Unfortunately missed to add port@1 as required property.
> 
> Currently there is no user for the DPI interface and there is
> no DPI interface support in display driver. So, there is nothing
> for ABI breakage.
> 
> I will mention in the commit description that
> "currently there is no user for the DPI interface
> and hence there won't be any ABI breakage for adding
> port@1 as required property for RZ/G2L and RZ/V2L SoCs".

That seems reasonable. You can add my Acked-by with that wording update.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]