From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38D4216C69A; Tue, 2 Jul 2024 15:34:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719934488; cv=none; b=VVcRLJWO+KnCIlx3Oczto1mGT9INS4KbmRowqFoEWwwybfZkjMh4iYxeUQhfVEB6ZrUA7NFTpOTqLQdTjVCMQi4r91Q66/RTLaNJj105bkYnT6v40LC4P3Z1WwRcN9YNRoUi7Az1Nl6eKMDWu6hjvFL5W5Cg0gQ3bqjUp6W1WoU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719934488; c=relaxed/simple; bh=+dYiFmhmoQq6ipJE6mlBFSYVxPXJIa9oBX8SvQ1Od/0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jLyFjAEV3MNgj9UJPmTr1vdCqITzNJ63m/qOhxjtrU88jn5mY6r6pLnRn5M0j5kr6/3bBKA4fPndoIvoEZ1CtzT8+Lxc1corcOgeQWu5encfn4cCP2mxjTtk4D3DeV1cLSCpVbYsQfSETMxWjafKWsrKq3OzxGjdPYskj0FyVYs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aHlopjPf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aHlopjPf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9F94C116B1; Tue, 2 Jul 2024 15:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719934487; bh=+dYiFmhmoQq6ipJE6mlBFSYVxPXJIa9oBX8SvQ1Od/0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aHlopjPfwKNLP8sg48SSnpmQ5D4dZ5ylFVdez1Wv3FlKTOo5st+VquVoSvYCuDngm CQQ91dB4rDedUSUmeu3oHUw84DE9Y5lZk+8YqwrLFvALUgnkXDXMF/pUDylGL7YwVt rDbDfwbJbaLW/YBG5xoHocFBZaoelikmsCqlrKGc872N+PgViLLKu23JsEYt6nY49g vmFtWis0SaLdjhp1krsTKDI7tjmLWl9TryPOlT/HidCCOlbC0+tymUcTtvBlCPAPcn u1odPFJgqegm0pP5tw4OU1oX15iI53gi8l83+6eIyNtAlf08aFFSO/1ZpnkrA8RTdJ jRsr0+ya4LRhA== Date: Tue, 2 Jul 2024 16:34:42 +0100 From: Conor Dooley To: Hironori KIKUCHI Cc: linux-kernel@vger.kernel.org, Jagan Teki , Neil Armstrong , Jessica Zhang , Sam Ravnborg , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/3] dt-bindings: display: st7701: Add Anbernic RG28XX panel Message-ID: <20240702-magnetism-amends-d535f626e433@spud> References: <20240628051019.975172-1-kikuchan98@gmail.com> <20240628051019.975172-2-kikuchan98@gmail.com> <20240628-splashy-slug-1d74e3fd9fe6@spud> <20240630-babied-grill-13c840abb70a@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8Wkwgm2LZxTD6wYX" Content-Disposition: inline In-Reply-To: --8Wkwgm2LZxTD6wYX Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 02, 2024 at 02:28:27AM +0900, Hironori KIKUCHI wrote: > On Sun, Jun 30, 2024 at 11:17=E2=80=AFPM Conor Dooley = wrote: > > On Sat, Jun 29, 2024 at 05:26:56PM +0900, Hironori KIKUCHI wrote: > > > On Sat, Jun 29, 2024 at 1:27=E2=80=AFAM Conor Dooley wrote: > > > > On Fri, Jun 28, 2024 at 02:10:15PM +0900, Hironori KIKUCHI wrote: > > > > > - densitron,dmt028vghmcmi-1a > > > > > - elida,kd50t048a > > > > > - techstar,ts8550b > > > > > - const: sitronix,st7701 > > > > > > > > > > reg: > > > > > - description: DSI virtual channel used by that screen > > > > > + description: DSI / SPI channel used by that screen > > > > > maxItems: 1 > > > > > > > > > > VCC-supply: > > > > > @@ -43,6 +41,13 @@ properties: > > > > > IOVCC-supply: > > > > > description: I/O system regulator > > > > > > > > > > + dc-gpios: > > > > > + maxItems: 1 > > > > > + description: > > > > > + Controller data/command selection (D/CX) in 4-line SPI mod= e. > > > > > + If not set, the controller is in 3-line SPI mode. > > > > > + Disallowed for DSI. > > > > > + > > > > > port: true > > > > > reset-gpios: true > > > > > rotation: true > > > > > @@ -57,7 +62,38 @@ required: > > > > > - port > > > > > - reset-gpios > > > > > > > > > > -additionalProperties: false > > > > > +allOf: > > > > > + - $ref: panel-common.yaml# > > > > > + - if: > > > > > + properties: > > > > > + compatible: > > > > > + contains: > > > > > + # SPI connected panels > > > > > + enum: > > > > > + - anbernic,rg28xx-panel > > > > > + then: > > > > > + $ref: /schemas/spi/spi-peripheral-props.yaml > > > > > > > > I'm not really keen on this. I'd rather see a different binding for= the > > > > SPI version compared to the MIPI ones. Is doing things like this co= mmon > > > > for panels? If it is, I'll turn a blind eye.. > > > > > > This might be the first case that a driver supports both DSI and SPI > > > for a panel. > > > The panel can be either a DSI device or an SPI device. > > > > The commit message sounded like the panel was capable of doing SPI > > instead of DSI, is that not the case and the panel is actually capable > > of doing both, just happens to be connected as SPI in this particular > > device? >=20 > Sorry for the confusion. > I think it depends on what the "panel" refers to... > Although the "panel driver IC" (ST7701 variant) is capable of doing > both, the "panel assy" (including its cable) of the RG28XX only has an > SPI interface in its pinout. > If the compatible string "rg28xx-panel" represents the assy, then I > could say the "panel" only supports SPI, and the other panels only > support DSI. > But if it only represents a specific LCD panel and its driver IC with > control parameters, then it theoretically supports both, and it might > be sufficient to just include spi-peripheral-props, as in v1. > v1: https://lore.kernel.org/linux-kernel/20240618081515.1215552-2-kikucha= n98@gmail.com/ I thought about it some more, and I think what you've got for this in the binding at present is fine. Splitting the binding I think would require a select and wouldn't really be any "cleaner" of an implementation. Thanks, Conor. --8Wkwgm2LZxTD6wYX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZoQeEgAKCRB4tDGHoIJi 0vvsAP9+fpoFYD3SA3hRRGAIfCwJ3EiGoPOw3FcWVA1dtXs6FwEA7OBNrPnGxdQo DSBupiUCLvbAS0u7Q+v/iLTAaozWdAY= =4eFZ -----END PGP SIGNATURE----- --8Wkwgm2LZxTD6wYX--