From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 175D88830; Tue, 2 Jul 2024 01:28:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719883735; cv=none; b=GkGEkchaArgpKogbiVlWCQ0n72MomVj3Ryq6amo2NXMf8OwIorA3zLG8TZqapRqPJtkwn4VfjNsVxnLpMrQwsVH++ZVzGDq7+kBVYH5/eW/WPBLei3XBoUlblgQUgCgN2Jv6rDR+9yzhoC0n4XkfAUPOgS+r5xubwmgj+/sPD7U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719883735; c=relaxed/simple; bh=CnHqwkeS90MMNuM2cK3PUfFffxA7KW+C+qvrwEke0jg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rz8+etkwkXDfzrbfmXtl1WJbwcV4DGmGCVUeNFRNfeVNHVDpd+WpVl+xCGwys4S660BUbILKHXOb5OIyg71CMqsOQlhSCfejY87cdMOhyMSSd/vh0nRipyEp+r/KXhlbVU6UmbGJJy/mFngRC/3TTjR78YtDRyYTPemy5HNGZJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org; spf=pass smtp.mailfrom=gentoo.org; arc=none smtp.client-ip=140.211.166.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gentoo.org Date: Tue, 2 Jul 2024 01:28:47 +0000 From: Yixun Lan To: Emil Renner Berthing Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Lezcano , Thomas Gleixner , Samuel Holland , Anup Patel , Greg Kroah-Hartman , Jiri Slaby , Lubomir Rintel , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-riscv@lists.infradead.org, linux-serial@vger.kernel.org, Inochi Amaoto , Meng Zhang , Yangyu Chen Subject: Re: [PATCH v2 08/10] riscv: dts: add initial SpacemiT K1 SoC device tree Message-ID: <20240702012847.GA2447193@ofsar> References: <20240627-k1-01-basic-dt-v2-0-cc06c7555f07@gentoo.org> <20240627-k1-01-basic-dt-v2-8-cc06c7555f07@gentoo.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 12:49 Mon 01 Jul , Emil Renner Berthing wrote: > Yixun Lan wrote: > > From: Yangyu Chen > > > > Banana Pi BPI-F3 motherboard is powered by SpacemiT K1[1]. > > > > Key features: > > - 4 cores per cluster, 2 clusters on chip > > - UART IP is Intel XScale UART > > > > Some key considerations: > > - ISA string is inferred from vendor documentation[2] > > - Cluster topology is inferred from datasheet[1] and L2 in vendor dts[3] > > - No coherent DMA on this board > > Inferred by taking vendor ethernet and MMC drivers to the mainline > > kernel. Without dma-noncoherent in soc node, the driver fails. > > - No cache nodes now > > The parameters from vendor dts are likely to be wrong. It has 512 > > sets for a 32KiB L1 Cache. In this case, each set is 64B in size. > > When the size of the cache line is 64B, it is a directly mapped > > cache rather than a set-associative cache, the latter is commonly > > used. Thus, I didn't use the parameters from vendor dts. > > > > Currently only support booting into console with only uart, other > > features will be added soon later. > > ... > > + clint: timer@e4000000 { > > + compatible = "spacemit,k1-clint", "sifive,clint0"; > > + reg = <0x0 0xe4000000 0x0 0x10000>; > > + interrupts-extended = <&cpu0_intc 3>, <&cpu0_intc 7>, > > + <&cpu1_intc 3>, <&cpu1_intc 7>, > > + <&cpu2_intc 3>, <&cpu2_intc 7>, > > + <&cpu3_intc 3>, <&cpu3_intc 7>, > > + <&cpu4_intc 3>, <&cpu4_intc 7>, > > + <&cpu5_intc 3>, <&cpu5_intc 7>, > > + <&cpu6_intc 3>, <&cpu6_intc 7>, > > + <&cpu7_intc 3>, <&cpu7_intc 7>; > > + }; > > + > > + uart0: serial@d4017000 { > > + compatible = "spacemit,k1-uart", "intel,xscale-uart"; > > + reg = <0x0 0xd4017000 0x0 0x100>; > > + interrupts = <42>; > > + clock-frequency = <14857000>; > > + reg-shift = <2>; > > + reg-io-width = <4>; > > + status = "disabled"; > > + }; > > + > > + /* note: uart1 skipped */ > > The datasheet page you link to above says "-UART (×10)", but here you're > skipping one of them. Why? I can see the vendor tree does the same, but it > would be nice with an explanation of what's going on. > /* note: uart1 in 0xf0612000, reserved for TEE usage */ I would put something like this, does this sound ok to you? more detail, iomem range from 0xf000,0000 - 0xf080,0000 are dedicated for TEE purpose, It won't be exposed to Linux once TEE feature is enabled.. skipping uart1 may make people confused but we are trying to follow datasheet.. -- Yixun Lan (dlan) Gentoo Linux Developer GPG Key ID AABEFD55