From: Conor Dooley <conor@kernel.org>
To: Ryan Walklin <ryan@testtoast.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Hironori KIKUCHI <kikuchan98@gmail.com>,
Chris Morgan <macroalpha82@gmail.com>
Subject: Re: [PATCH v2 3/3] dt-bindings: display: panel: correct Anbernic RG35XX panel example
Date: Wed, 3 Jul 2024 16:38:31 +0100 [thread overview]
Message-ID: <20240703-cataract-suitor-f930bcc83aa8@spud> (raw)
In-Reply-To: <20240703103710.31169-4-ryan@testtoast.com>
[-- Attachment #1: Type: text/plain, Size: 1416 bytes --]
On Wed, Jul 03, 2024 at 10:31:46PM +1200, Ryan Walklin wrote:
> make dt_bindings_check reports that sck-gpios and num-chipselects are
> required for spi nodes, therefore add these to the example.
>
> Signed-off-by: Ryan Walklin <ryan@testtoast.com>
I forgot to reply to, or somehow didn't notice your reply to my comments
on this patch. I would just drop this change as I think it's a tooling
issue. I checked the version of dt-schema etc that I have here locally
and there were no complaints with the binding prior to your patches.
Sorry for missing your reply,
Conor.
> ---
> .../bindings/display/panel/anbernic,wl-355608-a8.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml b/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml
> index dde3600f0189c..bbe016453c9b2 100644
> --- a/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml
> @@ -40,6 +40,9 @@ examples:
> #address-cells = <1>;
> #size-cells = <0>;
>
> + sck-gpios = <&pio 8 9 GPIO_ACTIVE_HIGH>; // PI9
> + num-chipselects = <1>;
> +
> panel@0 {
> compatible = "anbernic,wl-355608-a8";
> reg = <0>;
> --
> 2.45.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-07-03 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 10:31 [PATCH v2 0/3] Correct WL-355608-A8 panel compatible Ryan Walklin
2024-07-03 10:31 ` [PATCH v2 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel Ryan Walklin
2024-07-03 15:38 ` Conor Dooley
2024-07-03 10:31 ` [PATCH v2 2/3] drm: panel: nv3052c: Correct WL-355608-A8 panel compatible Ryan Walklin
2024-07-03 12:18 ` Dmitry Baryshkov
2024-07-03 10:31 ` [PATCH v2 3/3] dt-bindings: display: panel: correct Anbernic RG35XX panel example Ryan Walklin
2024-07-03 15:38 ` Conor Dooley [this message]
2024-07-05 8:41 ` Ryan Walklin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703-cataract-suitor-f930bcc83aa8@spud \
--to=conor@kernel.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kikuchan98@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=macroalpha82@gmail.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robh@kernel.org \
--cc=ryan@testtoast.com \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox