devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Marek Vasut <marex@denx.de>,
	linux-arm-kernel@lists.infradead.org, andrew@lunn.ch,
	kernel@dh-electronics.com, kernel test robot <lkp@intel.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Khuong Dinh <khuong@os.amperecomputing.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh@kernel.org>,
	devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards
Date: Wed, 3 Jul 2024 11:36:01 +0200	[thread overview]
Message-ID: <20240703093601.GA6493@ragnatech.se> (raw)
In-Reply-To: <CAMuHMdWLLAff5_ndAvH9PofTpibJdOau65wK+QekcwR26H2YoA@mail.gmail.com>

On 2024-07-03 10:24:26 +0200, Geert Uytterhoeven wrote:
> Niklas: commit 54bf0c27380b95a2 ("arm64: dts: renesas: r8a779g0: Use
> MDIO node for all AVB devices") did keep the reset-gpios property in
> the PHY node. I guess it should be moved one level up?

It's possible to have a rest-gpios property both in the mdio node and 
the phy node. The former resets the whole bus while the later a single 
PHY, at least that's my understanding.

I think it would be more correct to move the reset-gpios up one level 
for r8a779g0. However as it already was in the PHY node and this 
functioned as it should I kept it there.

The need for the mdio node was to avoid a device specific property added 
in the BSP to reset the whole bus. At the moment I can't recall the two 
different call sites for when the two resets are called. Maybe if we 
move it to the mdio node we can avoid setting the PHY id in the 
compatible string as we could then always probe the PHY correctly. I 
will look into it.

-- 
Kind Regards,
Niklas Söderlund

  reply	other threads:[~2024-07-03  9:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-30  3:46 [PATCH 1/2] ARM: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards Marek Vasut
2024-06-30  3:46 ` [PATCH 2/2] arm64: " Marek Vasut
2024-07-01 13:29   ` Andrew Lunn
2024-07-02  8:38   ` Geert Uytterhoeven
2024-07-02 20:02     ` Marek Vasut
2024-07-03  8:24       ` Geert Uytterhoeven
2024-07-03  9:36         ` Niklas Söderlund [this message]
2024-07-05 21:49           ` Marek Vasut
2024-07-06  8:39             ` Niklas Söderlund
2024-07-08  7:02               ` Geert Uytterhoeven
2024-07-05 21:48         ` Marek Vasut
2024-07-08  7:09           ` Geert Uytterhoeven
2024-07-09  3:22             ` Marek Vasut
2024-07-09 23:37               ` Adam Ford
2024-07-10 12:02                 ` Marek Vasut
2024-07-01 13:26 ` [PATCH 1/2] ARM: " Andrew Lunn
2024-07-01 14:52 ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240703093601.GA6493@ragnatech.se \
    --to=niklas.soderlund+renesas@ragnatech.se \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=kernel@dh-electronics.com \
    --cc=khuong@os.amperecomputing.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=magnus.damm@gmail.com \
    --cc=marex@denx.de \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).