Re: [PATCH V2 2/4] arm64: dts: allwinner: h616: Add r_i2c pinctrl nodes

[Andre Przywara <andre.przywara@arm.com>]

On Wed, 3 Jul 2024 14:14:39 +0100
Andre Przywara <andre.przywara@arm.com> wrote:

> On Tue,  2 Jul 2024 14:34:12 -0500
> Chris Morgan <macroalpha82@gmail.com> wrote:
> 
> > From: Chris Morgan <macromorgan@hotmail.com>
> > 
> > Add pinctrl nodes for the r_i2c node. Without the pinmux defined the
> > r_i2c bus may fail to work, possibly if the bootloader uses rsb mode
> > for the PMIC.  
> 
> Yes, those are the only pins available, checked against the manual.

Looking closer, this is actually a proper bug: none of the five H616
devices using R_I2C set the pinmux (not even in the board .dts files),
so nothing sets this up in the kernel. We are just lucky that U-Boot's
SPL programs the pinmux, and nothing changes it afterwards.
So this should be taken as a fix ASAP, potentially with:

Fixes: 0d17c8651188 ("arm64: dts: allwinner: Add Allwinner H616 .dtsi file")

(though I am a bit doubtful about the useful of DT backports in general)

Cheers,
Andre


> 
> > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>  
> 
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> 
> Cheers,
> Andre
> 
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> > index 921d5f61d8d6..e31945c3895e 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> > @@ -837,6 +837,8 @@ r_i2c: i2c@7081400 {
> >  			dmas = <&dma 48>, <&dma 48>;
> >  			dma-names = "rx", "tx";
> >  			resets = <&r_ccu RST_R_APB2_I2C>;
> > +			pinctrl-names = "default";
> > +			pinctrl-0 = <&r_i2c_pins>;
> >  			status = "disabled";
> >  			#address-cells = <1>;
> >  			#size-cells = <0>;  
> 
>