From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org
Cc: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Geert Uytterhoeven" <geert@linux-m68k.org>
Subject: [PATCH] arm64: dts: renesas: white-hawk-cpu: Move avb0 reset gpio to mdio node
Date: Thu, 4 Jul 2024 17:26:10 +0200 [thread overview]
Message-ID: <20240704152610.1345709-1-niklas.soderlund+renesas@ragnatech.se> (raw)
When creating a dedicated mdio node to describe the bus the gpio reset
property was erroneously left in the phy node. The reason for adding
mdio nodes on WhiteHawk was to ensure the PHYs where reset before they
were probed, keeping the property in the phy node prevented this.
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Fixes: 54bf0c27380b ("arm64: dts: renesas: r8a779g0: Use MDIO node for all AVB devices")
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
arch/arm64/boot/dts/renesas/white-hawk-cpu-common.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/white-hawk-cpu-common.dtsi b/arch/arm64/boot/dts/renesas/white-hawk-cpu-common.dtsi
index 80496fb3d476..4f0230327868 100644
--- a/arch/arm64/boot/dts/renesas/white-hawk-cpu-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/white-hawk-cpu-common.dtsi
@@ -156,6 +156,8 @@ mdio {
#address-cells = <1>;
#size-cells = <0>;
+ reset-gpios = <&gpio7 10 GPIO_ACTIVE_LOW>;
+
avb0_phy: ethernet-phy@0 {
compatible = "ethernet-phy-id0022.1622",
"ethernet-phy-ieee802.3-c22";
@@ -163,7 +165,6 @@ avb0_phy: ethernet-phy@0 {
reg = <0>;
interrupt-parent = <&gpio7>;
interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
- reset-gpios = <&gpio7 10 GPIO_ACTIVE_LOW>;
};
};
};
--
2.45.2
next reply other threads:[~2024-07-04 15:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 15:26 Niklas Söderlund [this message]
2024-08-02 8:33 ` [PATCH] arm64: dts: renesas: white-hawk-cpu: Move avb0 reset gpio to mdio node Geert Uytterhoeven
2024-08-02 17:16 ` Marek Vasut
2024-08-22 13:56 ` Geert Uytterhoeven
2024-09-06 13:52 ` Niklas Söderlund
2024-09-06 18:09 ` Marek Vasut
2024-10-15 14:48 ` Niklas Söderlund
2024-10-20 22:16 ` Marek Vasut
2024-10-21 7:13 ` Geert Uytterhoeven
2024-10-21 21:31 ` Marek Vasut
2024-10-22 7:38 ` Geert Uytterhoeven
2024-10-27 15:21 ` Marek Vasut
2024-10-28 10:13 ` Geert Uytterhoeven
2024-10-28 18:18 ` Marek Vasut
2024-10-29 8:26 ` Geert Uytterhoeven
2024-10-30 14:45 ` Marek Vasut
2025-01-23 13:18 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240704152610.1345709-1-niklas.soderlund+renesas@ragnatech.se \
--to=niklas.soderlund+renesas@ragnatech.se \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).