public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/7] dt-bindings: iio: rename bu27034 file
Date: Mon, 8 Jul 2024 18:05:01 +0100	[thread overview]
Message-ID: <20240708-eloquent-overdrive-092c7678f913@spud> (raw)
In-Reply-To: <f83cf0d6f5b0ed391703ea3908ebd65b3f6e5c87.1720176341.git.mazziesaccount@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2015 bytes --]

On Fri, Jul 05, 2024 at 01:54:26PM +0300, Matti Vaittinen wrote:
> The BU27034NUC was cancelled before it entered mass production. It was
> replaced by a new variant BU27034ANUC (note, added 'A'). The new
> variant gained a few significant changes, like removal of the 3.rd data
> channel and dropping some of the gain settings. This means that, from
> software point of view these ICs are incompatible. Lux calculation based
> on the data from the sensors needs to be done differently, and on the
> BU27034ANUC the channel 3 data is missing. Also, the gain setting
> differencies matter.
> 
> The old sensor should not be out there so the compatible was dropped and
> a new compatible was added for the bu27034anuc. Move the yaml file so
> the file name matches the binding and change the $id.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> ---
> Revision history:
> v1 => v2:
> - New patch
> ---
>  .../iio/light/{rohm,bu27034.yaml => rohm,bu27034anuc.yaml}      | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  rename Documentation/devicetree/bindings/iio/light/{rohm,bu27034.yaml => rohm,bu27034anuc.yaml} (92%)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/rohm,bu27034.yaml b/Documentation/devicetree/bindings/iio/light/rohm,bu27034anuc.yaml
> similarity index 92%
> rename from Documentation/devicetree/bindings/iio/light/rohm,bu27034.yaml
> rename to Documentation/devicetree/bindings/iio/light/rohm,bu27034anuc.yaml
> index 535bd18348ac..fc3d826ed8ba 100644
> --- a/Documentation/devicetree/bindings/iio/light/rohm,bu27034.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/rohm,bu27034anuc.yaml
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>  %YAML 1.2
>  ---
> -$id: http://devicetree.org/schemas/iio/light/rohm,bu27034.yaml#
> +$id: http://devicetree.org/schemas/iio/light/rohm,bu27034anuc.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#

IMO this should be squashed.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2024-07-08 17:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05 10:53 [PATCH v2 0/7] ROHM BU27034NUC to ROHM BU27034ANUC Matti Vaittinen
2024-07-05 10:54 ` [PATCH v2 1/7] dt-bindings: iio: BU27034 => BU27034ANUC Matti Vaittinen
2024-07-07 13:05   ` Jonathan Cameron
2024-07-08 12:43     ` Matti Vaittinen
2024-07-08 17:06   ` Conor Dooley
2024-07-05 10:54 ` [PATCH v2 2/7] dt-bindings: iio: rename bu27034 file Matti Vaittinen
2024-07-08 17:05   ` Conor Dooley [this message]
2024-07-09 18:33     ` Matti Vaittinen
2024-07-13 11:00       ` Jonathan Cameron
2024-07-05 10:54 ` [PATCH v2 3/7] bu27034: ROHM BU27034NUC to BU27034ANUC Matti Vaittinen
2024-07-05 10:55 ` [PATCH v2 4/7] bu27034: ROHM BU27034NUC to BU27034ANUC drop data2 Matti Vaittinen
2024-07-05 10:55 ` [PATCH v2 5/7] bu27034: ROHM BU27034ANUC correct gains and times Matti Vaittinen
2024-07-05 10:55 ` [PATCH v2 6/7] bu27034: ROHM BU27034ANUC correct lux calculation Matti Vaittinen
2024-07-05 10:55 ` [PATCH v2 7/7] iio: bu27034: Add a read only HWARDWAREGAIN Matti Vaittinen
2024-07-07 13:14   ` Jonathan Cameron
2024-07-13 11:01 ` [PATCH v2 0/7] ROHM BU27034NUC to ROHM BU27034ANUC Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240708-eloquent-overdrive-092c7678f913@spud \
    --to=conor@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=mazziesaccount@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox