devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>
Cc: vireshk@kernel.org, nm@ti.com, sboyd@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	angelogioacchino.delregno@collabora.com, andersson@kernel.org,
	konrad.dybcio@linaro.org, mturquette@baylibre.com,
	ilia.lin@kernel.org, rafael@kernel.org, ulf.hansson@linaro.org,
	quic_sibis@quicinc.com, quic_rjendra@quicinc.com,
	quic_rohiagar@quicinc.com, abel.vesa@linaro.org,
	otto.pflueger@abscue.de, danila@jiaxyga.com,
	quic_ipkumar@quicinc.com, luca@z3ntu.xyz,
	stephan.gerhold@kernkonzept.com, nks@flawful.org,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH v4 09/10] dt-bindings: opp: v2-qcom-level: Update minItems for oloop-vadj & cloop-vadj
Date: Mon, 8 Jul 2024 09:55:29 -0600	[thread overview]
Message-ID: <20240708155529.GA3244015-robh@kernel.org> (raw)
In-Reply-To: <20240703091651.2820236-10-quic_varada@quicinc.com>

On Wed, Jul 03, 2024 at 02:46:50PM +0530, Varadarajan Narayanan wrote:
> Since IPQ9574 has only one CPR thread it will specify
> only one voltage adjustment value. Hence update min items
> accordingly for oloop-vadj and cloop-vadj. Without
> constraining min items, dt_binding_check gives errors
> 
> 	opp-table-cpr4:opp-0:qcom,opp-cloop-vadj:0: [0] is too short
> 	opp-table-cpr4:opp-0:qcom,opp-oloop-vadj:0: [0] is too short
> 
> 	Failed validating 'minItems' in schema . . .
> 		{'maxItems': 2, 'minItems': 2}
> 
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
> v4: Fix dt_bindings_check error
> ---
>  Documentation/devicetree/bindings/opp/opp-v2-qcom-level.yaml | 2 ++
>  1 file changed, 2 insertions(+)

This is going to need to be rolled into your dependency because it needs 
the same fix.

> 
> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-qcom-level.yaml b/Documentation/devicetree/bindings/opp/opp-v2-qcom-level.yaml
> index b203ea01b17a..1c1a9e12d57a 100644
> --- a/Documentation/devicetree/bindings/opp/opp-v2-qcom-level.yaml
> +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-level.yaml
> @@ -39,6 +39,7 @@ patternProperties:
>            An array of per-thread values representing the closed-loop
>            voltage adjustment value associated with this OPP node.
>          $ref: /schemas/types.yaml#/definitions/int32-array
> +        minItems: 1
>          maxItems: 2
>  
>        qcom,opp-oloop-vadj:
> @@ -46,6 +47,7 @@ patternProperties:
>            An array of per-thread values representing the open-loop
>            voltage adjustment value associated with this OPP node.
>          $ref: /schemas/types.yaml#/definitions/int32-array
> +        minItems: 1
>          maxItems: 2
>  
>      required:
> -- 
> 2.34.1
> 

  reply	other threads:[~2024-07-08 15:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-03  9:16 [PATCH v4 00/10] Enable CPR for IPQ9574 Varadarajan Narayanan
2024-07-03  9:16 ` [PATCH v4 01/10] soc: qcom: cpr3: Fix 'acc_desc' usage Varadarajan Narayanan
2024-07-03 10:46   ` Dmitry Baryshkov
2024-07-04  5:00     ` Varadarajan Narayanan
2024-07-05 15:16       ` Dmitry Baryshkov
2024-07-09  8:29         ` Varadarajan Narayanan
2024-07-03  9:16 ` [PATCH v4 02/10] cpufreq: qcom-nvmem: Add support for IPQ9574 Varadarajan Narayanan
2024-07-03 10:19   ` Viresh Kumar
2024-07-03 10:47     ` Dmitry Baryshkov
2024-07-03 11:02   ` Dmitry Baryshkov
2024-07-03  9:16 ` [PATCH v4 03/10] dt-bindings: power: rpmpd: Add IPQ9574 power domains Varadarajan Narayanan
2024-07-03  9:16 ` [PATCH v4 04/10] dt-bindings: soc: qcom: cpr3: Add bindings for IPQ9574 Varadarajan Narayanan
2024-07-04  6:35   ` Krzysztof Kozlowski
2024-07-03  9:16 ` [PATCH v4 05/10] pmdomain: qcom: rpmpd: Add IPQ9574 power domains Varadarajan Narayanan
2024-07-09  9:52   ` Konrad Dybcio
2024-07-24  4:27     ` Varadarajan Narayanan
2024-07-24  7:13       ` Dmitry Baryshkov
2024-07-03  9:16 ` [PATCH v4 06/10] dt-bindings: clock: Add CPR clock defines for IPQ9574 Varadarajan Narayanan
2024-07-03  9:16 ` [PATCH v4 07/10] clk: qcom: gcc-ipq9574: Add CPR clock definition Varadarajan Narayanan
2024-07-03  9:16 ` [PATCH v4 08/10] soc: qcom: cpr3: Add IPQ9574 definitions Varadarajan Narayanan
2024-07-03 10:49   ` Dmitry Baryshkov
2024-07-04  5:02     ` Varadarajan Narayanan
2024-07-03  9:16 ` [PATCH v4 09/10] dt-bindings: opp: v2-qcom-level: Update minItems for oloop-vadj & cloop-vadj Varadarajan Narayanan
2024-07-08 15:55   ` Rob Herring [this message]
2024-07-09  7:01     ` Varadarajan Narayanan
2024-07-09 11:28       ` Konrad Dybcio
2024-07-03  9:16 ` [PATCH v4 10/10] dts: arm64: qcom: ipq9574: Enable CPR Varadarajan Narayanan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240708155529.GA3244015-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=abel.vesa@linaro.org \
    --cc=andersson@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=danila@jiaxyga.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ilia.lin@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=luca@z3ntu.xyz \
    --cc=mturquette@baylibre.com \
    --cc=nks@flawful.org \
    --cc=nm@ti.com \
    --cc=otto.pflueger@abscue.de \
    --cc=quic_ipkumar@quicinc.com \
    --cc=quic_rjendra@quicinc.com \
    --cc=quic_rohiagar@quicinc.com \
    --cc=quic_sibis@quicinc.com \
    --cc=quic_varada@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=stephan.gerhold@kernkonzept.com \
    --cc=ulf.hansson@linaro.org \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).