devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4 1/1] dt-bindings: fsl-qdma: allow compatible string fallback to fsl,ls1021a-qdma
@ 2024-07-10 14:54 Frank Li
  2024-08-05 17:38 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Frank Li @ 2024-07-10 14:54 UTC (permalink / raw)
  To: vkoul
  Cc: Frank.Li, conor+dt, devicetree, dmaengine, imx, krzk+dt,
	linux-kernel, robh

The IP of QDMA ls1028/ls1043/ls1046/ is same as ls1021. So allow compatible
string fallback to fsl,ls1021a-qdma.

The difference is that ls1021a-qdma have 3 irqs, and other have 5 irqs.

Fix below CHECK_DTB warning.
arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: dma-controller@8380000: compatible: ['fsl,ls1046a-qdma', 'fsl,ls1021a-qdma'] is too long

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v3 to v4
- rebase to dmaengine/next
- Add Kryzy's review tag
Change from v2 to v3
- previous patch missed a dependent change.
 https://lore.kernel.org/imx/20240701195717.1843041-1-Frank.Li@nxp.com/T/#u
- Combine depedent change to one patch.

Change from v1 to v2
- Change  maxItems: 5 to minItems: 5. because maxItems: 5 already restrict
at top

interrupts:
    minItems: 2
    maxItems: 5
---
---
 Documentation/devicetree/bindings/dma/fsl-qdma.yaml | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/dma/fsl-qdma.yaml b/Documentation/devicetree/bindings/dma/fsl-qdma.yaml
index 1b9ebdbe528a1..9401b1f6300d4 100644
--- a/Documentation/devicetree/bindings/dma/fsl-qdma.yaml
+++ b/Documentation/devicetree/bindings/dma/fsl-qdma.yaml
@@ -11,11 +11,14 @@ maintainers:
 
 properties:
   compatible:
-    enum:
-      - fsl,ls1021a-qdma
-      - fsl,ls1028a-qdma
-      - fsl,ls1043a-qdma
-      - fsl,ls1046a-qdma
+    oneOf:
+      - const: fsl,ls1021a-qdma
+      - items:
+          - enum:
+              - fsl,ls1028a-qdma
+              - fsl,ls1043a-qdma
+              - fsl,ls1046a-qdma
+          - const: fsl,ls1021a-qdma
 
   reg:
     items:
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v4 1/1] dt-bindings: fsl-qdma: allow compatible string fallback to fsl,ls1021a-qdma
  2024-07-10 14:54 [PATCH v4 1/1] dt-bindings: fsl-qdma: allow compatible string fallback to fsl,ls1021a-qdma Frank Li
@ 2024-08-05 17:38 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2024-08-05 17:38 UTC (permalink / raw)
  To: Frank Li
  Cc: conor+dt, devicetree, dmaengine, imx, krzk+dt, linux-kernel, robh


On Wed, 10 Jul 2024 10:54:00 -0400, Frank Li wrote:
> The IP of QDMA ls1028/ls1043/ls1046/ is same as ls1021. So allow compatible
> string fallback to fsl,ls1021a-qdma.
> 
> The difference is that ls1021a-qdma have 3 irqs, and other have 5 irqs.
> 
> Fix below CHECK_DTB warning.
> arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: dma-controller@8380000: compatible: ['fsl,ls1046a-qdma', 'fsl,ls1021a-qdma'] is too long
> 
> [...]

Applied, thanks!

[1/1] dt-bindings: fsl-qdma: allow compatible string fallback to fsl,ls1021a-qdma
      commit: 0204485c5a1e2de00acfd83c3931bd9dc6493c64

Best regards,
-- 
Vinod Koul <vkoul@kernel.org>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-05 17:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-10 14:54 [PATCH v4 1/1] dt-bindings: fsl-qdma: allow compatible string fallback to fsl,ls1021a-qdma Frank Li
2024-08-05 17:38 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).