Re: [PATCH V3 0/4] Add Anbernic RG35XX-SP

[Andre Przywara <andre.przywara@arm.com>]

On Thu, 11 Jul 2024 08:20:24 -0600
"Rob Herring (Arm)" <robh@kernel.org> wrote:

Hi,

> On Wed, 10 Jul 2024 18:17:14 -0500, Chris Morgan wrote:
> > From: Chris Morgan <macromorgan@hotmail.com>
> > 
> > Add support for the Anbernic RG35XX-SP handheld gaming device. The
> > Anbernic RG35XX-SP is a clamshell device, but hardware wise is very
> > similar to the RG35XX-Plus. The RG35XX-SP has a lid-switch and an
> > external RTC that necessitate a distinct device tree.
> > 
> > Please note that this series may have a soft pre-requisite on the patch
> > series here [1].
> > 
> > [1] https://lore.kernel.org/linux-sunxi/20240418000736.24338-1-andre.przywara@arm.com/
> > 
> > Changes from V2:
> >  - Corrected commit message for device tree bindings.
> >  - Added a fixes tag to i2c pinmux additions in sun50i-h616.dtsi file
> >    based on recommendation from Andre Przywara.
> > 
> > Changes from V1:
> >  - Switched all RG35XX devices from the r_rsb bus to the r_i2c bus for
> >    the PMIC to keep it consistent.
> >  - Added missing pinctrl nodes in sun50i-h616.dtsi file for the r_i2c
> >    bus.
> >  - Modified devicetree documentation to keep definition of the RG35XX
> >    series consistent with other Allwinner devices.
> > 
> > Chris Morgan (4):
> >   dt-bindings: arm: sunxi: Add Anbernic RG35XXSP
> >   arm64: dts: allwinner: h616: Add r_i2c pinctrl nodes
> >   arm64: dts: allwinner: h616: Change RG35XX Series from r_rsb to r_i2c
> >   arm64: dts: allwinner: h700: Add Anbernic RG35XX-SP
> > 
> >  .../devicetree/bindings/arm/sunxi.yaml        |  9 +++--
> >  arch/arm64/boot/dts/allwinner/Makefile        |  3 +-
> >  .../arm64/boot/dts/allwinner/sun50i-h616.dtsi |  2 ++
> >  .../sun50i-h700-anbernic-rg35xx-2024.dts      |  6 ++--
> >  .../sun50i-h700-anbernic-rg35xx-sp.dts        | 34 +++++++++++++++++++
> >  5 files changed, 48 insertions(+), 6 deletions(-)
> >  create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-sp.dts
> > 
> > --
> > 2.34.1
> > 
> > 
> >   
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.

That is a problem of an existing .dts files in the tree, namely
sun50i-h700-anbernic-rg35xx-2024.dts. It describes the "boost" regulator,
but the three patches adding that didn't make it in this time.
So how do we deal with that? 
This small binding patch would solve this particular problem:
https://lore.kernel.org/linux-sunxi/20240418000736.24338-4-andre.przywara@arm.com/
It has an ACK from Lee and Krzysztof, but I guess it's too late now for
6.10? Do we just ignore it for now and push it as a fix after -rc1?

Cheers,
Andre

> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y
> allwinner/sun50i-h700-anbernic-rg35xx-2024.dtb
> allwinner/sun50i-h700-anbernic-rg35xx-sp.dtb' for
> 20240710231718.106894-1-macroalpha82@gmail.com:
> 
> arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-2024.dtb:
> pmic@34: regulators: 'boost' does not match any of the regexes:
> '^(([a-f])?ldo[0-9]|dcdc[0-7a-e]|ldo(_|-)io(0|1)|(dc1)?sw|rtc(_|-)ldo|cpusldo|drivevbus|dc5ldo)$',
> 'pinctrl-[0-9]+' from schema $id:
> http://devicetree.org/schemas/mfd/x-powers,axp152.yaml#
> arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-sp.dtb:
> pmic@34: regulators: 'boost' does not match any of the regexes:
> '^(([a-f])?ldo[0-9]|dcdc[0-7a-e]|ldo(_|-)io(0|1)|(dc1)?sw|rtc(_|-)ldo|cpusldo|drivevbus|dc5ldo)$',
> 'pinctrl-[0-9]+' from schema $id:
> http://devicetree.org/schemas/mfd/x-powers,axp152.yaml#
> 
> 
> 
> 
>