From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B38A15957E; Fri, 12 Jul 2024 13:11:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720789897; cv=none; b=rpYBInvux3jtzlY9AbOfVlZjOqnBDbFpJ6NAZaUWhIXCgfMQkKueumffBKaBmo9NT3/lggYFQjy8vwDP5n2ekGA58NKO79NzOzuaCI11GJbF1KDE2bekM5PwRiBQudj9Wf6aU/Ei69ac9e2s4BSM0vKB9vSjg+dPctSosDMtS1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720789897; c=relaxed/simple; bh=HDosvXuSleQyB8lYY7i6tGGf2MEJMbnXC05n5hsQSt8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WwXOylrJQnvod5nN3tBfRr4gxmExn/GiOqIEByXOUA7fh6h/hCtCIU9WZ2ML+30E/c7lAHKbD/8+dMh+IMdMsr1+11PtJHn7gwlpUkwrfZQlc8+sC6+w62t2kLxG9ytJ4XKNTQfKrgcoJ26Xm42HUc9fzaaqCu8JcjTTipVH1cw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=bq2GtCDc; arc=none smtp.client-ip=217.70.183.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="bq2GtCDc" Received: by mail.gandi.net (Postfix) with ESMTPSA id 96204FF811; Fri, 12 Jul 2024 13:11:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1720789886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=StjVOnU5djjXaehWS8TjNnExgQiHvF7T/RHfibeCJL0=; b=bq2GtCDc/yQX7j0iSwRzBaqUG+BHWIGjTD3RSrtHJb0WAoAbTrSv7AzYkV5jZcU5EmCBZJ Np7r9LOxpuWSSr7b6AWb4kTRfbNrGKOI/s8xN3nxlp7TKmLLxKDSlCS40jnjMoEp0HnQVN AOll4fv6Iq8q6S/lQxhqGOuSgb1TIx4p8mmhNjYYBZLaDwBtyTbkUqh8j8abIroK70Se6O l46i48SNnAteGnzfTvYzrwpmCPp1rJDS1vzVFn3L4k9A+nAsKUqHxUvYV8iNMUjXV9h2I3 m9z+Irm4BA7+8Dq7XYx5V9+KUiznXlu1/XUoha+QHZfZIhPNRqQ68zwEPp6PRg== Date: Fri, 12 Jul 2024 15:11:22 +0200 From: Herve Codina To: Rob Herring , Conor Dooley , Conor Dooley Cc: Greg Kroah-Hartman , Lee Jones , Andy Shevchenko , Simon Horman , Krzysztof Kozlowski , Arnd Bergmann , UNGLinuxDriver@microchip.com, Saravana Kannan , Bjorn Helgaas , Philipp Zabel , Lars Povlsen , Steen Hegelund , Daniel Machon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Horatiu Vultur , Andrew Lunn , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allan Nielsen , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v3 6/7] mfd: Add support for LAN966x PCI device Message-ID: <20240712151122.67a17a94@bootlin.com> In-Reply-To: References: <20240627091137.370572-1-herve.codina@bootlin.com> <20240627091137.370572-7-herve.codina@bootlin.com> <20240711152952.GL501857@google.com> <20240711184438.65446cc3@bootlin.com> <2024071113-motocross-escalator-e034@gregkh> Followup-To: linux-kernel@vger.kernel.org Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Hi Rob, Conor, On Thu, 11 Jul 2024 14:33:26 -0600 Rob Herring wrote: > On Thu, Jul 11, 2024 at 1:08 PM Greg Kroah-Hartman > wrote: > > > > On Thu, Jul 11, 2024 at 06:44:38PM +0200, Herve Codina wrote: > > > Hi Lee, > > > > > > On Thu, 11 Jul 2024 16:29:52 +0100 > > > Lee Jones wrote: > > > > > > > On Thu, 27 Jun 2024, Herve Codina wrote: > > > > > > > > > Add a PCI driver that handles the LAN966x PCI device using a device-tree > > > > > overlay. This overlay is applied to the PCI device DT node and allows to > > > > > describe components that are present in the device. > > > > > > > > > > The memory from the device-tree is remapped to the BAR memory thanks to > > > > > "ranges" properties computed at runtime by the PCI core during the PCI > > > > > enumeration. > > > > > > > > > > The PCI device itself acts as an interrupt controller and is used as the > > > > > parent of the internal LAN966x interrupt controller to route the > > > > > interrupts to the assigned PCI INTx interrupt. > > > > > > > > Not entirely sure why this is in MFD. > > > > > > This PCI driver purpose is to instanciate many other drivers using a DT > > > overlay. I think MFD is the right subsystem. > > It is a Multi-function Device, but it doesn't appear to use any of the > MFD subsystem. So maybe drivers/soc/? Another dumping ground, but it > is a driver for an SoC exposed as a PCI device. > In drivers/soc, drivers/soc/microchip/ could be the right place. Conor, are you open to have the PCI LAN966x device driver in drivers/soc/microchip/ ? Best regards, Hervé