From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Vasut <marex@denx.de>,
linux-iio@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Shreeya Patel <shreeya.patel@collabora.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: light: ltrf216a: Document LTR-308 support
Date: Sat, 13 Jul 2024 12:06:35 +0100 [thread overview]
Message-ID: <20240713120635.69fcdda1@jic23-huawei> (raw)
In-Reply-To: <9c6d56a4-6797-4748-b08f-710b4a0b5280@kernel.org>
On Tue, 9 Jul 2024 10:26:17 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 08/07/2024 13:41, Marek Vasut wrote:
> > Document LiteOn LTR-308 support in LTR-F216A bindings.
> >
> > The two devices seem to have almost identical register map, except that
> > the LTR-308 does not have three CLEAR_DATA registers, which are unused
> > by this driver. Furthermore, LTR-308 and LTR-F216A use different lux
> > calculation constants, 0.6 and 0.45 respectively.
> >
> > https://optoelectronics.liteon.com/upload/download/DS86-2016-0027/LTR-308ALS_Final_%20DS_V1%201.pdf
> > https://optoelectronics.liteon.com/upload/download/DS86-2019-0016/LTR-F216A_Final_DS_V1.4.PDF
> >
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied to the testing branch of iio.git which will get rebase on rc1 once available.
One minor request for future series. For any multipatch series it's helpful
to have a cover letter even if there isn't a lot to say. It always provides
2 things that are useful:
1) A title for the series in patchwork.
2) A place for people to give tags for the whole series in a fashion that
automation like b4 can pick up.
Anyhow, not important for a 2 patch series, but a nice to have!
Jonathan
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-07-13 11:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 11:41 [PATCH v2 1/2] dt-bindings: iio: light: ltrf216a: Document LTR-308 support Marek Vasut
2024-07-08 11:41 ` [PATCH v2 2/2] iio: light: ltrf216a: Add " Marek Vasut
2024-07-09 8:26 ` [PATCH v2 1/2] dt-bindings: iio: light: ltrf216a: Document " Krzysztof Kozlowski
2024-07-13 11:06 ` Jonathan Cameron [this message]
2024-07-13 15:53 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240713120635.69fcdda1@jic23-huawei \
--to=jic23@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=marex@denx.de \
--cc=robh@kernel.org \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox