From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: wangshuaijie@awinic.com, lars@metafoo.de, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, waqar.hameed@axis.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, liweilei@awinic.com,
kangjiajun@awinic.com
Subject: Re: [PATCH V3 1/2] dt-bindings: iio: Add YAML to Awinic proximity sensor
Date: Sat, 13 Jul 2024 13:15:10 +0100 [thread overview]
Message-ID: <20240713131510.2c13f2bf@jic23-huawei> (raw)
In-Reply-To: <c466de06-cbc3-4ce7-90fe-4decc6e0fb89@kernel.org>
>
> > + description:
> > + Choose if you want to use a regulator to power the chip. Then the
> > + vccX-supply has to be set.
> > +
> > + vcc0-supply:
> > + description:
> > + Optional regulator for chip, 1.7V-3.6V.
> > + If two awinic sar chips are used, the first regulator
> > + should set the ID to vcc0-supply and the second regulator
> > + should set the ID to vcc1-supply.
> > +
> > + awinic,channel-use-mask:
>
> Aren't there existing IIO properties like this?
>
I'm not sure what this is. If it's about the chip support then the compatible
is enough. If is is about what is wired, then use child nodes per channel
to describe what is connected up.
See adc.yaml for an example - similar can be used for other device types.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description:
> > + The mask of channels used.
> > + Configure according to the specific chip channel used.
> > + Bit[31:0] Each bit represents a channel.
> > + If the customer uses ch0 and ch2, then channel_use_mask=<0x05>
> > + For a 3-channel chip, the maximum value is 0x07;
> > + For a 5-channel chip, the maximum value is 0x1F;
> > + For a 8-channel chip, the maximum value is 0xFF;
> > +
> > + awinic,monitor-esd:
> > + type: boolean
> > + description:
> > + Choose if you want to monitor ESD.
next prev parent reply other threads:[~2024-07-13 12:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 11:31 [PATCH V3 0/2] Add support for Awinic SAR sensor wangshuaijie
2024-07-12 11:31 ` [PATCH V3 1/2] dt-bindings: iio: Add YAML to Awinic proximity sensor wangshuaijie
2024-07-12 11:55 ` Krzysztof Kozlowski
2024-07-13 12:15 ` Jonathan Cameron [this message]
2024-07-25 12:47 ` wangshuaijie
2024-07-25 13:53 ` Krzysztof Kozlowski
2024-07-12 12:34 ` Rob Herring (Arm)
2024-07-12 11:32 ` [PATCH V3 2/2] Add support for " wangshuaijie
2024-07-12 12:01 ` Krzysztof Kozlowski
2024-07-25 12:48 ` wangshuaijie
2024-07-12 14:33 ` Markus Elfring
2024-07-12 22:22 ` kernel test robot
2024-07-13 6:15 ` kernel test robot
2024-07-13 8:50 ` kernel test robot
2024-07-13 10:33 ` kernel test robot
2024-07-13 14:27 ` Jonathan Cameron
2024-07-25 12:47 ` wangshuaijie
2024-07-27 12:22 ` Jonathan Cameron
2024-07-12 11:49 ` [PATCH V3 0/2] Add support for Awinic SAR sensor Waqar Hameed
2024-07-25 12:48 ` wangshuaijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240713131510.2c13f2bf@jic23-huawei \
--to=jic23@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kangjiajun@awinic.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liweilei@awinic.com \
--cc=robh@kernel.org \
--cc=wangshuaijie@awinic.com \
--cc=waqar.hameed@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).