Re: [PATCH] dt-bindings: clock: qcom,turingcc: convert to dtschema

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]

On Mon, Jul 15, 2024 at 05:11:49PM +0100, Conor Dooley wrote:
> On Mon, Jul 15, 2024 at 09:43:10AM +0100, Rayyan Ansari wrote:
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,turingcc.yaml b/Documentation/devicetree/bindings/clock/qcom,turingcc.yaml
> > new file mode 100644
> > index 000000000000..0a57e42fb4d9
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/qcom,turingcc.yaml
> 
> filename should match the compatible in the binding.
> 
> > @@ -0,0 +1,47 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/qcom,turingcc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Turing Clock & Reset Controller
> > +
> > +maintainers:
> > +  - Bjorn Andersson <andersson@kernel.org>
> > +
> > +properties:
> > +  compatible:
> > +    const: qcom,qcs404-turingcc
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  '#clock-cells':
> > +    const: 1
> > +
> > +  '#reset-cells':
> > +    const: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - '#clock-cells'
> > +  - '#reset-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/qcom,gcc-qcs404.h>
> > +    turingcc: clock-controller@800000 {
> 
> nit: drop the label
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

gah, I forgot to say that ack was conditional on the filename being
changed.

> 
> Cheers,
> Conor.
> 
> > +        compatible = "qcom,qcs404-turingcc";
> > +        reg = <0x00800000 0x30000>;
> > +        clocks = <&gcc GCC_CDSP_CFG_AHB_CLK>;
> > +
> > +        #clock-cells = <1>;
> > +        #reset-cells = <1>;
> > +    };
> > -- 
> > 2.45.2
> > 



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]